Hello.
On 17-09-2011 1:01, Wolfgang Denk wrote:
> Dear Sergei Shtylyov,
Thank you for the really quick response. :-)
>> MDSTAT.STATE occupies bits 0..5 according to all available documentation, so
>> fix
>> the masks which previously was leaving out the intermediate state indicator
>> bit.
>> Signed-off-by: Sergei Shtylyov<sshtyl...@ru.mvista.com>
>> ---
>> Resending with the corrected subject/description...
>> Analogous Linux patch has been queued in the linux-davinci tree:
>> http://linux.davincidsp.com/pipermail/davinci-linux-open-source/2011-July/023075.html
>> arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S | 6 +++---
>> arch/arm/cpu/arm926ejs/davinci/psc.c | 4 ++--
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> Index: u-boot/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S
>> ===================================================================
>> --- u-boot.orig/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S
>> +++ u-boot/arch/arm/cpu/arm926ejs/davinci/lowlevel_init.S
>> @@ -268,7 +268,7 @@ checkStatClkStop:
>> checkDDRStatClkStop:
>> ldr r6, MDSTAT_DDR2
>> ldr r7, [r6]
>> - and r7, r7, $0x1f
>> + and r7, r7, $0x3f
> Don't you think it's high time to replace these magic constants with
> at least somewhat meaningful symbolic names (so it would be sufficient
> to fix this in a single place) ?
I agree. Do you mean I should recast this patch, or do two patches
instead: one adding the symbolic name and another correcting its value?
> Best regards,
> Wolfgang Denk
WBR, Sergei
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
