Hello.

On 16-05-2011 6:24, Chris Packham wrote:

> From: Luuk Paulussen <luuk.paulus...@alliedtelesis.co.nz>

> Signed-off-by: Luuk Paulussen<luuk.paulus...@alliedtelesis.co.nz>
> Acked-by: Chris Packham<chris.pack...@alliedtelesis.co.nz>
> Cc: Ben Warren<biggerbadder...@gmail.com>
[...]

> diff --git a/net/bootp.c b/net/bootp.c
> index 4db63cb..18c743e 100644
> --- a/net/bootp.c
> +++ b/net/bootp.c
> @@ -228,6 +228,11 @@ static void BootpVendorFieldProcess (u8 * ext)
>                       NetOurNISDomain[size] = 0;
>               }
>               break;
> +#if defined(CONFIG_CMD_SNTP)&&  defined(CONFIG_BOOTP_NTPSERVER)
> +     case 42:        /* NTP server IP */
> +             NetCopyIP (&NetNtpServerIP, (IPaddr_t *) (ext + 2));

    There should be no space between function name and (. You're now supposed 
to run your patch thru scripts/checkpatch.pl (from Linux source tree).

> +             break;
> +#endif
>               /* Application layer fields */
>       case 43:                /* Vendor specific info - Not yet supported     
> */
>               /*
> @@ -538,6 +548,11 @@ static int BootpExtended (u8 * e)
>       *e++ = 32;
>       e   += 32;
>   #endif
> +#if defined(CONFIG_BOOTP_NTPSERVER)
> +     *e++  = 42;

    Too many spaces...

> +     *e++ = 4;
> +     e   += 4;
> +#endif

WBR, Sergei
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to