Hello.
On 11-05-2011 18:54, Mike Frysinger wrote:
>>> @@ -68,6 +72,23 @@ int post_init_f (void)
>>> int __post_hotkeys_pressed(void)
>>> {
>>> +#ifdef CONFIG_SYS_POST_HOTKEYS_GPIO
>>> + int ret;
>>> + unsigned gpio = CONFIG_SYS_POST_HOTKEYS_GPIO;
>>> +
>>> + ret = gpio_request(gpio, "hotkeys");
>>> + if (ret) {
>>> + printf("POST: gpio hotkey request failed\n");
>>> + return 0;
>>> + }
>>> +
>>> + gpio_direction_input(gpio);
>>> + ret = gpio_get_value(gpio);
>>> + gpio_free(gpio);
>>> +
>>> + return ret;
>>> +#endif
>> You surely meant #else here?
>>> +
>>> return 0; /* No hotkeys supported */
> not really what i was going for. it's fine either way though.
I don't think 2 returns in a row is fine...
> -mike
WBR, Sergei
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
