[PATCH 01/10] arm64: dts: qcom: msm8916/39: Move UART pinctrl to board files

2025-06-25 Thread Stephan Gerhold
-by: Stephan Gerhold Link: https://lore.kernel.org/r/20250422-msm8916-console-pinctrl-v2-1-f345b7a53...@linaro.org Signed-off-by: Bjorn Andersson [ upstream commit: 8d88f6c9c5e774420673a37510b22015b1edd569 ] (cherry picked from commit 9671fb87cd7a78c52ec50cc30ac63e73f2c4ec5a) --- dts/upstream

[PATCH 05/10] board: dragonboard410c: Drop now unneeded bootph-all for console

2025-06-25 Thread Stephan Gerhold
This is applied for all devices upstream in Linux now (when using the console-specific pinctrl templates). Signed-off-by: Stephan Gerhold --- arch/arm/dts/apq8016-sbc-u-boot.dtsi | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/dts/apq8016-sbc-u-boot.dtsi b/arch/arm/dts

[PATCH 08/10] serial: msm: Reset after writing to DMEN

2025-06-25 Thread Stephan Gerhold
s move the reset to the end of uart_dm_init() to better match the recommendations in the documentation. Signed-off-by: Stephan Gerhold --- drivers/serial/serial_msm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_m

[PATCH 03/10] arm64: dts: qcom: msm8919/39: Use UART2 console pinctrl where appropriate

2025-06-25 Thread Stephan Gerhold
it's left as-is in this commit. Reviewed-by: Konrad Dybcio Signed-off-by: Stephan Gerhold Link: https://lore.kernel.org/r/20250422-msm8916-console-pinctrl-v2-3-f345b7a53...@linaro.org Signed-off-by: Bjorn Andersson [ upstream commit: 2b8d22ef1687768e4b572d01cd2432eb86340dd1 ] (cherry p

[PATCH 09/10] serial: msm: Re-enable after resetting

2025-06-25 Thread Stephan Gerhold
eiver/transmitter), but let's add the two writes to RX_ENABLE/TX_ENABLE to better match the recommendations in the documentation. Signed-off-by: Stephan Gerhold --- drivers/serial/serial_msm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/serial/serial_msm.c b/driv

[PATCH 00/10] Fix UART autoboot issues on DragonBoard 410c

2025-06-24 Thread Stephan Gerhold
driver. Fix this by switching the driver to use the more simple single-character mode, which doesn't have this issue. With these patches, autoboot is finally working reliably on DragonBoard 410c (and hopefully will remain so for the future :-)). Signed-off-by: Stephan Gerhold ---

[PATCH 07/10] serial: msm: Cleanup register naming

2025-06-24 Thread Stephan Gerhold
ional change. Signed-off-by: Stephan Gerhold --- drivers/serial/serial_msm.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index c8df91fca589433e57cd4c25a18d0954871

[PATCH 04/10] arm64: dts: qcom: msm8916-motorola: Use UART1 console pinctrl

2025-06-24 Thread Stephan Gerhold
d-by: Konrad Dybcio Signed-off-by: Stephan Gerhold Link: https://lore.kernel.org/r/20250422-msm8916-console-pinctrl-v2-4-f345b7a53...@linaro.org Signed-off-by: Bjorn Andersson [ upstream commit: fe848d64cc6516cd56f38d23cfb544a68231a6e8 ] (cherry picked from co

[PATCH 02/10] arm64: dts: qcom: msm8916/39: Introduce new UART console pinctrl

2025-06-24 Thread Stephan Gerhold
e specifically for that. In the following commits, boards will be converted to use these where appropriate. [1]: https://source.denx.de/u-boot/u-boot/-/commit/ad7e967738a9c639e07cf50b83ffccdf9a8537b0 Reviewed-by: Konrad Dybcio Signed-off-by: Stephan Gerhold Link: https://lore.kernel.org/r/2025

[PATCH 10/10] serial: msm: Use single character mode

2025-06-24 Thread Stephan Gerhold
the additional error information (assuming there is something in the RX FIFO, as indicated by RX_READY). In this mode, querying the serial console size works and autoboot is no longer interrupted. The overall code is also much shorter. Signed-off-by: Stephan Gerhold --- drivers/ser

[PATCH 06/10] Revert "serial: serial_msm: Delay initialization to let pins stabilize"

2025-06-24 Thread Stephan Gerhold
537b0. Signed-off-by: Stephan Gerhold --- drivers/serial/serial_msm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index 757e5eaf974fc171c7a56006a218554be1425612..c8df91fca589433e57cd4c25a18d09548715c840 100644 --- a/drivers/s

Re: [PATCH v2 0/7] Qualcomm: teach the build system to emit signed ELF images

2025-06-04 Thread Stephan Gerhold
On Mon, Jun 02, 2025 at 06:10:51PM +0200, Casey Connolly wrote: > With several new Qualcomm platforms appearing on the mailing list, all > of which build U-Boot as an ELF, sign it, and then flash it to some > partition on the board, we're getting a lot of defconfigs which just > contain a debug UAR

Re: [PATCH v2 6/7] configs: qualcomm: use mkmbn and stop creating ELF files

2025-06-04 Thread Stephan Gerhold
On Mon, Jun 02, 2025 at 06:10:57PM +0200, Casey Connolly wrote: > Remove qcs9100_defconfig since it is now identical to qcom_defconfig. > Additionally remove the load address and REMAKE_ELF from other Qualcomm > defconfigs. > > For these platforms you should explicitly build the u-boot.mbn target

Re: [PATCH v2 3/7] tools: add mkmbn tool for Qualcomm

2025-06-04 Thread Stephan Gerhold
On Mon, Jun 02, 2025 at 06:10:54PM +0200, Casey Connolly wrote: > This is a fork of qtestsign[1] with modifications to integrate with the > U-Boot build system. I think it would be good if the "library" part of qtestsign (cert.py, elf.py, hashseg.py) would stay unmodified if possible, and you only

Re: [PATCH] qcom_defconfig: Enable AUTOBOOT_KEYED support

2025-05-22 Thread Stephan Gerhold
On Mon, May 12, 2025 at 12:31:58PM +0530, Sumit Garg wrote: > On Fri, May 09, 2025 at 04:54:43PM +0200, Stephan Gerhold wrote: > > On Fri, May 09, 2025 at 12:45:20PM +0200, Casey Connolly wrote: > > > On 5/8/25 12:32, Sumit Garg wrote: > > > > From: Sumit Garg >

Re: [PATCH] qcom_defconfig: Enable AUTOBOOT_KEYED support

2025-05-09 Thread Stephan Gerhold
On Fri, May 09, 2025 at 12:45:20PM +0200, Casey Connolly wrote: > On 5/8/25 12:32, Sumit Garg wrote: > > From: Sumit Garg > > > > When debug serial port isn't connected, it is at least reported on RB1 > > that autoboot gets interrupted. It is probably due to random characters > > on the UART RX l

[PATCH v2 6/6] clk: qcom: apq8016: Fix SDCC clock warnings

2025-04-24 Thread Stephan Gerhold
s. Reviewed-by: Neil Armstrong Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-apq8016.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clock-apq8016.c b/drivers/clk/qcom/clock-apq8016.c index e3a9807f580bc995395bd5deb

[PATCH v2 5/6] clk: qcom: apq8016: Convert GATE_CLK() to GATE_CLK_POLLED()

2025-04-24 Thread Stephan Gerhold
: Neil Armstrong Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-apq8016.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/clock-apq8016.c b/drivers/clk/qcom/clock-apq8016.c index 274c71c53ff76c9a7ea18e3698c12b20a9b1f418

[PATCH v2 3/6] clk: qcom: Use setbits_le32() for qcom_gate_clk_en()

2025-04-24 Thread Stephan Gerhold
The other clock enable functions in clock-qcom.c use setbits_le32() to read/modify/write the enable registers. Use the same for qcom_gate_clk_en() to simplify the code a bit. Reviewed-by: Neil Armstrong Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-qcom.c | 5 + 1 file changed

[PATCH v2 4/6] clk: qcom: Allow polling for clock status in qcom_gate_clk_en()

2025-04-24 Thread Stephan Gerhold
until all others drivers have been converted. Reviewed-by: Neil Armstrong Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-qcom.c | 15 +++ drivers/clk/qcom/clock-qcom.h | 11 +-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/clock-q

[PATCH v2 2/6] clk: qcom: Move qcom_gate_clk_en() to C file

2025-04-24 Thread Stephan Gerhold
This avoids having to inline it separately into every single clock driver, when U-Boot is built with support for multiple SoCs. Reviewed-by: Neil Armstrong Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-qcom.c | 15 +++ drivers/clk/qcom/clock-qcom.h | 15

[PATCH v2 1/6] clk: qcom: apq8016: Fix SDCC clock addresses

2025-04-24 Thread Stephan Gerhold
Neil Armstrong Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-apq8016.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/clock-apq8016.c b/drivers/clk/qcom/clock-apq8016.c index 6a53f900a9e5c065714fea9ec

[PATCH v2 0/6] clk: qcom: apq8016: Clock fixes for U-Boot v2025.07

2025-04-24 Thread Stephan Gerhold
Fix some issues in the clock-apq8016 driver that I noticed while testing U-Boot v2025.07-rc on the DragonBoard 410c. Make it possible to poll the clock status with GATE_CLK() to avoid potential race conditions. Signed-off-by: Stephan Gerhold --- Changes in v2: - Rename BRANCH_CLK

[PATCH 6/6] clk: qcom: apq8016: Fix SDCC clock warnings

2025-04-22 Thread Stephan Gerhold
Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-apq8016.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clock-apq8016.c b/drivers/clk/qcom/clock-apq8016.c index 4eb2ba52be0c6f59a987acd0eacea4c7490345a7..ad824aaed73ff15e3a7dd4ea75f7b0cf2ba825c

[PATCH 5/6] clk: qcom: apq8016: Convert GATE_CLK() to BRANCH_CLK()

2025-04-22 Thread Stephan Gerhold
: Stephan Gerhold --- drivers/clk/qcom/clock-apq8016.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/clock-apq8016.c b/drivers/clk/qcom/clock-apq8016.c index 274c71c53ff76c9a7ea18e3698c12b20a9b1f418..4eb2ba52be0c6f59a987acd0eacea4c7490345a7 100644 --- a

[PATCH 4/6] clk: qcom: Allow polling for clock status in qcom_gate_clk_en()

2025-04-22 Thread Stephan Gerhold
work just as before, without polling the clock status. Ideally all usages should be updated to specify the correct poll address in the future. Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-qcom.c | 15 +++ drivers/clk/qcom/clock-qcom.h | 7 +-- 2 files changed, 20 inser

[PATCH 3/6] clk: qcom: Use setbits_le32() for qcom_gate_clk_en()

2025-04-22 Thread Stephan Gerhold
The other clock enable functions in clock-qcom.c use setbits_le32() to read/modify/write the enable registers. Use the same for qcom_gate_clk_en() to simplify the code a bit. Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-qcom.c | 5 + 1 file changed, 1 insertion(+), 4 deletions

[PATCH 2/6] clk: qcom: Move qcom_gate_clk_en() to C file

2025-04-22 Thread Stephan Gerhold
This avoids having to inline it separately into every single clock driver, when U-Boot is built with support for multiple SoCs. Signed-off-by: Stephan Gerhold --- drivers/clk/qcom/clock-qcom.c | 15 +++ drivers/clk/qcom/clock-qcom.h | 15 +-- 2 files changed, 16

[PATCH 1/6] clk: qcom: apq8016: Fix SDCC clock addresses

2025-04-22 Thread Stephan Gerhold
s are disabled when entering U-Boot, MMC initialization is failing. Fix this by using the proper offset for the macros. The SDCC_CMD_RCGR() was already correct, but change it the same way for consistency. Fixes: 085921368b7d ("arm: Add support for Qualcomm Snapdragon family") Signed-off-by:

[PATCH 0/6] clk: qcom: apq8016: Clock fixes for U-Boot v2025.07

2025-04-22 Thread Stephan Gerhold
Fix some issues in the clock-apq8016 driver that I noticed while testing U-Boot v2025.07-rc on the DragonBoard 410c. Make it possible to poll the clock status with GATE_CLK() to avoid potential race conditions. Signed-off-by: Stephan Gerhold --- Stephan Gerhold (6): clk: qcom: apq8016: Fix

[PATCH 3/3] board: dragonboard410c: Enable support for KASLR in Linux

2025-04-18 Thread Stephan Gerhold
Signed-off-by: Stephan Gerhold --- configs/dragonboard410c_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/dragonboard410c_defconfig b/configs/dragonboard410c_defconfig index 6feba70b943ecafdb96de28b4bddc36095f089c6..d267b6ed34dbb945cb3c5af8e323bdbdc294197e 100644 --- a

[PATCH 0/3] board: dragonboard410c: More fixes for U-Boot v2025.07

2025-04-17 Thread Stephan Gerhold
Fix some more issues in the U-Boot configuration for the DragonBoard 410c that I noticed when testing the current master branch after the recent changes were merged. Ideally these should go as fixes into v2025.07. Signed-off-by: Stephan Gerhold --- Stephan Gerhold (3): board

[PATCH 2/3] board: dragonboard410c: Drop custom reduced malloc size

2025-04-17 Thread Stephan Gerhold
x27;Malloc failed for: CHUNK_TYPE_RAW') We are not really that memory-constrained for U-Boot on DB410c, so fix this by just dropping the custom malloc size and using the default. Signed-off-by: Stephan Gerhold --- configs/dragonboard410c_defconfig | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 1/3] board: dragonboard410c: Fix button cmd name

2025-04-17 Thread Stephan Gerhold
own". This is causing errors in the console during boot now: No button labelled 'vol_down' Fix this by using the new label. Fixes: 359e1d4a57e0 ("board: dragonboard410c: Use button_cmd instead of custom code") Fixes: 8f5685d5d32f ("button: qcom-pmic: prettif

Re: [PATCH 2/3] usb: host: ehci-msm: Register ChipIdea UDC from glue wrapper

2025-04-16 Thread Stephan Gerhold
On Sat, Apr 12, 2025 at 07:40:03PM +, Sam Day wrote: > When CONFIG_DM_USB_GADGET is enabled, the CI UDC driver needs to be > explicitly bound. So we do this from the newly introduced glue driver. > > Signed-off-by: Sam Day > --- > drivers/usb/host/ehci-msm.c | 7 +++ > 1 file changed, 7

Re: [PATCH 3/3] qcom_defconfig: Enable MSM8916 USB PHY + ChipIdea UDC

2025-04-16 Thread Stephan Gerhold
On Sat, Apr 12, 2025 at 07:40:11PM +, Sam Day wrote: > Now that the ChipIdea UDC driver supports USB Gadget driver model, we > can enable it alongside the dwc3 generic driver. > > Signed-off-by: Sam Day > --- > configs/qcom_defconfig | 6 ++ > 1 file changed, 6 insertions(+) > > diff --

Re: [PATCH 1/3] usb: udc: ci: support USB gadget driver model

2025-04-16 Thread Stephan Gerhold
On Sat, Apr 12, 2025 at 07:39:57PM +, Sam Day wrote: > When CONFIG_DM_USB_GADGET is enabled, a UCLASS_USB_GADGET_GENERIC driver > will be defined that wraps the ChipIdea UDC operations. The > (dm_)?usb_gadget_.* symbols will no longer be defined (as these are now > handled by the UDC uclass). >

[PATCH] IOMUX: Fix stopping unused dropped consoles

2025-04-10 Thread Stephan Gerhold
t out iomux_match_device() helper") Signed-off-by: Stephan Gerhold --- common/iomux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/iomux.c b/common/iomux.c index 1224c15eb718b5e78f625f57274000114d85c7de..4844df51fbec645f54d14f31e34ed717da056667 100644 --- a/common/iom

[PATCH 03/13] board: dragonboard410c: Fix BD address

2025-04-10 Thread Stephan Gerhold
27;re also flipping the wrong bit when generating the BD address. Before reversing the array, the least significant bit is in the last byte. Fixes: ff06dc240325 ("db410: alter WLAN/BT MAC address fixup") Signed-off-by: Stephan Gerhold --- board/qualcomm/dragonboard410c/dr

[PATCH 10/13] board: dragonboard410c: Use BOOTSTD instead of DISTRO_DEFAULTS

2025-04-10 Thread Stephan Gerhold
onsistency, but for now this keeps the behavior similar to before. Signed-off-by: Stephan Gerhold --- board/qualcomm/dragonboard410c/dragonboard410c.env | 1 + configs/dragonboard410c_defconfig | 3 ++- include/configs/dragonboard410c.h | 11 --- 3 files

Re: [PATCH 11/13] board: dragonboard410c: Enable support for Android boot images

2025-04-08 Thread Stephan Gerhold
On Mon, Apr 07, 2025 at 08:10:24PM +0200, Neil Armstrong wrote: > On 07/04/2025 18:59, Stephan Gerhold wrote: > > The U-Boot port for DB410c still has plenty of extra space available at > > this point, so avoid disabling features that would be normally enabled by > > default

[PATCH 04/13] board: dragonboard410c: Drop UNSTUFF_BITS() macro

2025-04-07 Thread Stephan Gerhold
ned-off-by: Stephan Gerhold --- board/qualcomm/dragonboard410c/dragonboard410c.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard41

[PATCH 05/13] board: dragonboard410c: Drop reflash functionality

2025-04-07 Thread Stephan Gerhold
This is broken ever since we switched to using U-Boot as first stage bootloader. Since no one seems to test this actively, let's just drop this entirely. There are other tools available for re-flashing the DB410c. Signed-off-by: Stephan Gerhold --- board/qualcomm/dragonboar

[PATCH 13/13] board: dragonboard410c: Update maintainers

2025-04-07 Thread Stephan Gerhold
he's been doing lots of testing and reviews for MSM8916 recently. Cc: Sam Day Cc: Ramon Fried Signed-off-by: Stephan Gerhold --- @Ramon: If you want to stay co-maintainer please let me know, I'm also happy to just add myself and Sam additionally. --- board/qualcomm/dragonboard410c/

[PATCH 12/13] board: dragonboard410c: Use button_cmd instead of custom code

2025-04-07 Thread Stephan Gerhold
Simplify the board code by using the new BUTTON_CMD functionality, instead of implementing this separately using C code. This allows disabling or customizing this functionality if wanted. Signed-off-by: Stephan Gerhold --- board/qualcomm/dragonboard410c/dragonboard410c.c | 22

[PATCH 11/13] board: dragonboard410c: Enable support for Android boot images

2025-04-07 Thread Stephan Gerhold
. Signed-off-by: Stephan Gerhold --- configs/dragonboard410c_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/configs/dragonboard410c_defconfig b/configs/dragonboard410c_defconfig index 62fc42c9460d075fd27c3e2823eb8eea2a559772..414dda6778c95eb3fdcd6ef522d8c7d0ef9219fa 100644 --- a

[PATCH 08/13] board: dragonboard410c: Fix counter frequency

2025-04-07 Thread Stephan Gerhold
The actual counter frequency is 19.2 MHz, not 19.0 MHz. This isn't really used so far though, since probably no one (except me) ever tried using U-Boot in EL3 where we need to program the counter frequency. Signed-off-by: Stephan Gerhold --- configs/dragonboard410c_defconfig | 2 +- 1

[PATCH 07/13] board: dragonboard410c: Use dynamically allocated load addresses

2025-04-07 Thread Stephan Gerhold
ff-by: Stephan Gerhold --- board/qualcomm/dragonboard410c/dragonboard410c.c | 2 +- board/qualcomm/dragonboard410c/dragonboard410c.env | 8 +--- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboar

[PATCH 09/13] board: dragonboard410c: Enable RTL8152 ethernet

2025-04-07 Thread Stephan Gerhold
The Geniatech DB4 V3 [1] has a RTL8152 onboard for Ethernet. I don't have one to test if that works, but the other USB Ethernet drivers work pretty much as-is, so just enable it with the assumption it will work out fine. [1]: https://www.96boards.org/product/db4/ Signed-off-by: Stephan Ge

[PATCH 06/13] board: dragonboard410c: Drop unused linux_image

2025-04-07 Thread Stephan Gerhold
This does not seem to be used anywhere. Signed-off-by: Stephan Gerhold --- board/qualcomm/dragonboard410c/dragonboard410c.env | 1 - 1 file changed, 1 deletion(-) diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.env b/board/qualcomm/dragonboard410c/dragonboard410c.env index

[PATCH 02/13] board: dragonboard410c: Fix RAM size

2025-04-07 Thread Stephan Gerhold
e with upstream DTS") Signed-off-by: Stephan Gerhold --- arch/arm/dts/apq8016-sbc-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/apq8016-sbc-u-boot.dtsi b/arch/arm/dts/apq8016-sbc-u-boot.dtsi index 585d54d29623823145e6

[PATCH 01/13] mach-snapdragon: Fix EL2 boot on DragonBoard 410c

2025-04-07 Thread Stephan Gerhold
r configuration on DB410c, and nothing would place a DTB there anyway. Skip selecting the SAVE_PREV_BL_FDT_ADDR option for the boot0 hook case to avoid crashing with the clobbered register value. Fixes: 059d526af312 ("mach-snapdragon: generalise board support") Signed-off-by: Steph

[PATCH 00/13] board: dragonboard410c: Various fixes and cleanup

2025-04-07 Thread Stephan Gerhold
ff-by: Stephan Gerhold --- Stephan Gerhold (13): mach-snapdragon: Fix EL2 boot on DragonBoard 410c board: dragonboard410c: Fix RAM size board: dragonboard410c: Fix BD address board: dragonboard410c: Drop UNSTUFF_BITS() macro board: dragonboard410c: Drop re

[PATCH 3/3] usb: gadget: introduce 'enabled' flag in struct usb_ep

2025-04-07 Thread Stephan Gerhold
by Robert Baldyga. Fix the crashes for f_acm by making the same change in U-Boot. This makes the API less bug-prone and avoids introducing crashes when adapting new gadget drivers from Linux. Signed-off-by: Stephan Gerhold --- include/linux/usb/gadget.h | 27 +-- 1 file

[PATCH 2/3] usb: gadget: f_acm: Allow restarting ACM console after stopping it

2025-04-07 Thread Stephan Gerhold
gadget is unregistered, but as long as dev->priv stays set acm_stdio_start() will never register the USB gadget again. Clear dev->priv after we detach to make sure a start operation after a stop operation registers the gadget again. Fixes: fc2b399ac03b ("usb: gadget: Add CDC ACM function&quo

[PATCH 1/3] usb: gadget: f_acm: Claim requested USB endpoints

2025-04-07 Thread Stephan Gerhold
disallows calling usb_ep_enable() multiple times. Fix this by assigning some data to ep->driver_data, similar to the other gadget drivers. Fixes: fc2b399ac03b ("usb: gadget: Add CDC ACM function") Signed-off-by: Stephan Gerhold --- drivers/usb/gadget/f_acm.c | 3 +++ 1 file changed, 3 inse

[PATCH 0/3] usb: gadget: Fix issues when using f_acm with ci_udc

2025-04-07 Thread Stephan Gerhold
Gerhold --- Stephan Gerhold (3): usb: gadget: f_acm: Claim requested USB endpoints usb: gadget: f_acm: Allow restarting ACM console after stopping it usb: gadget: introduce 'enabled' flag in struct usb_ep drivers/usb/gadget/f_acm.c | 4 include/linux/usb/gad

[PATCH 0/6] usb: host: ehci-msm: Clean up and fix crashes

2025-04-07 Thread Stephan Gerhold
Gerhold --- Stephan Gerhold (6): usb: host: ehci-msm: Fix pointer check usb: host: echi-msm: Drop ulpi definitions usb: host: ehci-msm: Disable clocks after all register accesses usb: host: ehci-msm: Use clk bulk helpers usb: host: ehci-msm: Drop redundant EHCI register

[PATCH 2/6] usb: host: echi-msm: Drop ulpi definitions

2025-04-07 Thread Stephan Gerhold
These are unused. Signed-off-by: Stephan Gerhold --- drivers/usb/host/ehci-msm.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index dd1d527a3a2c3f38df747dbb41cbb84bf76286e2..60b2dc44d3d35ddc5b8cf37f70bbccd91c5e962c 100644

[PATCH 5/6] usb: host: ehci-msm: Drop redundant EHCI register writes

2025-04-07 Thread Stephan Gerhold
just drop them. Signed-off-by: Stephan Gerhold --- drivers/usb/host/ehci-msm.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 17cfff8380c3953900fe6383bee396b147287592..659a917ad27372f8f5c7138c40881b60413323e5 1

[PATCH 3/6] usb: host: ehci-msm: Disable clocks after all register accesses

2025-04-07 Thread Stephan Gerhold
("ehci: msm: bring up iface + core clocks") Signed-off-by: Stephan Gerhold --- drivers/usb/host/ehci-msm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 60b2dc44d3d35ddc5b

[PATCH 4/6] usb: host: ehci-msm: Use clk bulk helpers

2025-04-07 Thread Stephan Gerhold
The enable order for the clocks does not matter much, we just need to enable all the USB clocks. Use the clk bulk helpers to simplify the code. Signed-off-by: Stephan Gerhold --- drivers/usb/host/ehci-msm.c | 36 +++- 1 file changed, 11 insertions(+), 25

[PATCH 6/6] usb: host: ehci-msm: Register ULPI PHY through NOP wrapper

2025-04-07 Thread Stephan Gerhold
re.kernel.org/u-boot/osqpr04mb774067ebeeadd714efe18c2a90...@osqpr04mb7740.apcprd04.prod.outlook.com/ Signed-off-by: Stephan Gerhold --- drivers/usb/host/ehci-msm.c | 107 +++- 1 file changed, 65 insertions(+), 42 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/d

[PATCH 1/6] usb: host: ehci-msm: Fix pointer check

2025-04-07 Thread Stephan Gerhold
dev_read_addr_ptr() returns a null pointer on error, not FDT_ADDR_T_NONE. Fixes: 2be1130a9305 ("usb: ehci-msm: Use dev interface to get device address") Signed-off-by: Stephan Gerhold --- drivers/usb/host/ehci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH 13/15] mach-snapdragon: support parsing memory map from SMEM

2025-01-08 Thread Stephan Gerhold
On Sun, Nov 24, 2024 at 08:17:55PM +0100, Caleb Connolly wrote: > It is possible to derive the memory map for a Qualcomm platform from the > SMEM shared memory region. The memory map is populated by the preloader. > > Introduce support for parsing this data and using it to populate > U-Boot's memo

Re: [PATCH 08/15] soc: qcom: smem: get serial number from socinfo

2025-01-08 Thread Stephan Gerhold
On Sun, Nov 24, 2024 at 08:17:50PM +0100, Caleb Connolly wrote: > Implement socinfo support to fetch the serial number if available. > > Signed-off-by: Caleb Connolly > --- > drivers/soc/qcom/smem.c | 25 + > include/soc/qcom/smem.h | 1 + > 2 files changed, 26 insertion

Re: [PATCH v3 6/6] board: add support for Schneider HMIBSC board

2024-04-05 Thread Stephan Gerhold
On Fri, Apr 05, 2024 at 02:37:42PM +0530, Sumit Garg wrote: > Support for Schneider Electric HMIBSC. Features: > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > - 2GiB RAM > - 64GiB eMMC, SD slot > - WiFi and Bluetooth > - 2x Host, 1x Device USB port > - HDMI > - Discrete TPM2

Re: [PATCH v2 5/5] board: add support for Schneider HMIBSC board

2024-03-13 Thread Stephan Gerhold
On Wed, Mar 13, 2024 at 12:08:58PM +0530, Sumit Garg wrote: > On Mon, 11 Mar 2024 at 20:07, Stephan Gerhold wrote: > > On Mon, Mar 11, 2024 at 04:40:26PM +0530, Sumit Garg wrote: > > > Support for Schneider Electric HMIBSC. Features: > > > - Qualcomm Snapdragon 410C

Re: [PATCH v2 5/5] board: add support for Schneider HMIBSC board

2024-03-11 Thread Stephan Gerhold
On Mon, Mar 11, 2024 at 04:40:26PM +0530, Sumit Garg wrote: > Support for Schneider Electric HMIBSC. Features: > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > - 2GiB RAM > - 64GiB eMMC, SD slot > - WiFi and Bluetooth > - 2x Host, 1x Device USB port > - HDMI > - Discrete TPM2

Re: [PATCH v2 2/5] apq8016: Add support for UART1 clocks and pinmux

2024-03-11 Thread Stephan Gerhold
On Mon, Mar 11, 2024 at 12:27:11PM +, Caleb Connolly wrote: > On 11/03/2024 11:10, Sumit Garg wrote: > > SE HMIBSC board uses UART1 as the main debug console, so add > > corresponding clocks and pinmux support. Along with that update > > instructions to enable clocks for debug UART support. > >

Re: [PATCH 8/8] board: add support for Qualcomm SA8155P-ADP board

2024-03-04 Thread Stephan Gerhold
On Thu, Feb 29, 2024 at 02:21:09PM +, Volodymyr Babchuk wrote: > SA8155P Automotive Development Platform is Qualcomm SA8155-based board > for developers. The nice thing that it has unlocked loaders with test > keys support, which means that U-Boot for this platform can be > launched at earlier

Re: [PATCH 0/8] Add support for Qualcomm SA8155-ADP board

2024-03-04 Thread Stephan Gerhold
On Fri, Mar 01, 2024 at 06:25:39PM +, Volodymyr Babchuk wrote: > Caleb Connolly writes: > > On 29/02/2024 14:21, Volodymyr Babchuk wrote: > >> This patch series adds support for Qualcomm SA8155-ADP development > >> board. Main motivation for this series is to allow running > >> virtualization

Re: [PATCH 18/21] dts: msm8916: import DT from Linux

2023-12-07 Thread Stephan Gerhold
On Thu, Dec 07, 2023 at 07:11:02PM +, Caleb Connolly wrote: > On 21/11/2023 19:21, Stephan Gerhold wrote: > > On Tue, Nov 21, 2023 at 05:09:41PM +, Caleb Connolly wrote: > >> Import the msm8916 devicetree from Linux and adjust the dragonboard410c > &g

Re: [PATCH 18/21] dts: msm8916: import DT from Linux

2023-11-21 Thread Stephan Gerhold
On Tue, Nov 21, 2023 at 05:09:41PM +, Caleb Connolly wrote: > Import the msm8916 devicetree from Linux and adjust the dragonboard410c > devicetree to use it. > Can you add a note here from which Linux version you took the DT? It seems quite old, the msm8916-pm8916.dtsi doesn't exist anymore

Re: [PATCH v2 3/5] gpio: qcom_pmic: fix support for upstream DT

2023-11-09 Thread Stephan Gerhold
On Wed, Nov 08, 2023 at 04:20:55PM +, Caleb Connolly wrote: > Linux devicetrees use the "gpio-ranges" property, add support for > parsing it instead of "gpio-count" so that upstream DTs can be used with > U-Boot. > > Signed-off-by: Caleb Connolly > --- > drivers/gpio/qcom_pmic_gpio.c | 26 ++

Re: [PATCH v2 2/5] gpio: qcom_pmic: rework pwrkey driver into a button driver

2023-11-09 Thread Stephan Gerhold
On Wed, Nov 08, 2023 at 04:20:54PM +, Caleb Connolly wrote: > The power and resin keys were implemented as GPIOs here, but their only > use would be as buttons. Avoid the additional layer of introspection and > rework this driver into a button driver. > > While we're here, replace the "qcom,pm

Re: [PATCH 2/5] gpio: qcom_pmic: rework pwrkey driver into a button driver

2023-11-07 Thread Stephan Gerhold
On Mon, Nov 06, 2023 at 08:57:30PM +, Caleb Connolly wrote: > The power and resin keys were implemented as GPIOs here, but their only > use would be as buttons. Avoid the additional layer of introspection and > rework this driver into a button driver. > > While we're here, replace the "qcom,pm

Re: [PATCH 13/14] i2c: Add support for Qualcomm I2C driver

2023-01-20 Thread Stephan Gerhold
On Fri, Jan 20, 2023 at 05:55:35PM +0530, Sumit Garg wrote: > On Fri, 20 Jan 2023 at 14:16, Heiko Schocher wrote: > > On 20.01.23 08:17, Sumit Garg wrote: > > > Add support for Qualcomm I2C QUP driver which is inspired from > > > corresponding driver in Linux: drivers/i2c/busses/i2c-qup.c. > > > >

Re: [PATCH] arm: dts: qcom: Sync pinctrl DT nodes with Linux bindings

2022-07-16 Thread Stephan Gerhold
On Fri, Jul 15, 2022 at 03:21:45PM +0530, Sumit Garg wrote: > On Thu, 14 Jul 2022 at 23:45, Stephan Gerhold wrote: > > On Thu, Jul 14, 2022 at 01:03:37PM +0530, Sumit Garg wrote: > > > This is based on top of mine other patch-set [1]. Although, I have > > > tested it o

Re: [PATCH v3 9/9] board: qualcomm: Add support for QCS404 EVB

2022-07-14 Thread Stephan Gerhold
On Thu, Jul 14, 2022 at 01:10:45PM +0530, Sumit Garg wrote: > On Thu, 14 Jul 2022 at 01:02, Stephan Gerhold wrote: > > Can you check how hard it would be to reuse the upstream QCS404 DT? > > > > It turned out to be patch [1] on top of this patch-set. Please help me >

Re: [PATCH] arm: dts: qcom: Sync pinctrl DT nodes with Linux bindings

2022-07-14 Thread Stephan Gerhold
pinctrl driver in case > "gpio-controller" property is specified for pinctrl node. > > Suggested-by: Stephan Gerhold > Signed-off-by: Sumit Garg This is a great start, thank you! > --- > > This is based on top of mine other patch-set [1]. Although, I have >

Re: [PATCH v3 9/9] board: qualcomm: Add support for QCS404 EVB

2022-07-13 Thread Stephan Gerhold
Hi Sumit, On Tue, Jul 12, 2022 at 12:42:12PM +0530, Sumit Garg wrote: > Add support for Qualcomm QCS404 SoC based evaluation board. > > Features: > - Qualcomm Snapdragon QCS404 SoC > - 1GiB RAM > - 8GiB eMMC, uSD slot > > U-boot is chain loaded by ABL in 64-bit mode as part of boot.img. > For de

[PATCH] arm: dts: db410c/db820c: Fix SPMI addresses

2022-07-13 Thread Stephan Gerhold
moving to using the Linux DTs as-is. This would likely avoid such mistakes in the future and would also make the porting process much easier. Cc: Dzmitry Sankouski Fixes: f5a2d6b4b03a ("spmi: msm: add arbiter version 5 support") Signed-off-by: Stephan Gerhold --- Sorry for sending th

Re: [PATCH v2] board: stemmy: Increase boot image to 64 MB

2021-11-23 Thread Stephan Gerhold
LEN > Must RESET board to recover > > Fix this by bumping to SZ_64MB. > > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij Great, thanks for changing it! :) Reviewed-by: Stephan Gerhold > --- > ChangeLog v1->v2: > - Bump to 64MB instead of 16MB > --- >

Re: [PATCH] board: stemmy: Increase boot image to 16 MB

2021-11-19 Thread Stephan Gerhold
gt; > > > Loading Kernel Image > > Image too large: increase CONFIG_SYS_BOOTM_LEN > > Must RESET board to recover > > > > Fix this by bumping to SZ_16MB. > > > > Cc: Stephan Gerhold > > Signed-off-by: Linus Walleij > > --- > >

Re: [PATCH 6/6 v3] board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board

2021-09-24 Thread Stephan Gerhold
Hi, On Fri, Sep 24, 2021 at 05:35:57PM +0300, Dzmitry Sankouski wrote: > I haven't tried to install u-boot on the phone with Android boot image > yet(though another guy in the community project I contribute, reported it > works). > I can only test u-boot with kexec, it's the only way to get debug

Re: [PATCH 6/6 v3] board: samsung: add Samsung Galaxy S9/S9+(SM-G96x0) board

2021-09-24 Thread Stephan Gerhold
Hi, On Thu, Sep 23, 2021 at 09:57:32PM +0300, dsankou...@gmail.com wrote: > From: Dzmitry Sankouski > > Samsung S9 SM-G9600 - Snapdragon SDM845 version of the phone, > for China \ Hong Kong markets. > Has unlockable bootloader, unlike SM-G960U (American market version), > which allows running u-

Re: [PATCH 5/6] SoC: qcom: add support for SDM845

2021-09-24 Thread Stephan Gerhold
Hi, On Thu, Sep 23, 2021 at 09:57:31PM +0300, dsankou...@gmail.com wrote: > From: Dzmitry Sankouski > > Hi-end qualcomm chip, introduced in late 2017. > Mostly used in flagship phones and tablets of 2018. > Features: > - arm64 arch > - total of 8 Kryo 385 Gold / Silver cores > - Hexagon 685 DSP

Re: [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM845 SoC

2021-09-24 Thread Stephan Gerhold
Hi, On Thu, Sep 23, 2021 at 09:57:29PM +0300, dsankou...@gmail.com wrote: > From: Dzmitry Sankouski > > Signed-off-by: Dzmitry Sankouski > Cc: Ramon Fried > Cc: Tom Rini > --- > arch/arm/mach-snapdragon/pinctrl-sdm845.c | 44 +++ > arch/arm/mach-snapdragon/pinctrl-snapdra

Re: [PATCH 3/5] arm: Disable ATAGs support

2021-09-04 Thread Stephan Gerhold
Hi Tom, On Mon, Aug 30, 2021 at 09:16:30AM -0400, Tom Rini wrote: > With the exception of nokia_rx51 and icnova-a20-swac, disable ATAG > support. A large number of platforms had enabled support but never > supported a kernel so old as to require it. Further, some platforms are > old enough to su

[PATCH 4/7] arm: dts: u8500: u-boot: Add fixed clock for eMMC

2021-08-07 Thread Stephan Gerhold
U8500, so for now add a simple fixed-clock for the eMMC that allows obtaining the clock frequency. This should be replaced eventually if some board actually requires enabling some of the clocks. Signed-off-by: Stephan Gerhold --- arch/arm/dts/ste-dbx5x0-u-boot.dtsi | 11 ++- 1 file changed

[PATCH 7/7] arm: u8500: Prefer building in thumb mode by default

2021-08-07 Thread Stephan Gerhold
Enabling CONFIG_SYS_THUMB_BUILD produces a significantly smaller U-Boot binary (250 KiB vs 320 KiB) that still seems to be fully functional. Make use of that by default but keep it as "imply" so it can be disabled for testing in case this causes trouble for someone. Signed-off-by: Steph

[PATCH 6/7] board: stemmy: Update documentation

2021-08-07 Thread Stephan Gerhold
instead of just ending up at the U-Boot prompt. The device table is mostly taken from the postmarketOS wiki article (https://wiki.postmarketos.org/wiki/ST-Ericsson_NovaThor_U8500). All the newly added devices were tested by Linus Walleij. Signed-off-by: Stephan Gerhold --- I tried to have

[PATCH 3/7] arm: dts: u8500: Update from Linux ux500-dts-for-v5.15

2021-08-07 Thread Stephan Gerhold
kernel.org/linux-arm-kernel/20210709182234.47232-1-step...@gerhold.net/ Signed-off-by: Stephan Gerhold --- arch/arm/dts/ste-ab8500.dtsi | 116 +++ arch/arm/dts/ste-ab8505.dtsi | 95 ++-- arch/arm/dts/ste-dbx5x0.dtsi | 14 ++--- 3 files cha

[PATCH 5/7] board: stemmy: Add basic Fastboot support

2021-08-07 Thread Stephan Gerhold
. Samsung uses quite strange GPT partition labels on these boards, so also add a bunch of fastboot_partition_alias_* to make this more easy to use. Signed-off-by: Stephan Gerhold --- arch/arm/dts/ste-ux500-samsung-stemmy.dts | 16 ++ configs/stemmy_defconfig

[PATCH 2/7] arm: u8500: Imply options for new drivers

2021-08-07 Thread Stephan Gerhold
otherwise the Ux500 MUSB glue driver does not show up in the configuration. Signed-off-by: Stephan Gerhold --- arch/arm/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 3a745ce126..dd223ada57 100644 --- a/arch/arm/Kconfig +++ b/arch/a

[PATCH 0/7] Enable new drivers added for U-Boot 2021.10 in "stemmy" board

2021-08-07 Thread Stephan Gerhold
This series finishes up the work done for ARM U8500 in the U-Boot 2021.10 merge window. The new drivers are added to MAINTAINERS, then enabled in Kconfig and finally the "stemmy" board is updated to make use of them. Stephan Gerhold (7): MAINTAINERS: Add new drivers for ARM U8500

[PATCH 1/7] MAINTAINERS: Add new drivers for ARM U8500

2021-08-07 Thread Stephan Gerhold
Update MAINTAINERS with various drivers for ARM U8500 that were added during the U-Boot 2021.10 merge window. Signed-off-by: Stephan Gerhold --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 776ff703b9..d64dcfacad 100644 --- a/MAINTAINERS

[PATCH v2 2/2] arm: mach-snapdrgon: misc: Simplify msm_generate_mac_addr()

2021-08-03 Thread Stephan Gerhold
more efficient and cleaner but does not result in any functional difference. Cc: Ramon Fried Signed-off-by: Stephan Gerhold --- Changes in v2: - Rebase on u-boot/master to fix conflict with recent changes - Add comment to clarify what put_unaligned_be32() does here arch/arm/mach

[PATCH v2 1/2] arm: mach-snapdragon: misc: Initialize eMMC if necessary

2021-08-03 Thread Stephan Gerhold
quot; that is later accessed. To fix this, call mmc_init() to ensure the eMMC is initialized. There is no functional difference if the eMMC is already initialized since then mmc_init() will just return without doing anything. Reviewed-by: Ramon Fried Signed-off-by: Stephan Gerhold --- (no cha

  1   2   >