On Sun, 2025-05-25 at 15:42 +0200, Marek Vasut wrote:
> Un-orphan the RZ/G2L , keep the RZ/G2L maintained.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
signature.asc
Description: This is a digitally signed message part
I still intend to review patches, and will be using my own email address
going forward.
Signed-off-by: Paul Barker
---
board/renesas/rzg2l/MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/renesas/rzg2l/MAINTAINERS b/board/renesas/rzg2l/MAINTAINERS
index
pped instead.
>
> For TFTP loading, an RX error produces the timeout "T" output and
> resumes the TFTP loading operation shortly afterward, without any
> data corruption.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3
On 24/03/2025 23:05, Marek Vasut wrote:
> On 3/24/25 11:12 AM, Paul Barker wrote:
>> On 24/03/2025 01:11, Marek Vasut wrote:
>>> On 3/19/25 1:03 PM, Paul Barker wrote:
>>>
>>> [...]
>>>
>>>> +++ b/drivers/net/Kconfig
>>&g
On 24/03/2025 19:48, Marek Vasut wrote:
> On 3/24/25 10:57 AM, Paul Barker wrote:
>> On 24/03/2025 01:08, Marek Vasut wrote:
>>> On 3/19/25 1:03 PM, Paul Barker wrote:
>>>
>>> [...]
>>>
>>>>static int ravb_probe(struct udevice *
pped instead.
>
> For TFTP loading, an RX error produces the timeout "T" output and
> resumes the TFTP loading operation shortly afterward, without any
> data corruption.
>
> Signed-off-by: Marek Vasut
> ---
> Cc: Joe Hershberger
> Cc: Nobuhiro Iwamatsu
&
On 24/03/2025 01:11, Marek Vasut wrote:
> On 3/19/25 1:03 PM, Paul Barker wrote:
>
> [...]
>
>> +++ b/drivers/net/Kconfig
>> @@ -864,7 +864,7 @@ config RENESAS_RAVB
>> select PHY_ETHERNET_ID
>> help
>>This driver implem
On 24/03/2025 01:08, Marek Vasut wrote:
> On 3/19/25 1:03 PM, Paul Barker wrote:
>
> [...]
>
>> static int ravb_probe(struct udevice *dev)
>> {
>> +struct ravb_device_ops *device_ops =
>> +(struct ravb_device_ops *)dev_get_driver_data(d
set_deassert
methods to simplify the code.
- Keep the code sorted alphabetically in various places (rcar before
rzg).
[1]:
https://lore.kernel.org/all/20241024152448.102-1-paul.barker...@bp.renesas.com/
Paul Barker (4):
net: ravb: Refactor out R-Car specific code
net: ravb: Add optio
In order to add support for the Renesas RZ/G2L Ethernet IP in a
subsequent patch, we move all R-Car specific code into new functions and
introduce a device_ops function pointer table.
Signed-off-by: Paul Barker
---
drivers/net/ravb.c | 80 +++---
1 file
Linux.
Signed-off-by: Paul Barker
---
configs/renesas_rzg2l_smarc_defconfig | 6 ++
1 file changed, 6 insertions(+)
diff --git a/configs/renesas_rzg2l_smarc_defconfig
b/configs/renesas_rzg2l_smarc_defconfig
index b1d970b6b7eb..6ec151218ebe 100644
--- a/configs/renesas_rzg2l_smarc_defconfig
reset is de-asserted after the module clock is enabled
but before any Ethernet register reads/writes take place.
Signed-off-by: Paul Barker
---
arch/arm/mach-renesas/Kconfig | 1 +
drivers/net/Kconfig | 2 +-
drivers/net/ravb.c| 57 +++
3 files
In order to add support for the Renesas RZ/G2L Ethernet IP in a
subsequent patch, we introduce optional de-assertion and re-assertion of
a reset signal in ravb_probe() and ravb_remove().
Signed-off-by: Paul Barker
---
drivers/net/ravb.c | 31 +--
1 file changed, 29
Enable support for USB 2.0, USB 1.1 and USB storage devices on the
Renesas RZ/G2L EVK.
Also enable the 'usb' command to support USB scanning and debugging.
Signed-off-by: Paul Barker
---
configs/renesas_rzg2l_smarc_defconfig | 8
1 file changed, 8 insertions(+)
diff --git
Extend the existing Renesas R-Car Gen3 USB 2.0 PHY driver to support the
RZ/G2L and related SoCs.
Also enable this driver by default for the RZ/G2L SoC family.
Reviewed-by: Marek Vasut
Signed-off-by: Paul Barker
---
drivers/phy/Kconfig | 4 +-
drivers/phy/phy-rcar-gen3.c | 79
Bind the USB VBUS regulator driver under the USB PHY reset driver for
the Renesas RZ/G2L and related SoCs. This additional bind is needed as
the corresponding device tree node does not contain a compatible string.
Reviewed-by: Marek Vasut
Signed-off-by: Paul Barker
---
drivers/reset/Kconfig
Add a new regulator driver to control the USB VBUS supply on the Renesas
RZ/G2L and related SoCs.
Reviewed-by: Marek Vasut
Signed-off-by: Paul Barker
---
drivers/power/regulator/Kconfig | 8
drivers/power/regulator/Makefile | 1 +
.../power/regulator/rzg2l
Add a new driver to control the USB 2.0 PHY reset controller on the
Renesas RZ/G2L and related SoCs.
Signed-off-by: Paul Barker
---
drivers/reset/Kconfig | 9 ++
drivers/reset/Makefile | 1 +
drivers/reset/reset-rzg2l-usbphy-ctrl.c | 113
e32() in rzg2l_usbphy_ctrl_deassert().
- Include return value of the failing function in dev_err() prints.
- Capitalise G in "R-Car Gen3".
- Added Marek's Reviewed-by tags.
Paul Barker (5):
reset: rzg2l-usbphy-ctrl: Add new driver
regulator: rzg2l-usbphy: Add new driver
reset: rzg2l-usbph
On 08/03/2025 14:54, Paul Barker wrote:
> On 05/03/2025 20:05, Marek Vasut wrote:
>> On 3/4/25 5:37 PM, Paul Barker wrote:
>>
>> [...]
>>
>>> +static int rzg2l_usbphy_ctrl_assert(struct reset_ctl *reset_ctl)
>>> +{
>>> + struct rzg2
On 05/03/2025 20:05, Marek Vasut wrote:
> On 3/4/25 5:37 PM, Paul Barker wrote:
>
> [...]
>
>> +static int rzg2l_usbphy_ctrl_assert(struct reset_ctl *reset_ctl)
>> +{
>> +struct rzg2l_usbphy_ctrl_priv *priv = dev_get_priv(reset_ctl->dev);
>> +u32 v
iiphy_bus_ops has
> +the following fields/callbacks (see miiphy.h for details):
Reviewed-by: Paul Barker
Thanks!
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
that the
definition of CMD_NET is followed immediately by an if/endif block that
contains all network command options. We can also remove nested checks
for CMD_NET or (NET || NET_LWIP).
Fixes: 98ad145db61a ("net: lwip: add DHCP support and dhcp commmand")
Signed-off-by: Paul
Hi Marek,
On 05/03/2025 19:53, Marek Vasut wrote:
> On 3/4/25 9:07 PM, Paul Barker wrote:
>> The value written to the RFLR register includes the length of the CRC
>> data at the end of each Ethernet frame. So we need to increase the value
>> written to this register to ensur
Hi Marek,
On 05/03/2025 19:55, Marek Vasut wrote:
> On 3/4/25 9:07 PM, Paul Barker wrote:
>> In ravb_probe(), we were missing a couple of things in the error
>> handling path:
>>
>>* We must unregister the MDIO bus before freeing the corresponding
>> str
On 04/03/2025 17:07, Biju Das wrote:
> Hi Paul,
>
>> -Original Message-
>> From: U-Boot On Behalf Of Paul Barker
>> Subject: [PATCH 1/5] reset: rzg2l-usbphy-ctrl: Add new driver
>> diff --git a/include/renesas/rzg2l-usbphy.h b/include/renesas/rzg2l-usb
ernel.
Fixes: 8ae51b6f324e ("net: ravb: Add Renesas Ethernet RAVB driver")
Signed-off-by: Paul Barker
---
drivers/net/ravb.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c
index 6129929568a3..6bd94cf6bb1b 100644
--
the
clocks have not yet been enabled.
Fixes: 8ae51b6f324e ("net: ravb: Add Renesas Ethernet RAVB driver")
Signed-off-by: Paul Barker
---
drivers/net/ravb.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ravb.c b/drivers/net/ra
These three minor fixes apply on top of the recent bitbangmii tidy up
patch series [1] from Marek.
[1]:
https://lore.kernel.org/all/20250302012752.393608-1-marek.vasut+rene...@mailbox.org/
Paul Barker (3):
net: ravb: Add dependency on CONFIG_BITBANGMII
net: ravb: Fix RX frame size limit
The Renesas RAVB driver always requires bitbang MDIO bus support.
Fixes: 8ae51b6f324e ("net: ravb: Add Renesas Ethernet RAVB driver")
Signed-off-by: Paul Barker
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kco
Following on from commit 9a699a0a0d62 ("clk: rzg2l: Ignore enable for
core clocks"), we also need to ignore attempts to disable core clocks to
avoid the need for conditionals around clk_disable_bulk() calls in
drivers which support both RZ/G2L and other Renesas SoCs.
Signed-off-by: P
Bind the USB VBUS regulator driver under the USB PHY reset driver for
the Renesas RZ/G2L and related SoCs. This additional bind is needed as
the corresponding device tree node does not contain a compatible string.
Signed-off-by: Paul Barker
---
drivers/reset/Kconfig | 1
Enable support for USB 2.0, USB 1.1 and USB storage devices on the
Renesas RZ/G2L EVK.
Also enable the 'usb' command to support USB scanning and debugging.
Signed-off-by: Paul Barker
---
configs/renesas_rzg2l_smarc_defconfig | 8
1 file changed, 8 insertions(+)
diff --git
Extend the existing Renesas R-Car gen3 USB 2.0 PHY driver to support the
RZ/G2L and related SoCs.
Also enable this driver by default for the RZ/G2L SoC family.
Signed-off-by: Paul Barker
---
drivers/phy/Kconfig | 4 +-
drivers/phy/phy-rcar-gen3.c | 79
Add a new regulator driver to control the USB VBUS supply on the Renesas
RZ/G2L and related SoCs.
Signed-off-by: Paul Barker
---
drivers/power/regulator/Kconfig | 8
drivers/power/regulator/Makefile | 1 +
.../power/regulator/rzg2l-usbphy-regulator.c | 42
Add a new driver to control the USB 2.0 PHY reset controller on the
Renesas RZ/G2L and related SoCs.
Signed-off-by: Paul Barker
---
drivers/reset/Kconfig | 9 ++
drivers/reset/Makefile | 1 +
drivers/reset/reset-rzg2l-usbphy-ctrl.c | 117
x27;t have any of them available to test to confirm this myself.
Paul Barker (5):
reset: rzg2l-usbphy-ctrl: Add new driver
regulator: rzg2l-usbphy: Add new driver
reset: rzg2l-usbphy-ctrl: Connect up vbus regulator
phy: rcar: Support RZ/G2L USB PHY
renesas_rzg2l_smarc_defconfig: Enabl
gned-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 02/03/2025 01:24, Marek Vasut wrote:
> Inline mdio_init() back into mdio_alloc(), separate
> access to mdio_init() is no longer necessary.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPG
On 02/03/2025 01:24, Marek Vasut wrote:
> These functions are no longer necessary, remove them.
> The struct bb_miiphy_bus is no longer necessary either,
> remove it as well.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.
On 02/03/2025 01:24, Marek Vasut wrote:
> Use mdio_alloc() again to allocate MDIO bus. This is possible
> because all the miiphybb parameters and ops passing is handled in
> at bb_miiphy_read()/bb_miiphy_write() level.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
move
> callback of this driver. which does not pose a problem anymore.
>
> Fixes: 08eefb5e792d ("net: sh_eth: Allocate bb_miiphy using bb_miiphy_alloc()
> and fill in callbacks")
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B345
move
> callback of this driver. which does not pose a problem anymore.
>
> Fixes: 079eaca6e7b4 ("net: ravb: Allocate bb_miiphy using bb_miiphy_alloc()
> and fill in callbacks")
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F00
move
> callback of this driver. which does not pose a problem anymore.
>
> Fixes: cbb69c2fafcc ("net: designware: Allocate bb_miiphy using
> bb_miiphy_alloc() and fill in callbacks")
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x2
On 02/03/2025 01:24, Marek Vasut wrote:
> Remove the priv member from struct bb_miiphy_bus and its assignment
> from drivers. This turns struct bb_miiphy_bus int struct mii_dev
> wrapper, to be cleaned up next.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
; dependency on struct bb_miiphy_bus from the miiphybb code,
> except for helper functions which will be removed later.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Desc
ers and what the miiphybb
> does expect and will soon expect. This is a preparatory patch, no
> functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Desc
shuffling in miiphybb.c
> cannot be easily avoided.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 03/03/2025 23:16, Marek Vasut wrote:
> On 3/3/25 8:29 PM, Paul Barker wrote:
>> On 02/03/2025 01:24, Marek Vasut wrote:
>>> Move miiphybb operations into separate struct bb_miiphy_bus_ops
>>> structure, add pointer to struct bb_miiphy_bus_ops into the base
>>
need to rebase my Ethernet patches again I have a
few bugfixes for R-Car & RZ/G2H, plus some refactoring and the addition
of support for RZ/G2L which all conflict with the churn in ravb.c.
Thanks,
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_sign
he bb_miiphy callbacks can
> reach these accessors by doing container_of() on struct mii_dev.
>
> Reviewed-by: Paul Barker
> Signed-off-by: Marek Vasut
> ---
> Cc: Christian Marangi
> Cc: Ilias Apalodimas
> Cc: Jerome Forissier
> Cc: Jim Liu
> Cc: Joe Hershberger
phy functions in U-Boot.
Reviewed-by: Marek Vasut
Signed-off-by: Paul Barker
---
Changes v2->v3:
- Documented devad parameter.
Changes v1->v2:
- Split out of series adding RZ/G2L Ethernet support [1]
- Added Marek's Reviewed-by tag
include/phy.h | 24 +
We can call phy_modify_mmd() instead of manually calling drv->readext()
and drv->writeext().
Reviewed-by: Marek Vasut
Signed-off-by: Paul Barker
---
Changes v2->v3:
- Added Marek's Reviewed-by tag.
Changes v1->v2:
- Split out of series adding RZ/G2L Ethernet support [1]
Various signal skew values may be set in the device tree for the ksz9131
Ethernet PHY. For example, the RZ/G2L board requires non-default values
for rxc-skew-psec & txc-skew-psec.
This is based on the ksz9131 phy driver in Linux v6.11.
Reviewed-by: Marek Vasut
Signed-off-by: Paul Barker
--
: Quentin Schulz # RK3588 Tiger
Signed-off-by: Paul Barker
---
Changes v2->v3:
- Changed LED mode symbol name to
KSZ9131RN_COMMON_CTRL_INDIVIDUAL_LED_MODE.
- Changed errata bit symbol name to KSZ9131RN_LED_ERRATA_BIT.
- Added Quentin's Tested-by tag.
Changes v1->v2:
- Split ou
.
>
> Fixes: e4aea57fa773 ("pinctrl: renesas: add R906G032 driver")
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
Thanks Marek!
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 27/02/2025 23:43, Marek Vasut wrote:
> The RZN1 symbol name is CONFIG_RZN1, there is no CONFIG_ARCH_RZN1.
> Fix the symbol name so the pinctrl driver for RZN1 gets build.
>
> Fixes: e4aea57fa773 ("pinctrl: renesas: add R906G032 driver")
> Signed-off-by: Marek Vasut
le '-Werror' by
default for all kernel builds"). The modification of KBUILD_CFLAGS is
done in Makefile.extrawarn, matching where it was moved in the kernel by
Linux commit e88ca24319e4 ("kbuild: consolidate warning flags in
scripts/Makefile.extrawarn").
Signed-off-by: Paul Barker
On 27/02/2025 22:00, Paul Barker wrote:
> Add a new config option under "General setup" to enable the -Werror flag
> when building U-Boot. This is useful during development to help catch
> mistakes.
>
> This is based on a similar config option added to the Linux kernel
le '-Werror' by
default for all kernel builds"). The modification of KBUILD_CFLAGS is
done in Makefile.extrawarn, matching where it was moved in the kernel by
Linux commit e88ca24319e4 ("kbuild: consolidate warning flags in
scripts/Makefile.extrawarn").
Signed-off-by: Paul Bark
on allocation of MDIO bus
> by the other two MDIO bus options and then rewrote the newly allocated
> MDIO bus callbacks, which is wrong, instead allocate proper MDIO bus with
> the correct callbacks outright.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barke
On 22/02/2025 20:33, Marek Vasut wrote:
> Instead of doing another lookup, trivially access the struct mii_dev
> embedded in struct bb_miiphy_bus . No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
On 22/02/2025 20:33, Marek Vasut wrote:
> Instead of doing another lookup, trivially access the struct mii_dev
> embedded in struct bb_miiphy_bus . No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
he bb_miiphy callbacks can
> reach these accessors by doing container_of() on struct mii_dev.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
he bb_miiphy callbacks can
> reach these accessors by doing container_of() on struct mii_dev.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
he bb_miiphy callbacks can
> reach these accessors by doing container_of() on struct mii_dev.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 22/02/2025 20:33, Marek Vasut wrote:
> There is literally one single bbmiiphy bus in this driver,
> remove the bus index handling.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_s
rdware, but would
> be nice if someone could double-check and test that.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 22/02/2025 20:33, Marek Vasut wrote:
> Move the bb_miiphy functions before MDIO registration. This is a
> preparatory patch, the functions will be referenced around the MDIO
> registration in the follow up patches. No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-
On 22/02/2025 20:33, Marek Vasut wrote:
> Move the bb_miiphy functions before MDIO registration. This is a
> preparatory patch, the functions will be referenced around the MDIO
> registration in the follow up patches. No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-
On 22/02/2025 20:33, Marek Vasut wrote:
> Move the bb_miiphy functions before MDIO registration. This is a
> preparatory patch, the functions will be referenced around the MDIO
> registration in the follow up patches. No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-
ct bb_miiphy_bus
> using plain container_of() .
>
> Clean up the drivers and update them to match.
I think this series looks ready to merge so I'll start rebasing my
RZ/G2L Ethernet patches on it.
Thanks Marek!
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: Open
On 09/02/2025 12:01, Marek Vasut wrote:
> Move the bb_miiphy functions before MDIO registration. This is a
> preparatory patch, the functions will be referenced around the MDIO
> registration in the follow up patches. No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-
On 09/02/2025 12:01, Marek Vasut wrote:
> Neither bb_miiphy_buses nor bb_miiphy_buses_num are used anymore.
> Drop both of them.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_s
On 17/02/2025 11:06, Paul Barker wrote:
> On 09/02/2025 12:01, Marek Vasut wrote:
>> Introduce mdio_init() split off from mdio_alloc(), which is used
>> to initialize already allocated struct mii_dev.
>>
>> Signed-off-by: Marek Vasut
>
> Reviewed-by: Paul Barker
On 09/02/2025 12:01, Marek Vasut wrote:
> Instead of doing another lookup, trivially access the struct mii_dev
> embedded in struct bb_miiphy_bus . No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
o fill in matching name in probe to avoid any
> breakage.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 09/02/2025 12:01, Marek Vasut wrote:
> There are no more users of the init callback, drop the entire mechanism.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
De
;
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
miiphy_bus {
const struct bb_miiphy_ops *ops;
struct mii_dev mii;
void *priv;
};
We can make this change as a follow-up though as this patch series
otherwise looks good.
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: Ope
ccess struct bb_miiphy_bus using container_of, even if the PHY stack
> only passes in the inner struct mii_dev .
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 09/02/2025 12:01, Marek Vasut wrote:
> Introduce mdio_init() split off from mdio_alloc(), which is used
> to initialize already allocated struct mii_dev.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPG
On 09/02/2025 12:01, Marek Vasut wrote:
> The .init callback is not called by any function, drop it.
>
> Signed-off-by: Marek Vasut
This could be squashed into the previous patch if you like.
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description
On 09/02/2025 12:01, Marek Vasut wrote:
> This is unnecessary, the unset structure member is initialized to
> NULL by default, drop the assignment.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPG
;
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
;
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 25/01/2025 12:28, Marek Vasut wrote:
> Update the debug() print, use __func__ to always print matching
> function name, and also print bus name in case there are multiple
> busses.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B
On 25/01/2025 12:30, Marek Vasut wrote:
> On 1/21/25 1:03 PM, Paul Barker wrote:
>> On 18/01/2025 06:16, Marek Vasut wrote:
>>> Replace ifdeffery with plain debug() function call. No functional change.
>>>
>>> Signed-off-by: Marek Vasut
>>> ---
>&
On 25/01/2025 12:34, Marek Vasut wrote:
> On 1/21/25 1:15 PM, Marek Vasut wrote:
>> On 1/21/25 1:07 PM, Paul Barker wrote:
>>> On 18/01/2025 06:34, Marek Vasut wrote:
>>>> The init function does nothing, the bb_miiphy_init() already checks
>>>> whether
On 27/01/2025 13:28, Paul Barker wrote:
> On 27/01/2025 11:30, Marek Vasut wrote:
>> On 1/27/25 11:32 AM, Paul Barker wrote:
>>> Hi Marek,
>>>
>>> On 25/01/2025 12:56, Marek Vasut wrote:
>>>> On 1/21/25 3:38 PM, Paul Barker wrote:
>>>&g
On 27/01/2025 11:30, Marek Vasut wrote:
> On 1/27/25 11:32 AM, Paul Barker wrote:
>> Hi Marek,
>>
>> On 25/01/2025 12:56, Marek Vasut wrote:
>>> On 1/21/25 3:38 PM, Paul Barker wrote:
>>>> On 18/01/2025 06:53, Marek Vasut wrote:
>>>>> In
Hi Marek,
On 25/01/2025 12:56, Marek Vasut wrote:
> On 1/21/25 3:38 PM, Paul Barker wrote:
>> On 18/01/2025 06:53, Marek Vasut wrote:
>>> Introduce mdio_init() split off from mdio_alloc(), which is used
>>> to initialize already allocated struct mii_dev.
>>
On 18/01/2025 06:53, Marek Vasut wrote:
> Introduce bb_miiphy_free()/bb_miiphy_free() wrappers to allocate and free
This should be bb_miiphy_alloc()/bb_miiphy_free().
Same for the commit title.
Thanks,
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public
e commit that dynamic allocation
is added.
Thanks,
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
;
> Signed-off-by: Marek Vasut
> ---
> Cc: Christian Marangi
> Cc: Evgeny Bachinin
> Cc: Ilias Apalodimas
> Cc: Jerome Forissier
> Cc: Joe Hershberger
> Cc: Mario Six
> Cc: Michal Simek
> Cc: Nobuhiro Iwamatsu
> Cc: Paul Barker
> Cc: Ramon Fried
> Cc:
Cc: Mario Six
> Cc: Nobuhiro Iwamatsu
> Cc: Paul Barker
> Cc: Peter Robinson
> Cc: Ramon Fried
> Cc: Sumit Garg
> Cc: Tom Rini
> Cc: u-boot@lists.denx.de
> ---
> drivers/net/phy/miiphybb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git
ld in these two structs have
different lengths...
With that changed,
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 18/01/2025 06:12, Marek Vasut wrote:
> These functions can be static as they are referenced only in this file.
> Make them static. No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPG
>
> Signed-off-by: Marek Vasut
Thanks for tidying this up!
Reviewed-by: Paul Barker
--
Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
On 14/12/2024 22:42, Marek Vasut wrote:
> Use generic is_cortex_a() functions instead of open-coded midr_el1 read.
> No functional change.
>
> Signed-off-by: Marek Vasut
> ---
> Cc: Biju Das
> Cc: Chris Paterson
> Cc: Lad Prabhakar
> Cc: Nobuhiro Iwamatsu
> C
1 - 100 of 442 matches
Mail list logo
