On 06/03/2025 22:12, Marek Vasut wrote: > Update the miiphybb documentation to match current implementation. > The static struct bb_miiphy_bus bb_miiphy_buses[] array is removed. > The example is updated to match current Renesas RAVB driver, which > is one of the miiphybb users. > > Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org>
I have a couple of minor improvements to the sentences below, you can fix these up while applying. > -The board code needs to fill the bb_miiphy_buses[] array with a record for > -each required bus and declare the bb_miiphy_buses_num variable with the > -number of mii buses. The record (struct bb_miiphy_bus) has the following > -fields/callbacks (see miiphy.h for details): > +The driver code needs to allocate regular MDIO device using mdio_alloc() "... allocate a regular MDIO device ..." > +and assign .read and .write accessors which wrap bb_miiphy_read() and > +bb_miiphy_write() functions respectively. The bb_miiphy_read() and > +bb_miiphy_write() functions have to be passed a point to a callback "... functions take a pointer to a callback ..." > +structure, struct bb_miiphy_bus_ops. The struct bb_miiphy_bus_ops has > +the following fields/callbacks (see miiphy.h for details): Reviewed-by: Paul Barker <paul.barker...@bp.renesas.com> Thanks! -- Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
