On 25/01/2025 12:30, Marek Vasut wrote:
> On 1/21/25 1:03 PM, Paul Barker wrote:
>> On 18/01/2025 06:16, Marek Vasut wrote:
>>> Replace ifdeffery with plain debug() function call. No functional change.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org>
>>> ---
>>> Cc: Adam Ford <aford...@gmail.com>
>>> Cc: Hai Pham <hai.pham...@renesas.com>
>>> Cc: Ilias Apalodimas <ilias.apalodi...@linaro.org>
>>> Cc: Jerome Forissier <jerome.foriss...@linaro.org>
>>> Cc: Joe Hershberger <joe.hershber...@ni.com>
>>> Cc: Mario Six <mario....@gdsys.cc>
>>> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu...@renesas.com>
>>> Cc: Paul Barker <paul.barker...@bp.renesas.com>
>>> Cc: Peter Robinson <pbrobin...@gmail.com>
>>> Cc: Ramon Fried <rfried....@gmail.com>
>>> Cc: Sumit Garg <sumit.g...@linaro.org>
>>> Cc: Tom Rini <tr...@konsulko.com>
>>> Cc: u-boot@lists.denx.de
>>> ---
>>> drivers/net/phy/miiphybb.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/net/phy/miiphybb.c b/drivers/net/phy/miiphybb.c
>>> index 171c1719b5b..5497b838225 100644
>>> --- a/drivers/net/phy/miiphybb.c
>>> +++ b/drivers/net/phy/miiphybb.c
>>> @@ -183,9 +183,7 @@ int bb_miiphy_read(struct mii_dev *miidev, int addr,
>>> int devad, int reg)
>>> bus->set_mdc(bus, 1);
>>> bus->delay(bus);
>>>
>>> -#ifdef DEBUG
>>> - printf("miiphy_read(0x%x) @ 0x%x = 0x%04x\n", reg, addr, rdreg);
>>> -#endif
>>> + debug("miiphy_read(0x%x) @ 0x%x = 0x%04x\n", reg, addr, rdreg);
>>>
>>> return rdreg;
>>> }
>>
>> While we're here, can we include the bus name in the output to avoid
>> confusion when we have multiple buses? Maybe something like:
>>
>> debug("miiphy_read(0x%x) @ %s:0x%x = 0x%04x\n", reg, bus->name, addr,
>> rdreg);
> No, not in this patch, but please test:
>
> [PATCH] net: miiphybb: Update debug() print
>
> Is it OK with you if I pick this patch for upcoming release ?Yes please. Reviewed-by: Paul Barker <paul.barker...@bp.renesas.com> -- Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
