On 22/02/2025 20:33, Marek Vasut wrote:
> Pull the bbmiiphy initialization code from designware_eth_probe() into
> dedicated function, dw_bb_mdio_init(), just like all the other MDIO
> initialization functions.
> 
> Keep check for "snps,bitbang-mii" in the designware_eth_probe(), so the
> driver can initialize this MDIO only in case the property is present,
> and initialize regular DW MDIO in case it is not present.
> 
> The dw_bb_mdio_init() allocates its own MDIO instance, because thus far
> code gated behind "snps,bitbang-mii" did depend on allocation of MDIO bus
> by the other two MDIO bus options and then rewrote the newly allocated
> MDIO bus callbacks, which is wrong, instead allocate proper MDIO bus with
> the correct callbacks outright.
> 
> Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org>

Reviewed-by: Paul Barker <paul.barker...@bp.renesas.com>

-- 
Paul Barker

Attachment: OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to