On Thursday 08 August 2013 13:23:42 Thomas Lübking wrote:
> On Donnerstag, 8. August 2013 11:24:35 CEST, Kevin Krammer
wrote:
> > I think what Thomas was suggesting was to make the action
> > objects directly accessible instead of making Qt traverse
> > the QObject tree to find them.
>
> Exactly.
On Thursday 08 August 2013 09:49:37 Pali Rohár wrote:
> > +void AkonadiAddressbook::openContactWindow(const QString
> > &email, const QString &displayName) +{
> > +// TODO
> > +#if 0
> >
> >
> >
> > is this short-term todo or long term todo? (in latter case the
> > feature should not be announ
On Wednesday, 7 August 2013 07:46:01 CEST, Pali Rohár wrote:
TrojitaPlugin is Kontact plugin and it is not loaded when running
standalone Trojita version.
Problem with empty application name in kwallet widget is only
with standalone version. When Trojita is loaded into Kontact,
kwallet widget
On Friday, 9 August 2013 16:22:48 CEST, Thomas Lübking wrote:
Finally and ultimately and why I tend to call "this some sort of abuse":
I've seen such too often (not talking about trojita here, but in general)
[snipped code example with forwarding because of the need to add arguments
to that fu
On Freitag, 9. August 2013 10:18:02 CEST, Jan Kundrát wrote:
Qt5's QTimer contains a special case for QTimer::singleShot(0)
(I suspect a lot of stuff would break if it was removed).
s/a/the/ - and yes, probably removing the special case wasn't a good idea.
I'd like to improve my Qt-fu, so I'm
On Thursday, 8 August 2013 19:32:13 CEST, Thomas Lübking wrote:
If you want to "skip the event loop" you should ask to "skip
the event loop" and not hope "QTimer will skip the event loop"
Notice that aside the pointless QTimer dependency, the default
timer in Qt5 will be the coarse one, ie. if Q
On Donnerstag, 8. August 2013 19:57:56 CEST, Pali Rohár wrote:
Reason why I used QTimer::singleShot was that it is offent used in
trojita code. Just run wc -l:
Yes, it's a very popular abuse, doesn't change it's an abuse.
(Though FWWI: The coarse timer operates on 5% base, since 5% of 0 is 0
On Thursday 08 August 2013 19:32:13 Thomas Lübking wrote:
> On Donnerstag, 8. August 2013 15:52:56 CEST, Pali Rohár wrote:
> > For emails with lot of recipients this could lead to
> > application crash... For each email address trojita is
> > starting job.
>
> You mean for OOM due to job overhead?
On Donnerstag, 8. August 2013 15:52:56 CEST, Pali Rohár wrote:
For emails with lot of recipients this could lead to application
crash... For each email address trojita is starting job.
You mean for OOM due to job overhead?
You could still keep up to 32 jobs in parallel or so.
(Everytime one re
On Monday 29 July 2013 19:35:22 Thomas Lübking wrote:
> +
> +AddressbookJob *job = m_completionRequests.take(toEdit);
> +
> +if (job) {
> +disconnect(job, 0, 0, 0);
> +job->stop();
> +job->deleteLater();
> +}
>
> The completion race (you type faster than the bac
On Donnerstag, 8. August 2013 11:24:35 CEST, Kevin Krammer wrote:
I think what Thomas was suggesting was to make the action objects directly
accessible instead of making Qt traverse the QObject tree to find them.
Exactly.
Whether unilateral changes in the XML menu file breaks things doesn't mat
On Thursday, 2013-08-08, Jan Kundrát wrote:
> On Thursday, 8 August 2013 10:44:44 CEST, Pali Rohár wrote:
> > In XML file are defined menubars and toolbars with all K/QActions.
> > It matching objectName(). In your cpp code you need to push all
> > KActions objects to some list (KActionCollection).
On Thursday, 8 August 2013 10:44:44 CEST, Pali Rohár wrote:
In XML file are defined menubars and toolbars with all K/QActions.
It matching objectName(). In your cpp code you need to push all
KActions objects to some list (KActionCollection).
My Kontact plugin will got pointers to QAction objec
On Thursday 08 August 2013 10:26:49 Jan Kundrát wrote:
> On Thursday, 8 August 2013 10:15:53 CEST, Pali Rohár wrote:
> > KMail is written as KDE KPart application.
>
> I know nothing about KParts, so let me rephrase my suggestion
> -- if there's something in KMail which is setting up the
> menus e
On Thursday, 8 August 2013 10:15:53 CEST, Pali Rohár wrote:
KMail is written as KDE KPart application.
I know nothing about KParts, so let me rephrase my suggestion -- if there's
something in KMail which is setting up the menus etc. *and* if this is
applicable to Trojita, I'd suggest to go th
On Thursday 08 August 2013 10:10:54 Jan Kundrát wrote:
> On Thursday, 8 August 2013 09:49:37 CEST, Pali Rohár wrote:
> > KDE XML menu file contains above object names. So if
> > somebody change them, it will break Kontact plugin (Kontact
> > will not show any Trojita menus/buttons). So here can be
On Thursday, 8 August 2013 09:49:37 CEST, Pali Rohár wrote:
KDE XML menu file contains above object names. So if somebody
change them, it will break Kontact plugin (Kontact will not show
any Trojita menus/buttons). So here can be good test if trojita
code will still OK.
What other think? Use
On Thursday, 2013-08-08, Pali Rohár wrote:
> On Thursday 08 August 2013 09:38:16 Kevin Krammer wrote:
> > On Thursday, 2013-08-08, Pali Rohár wrote:
> > > KResourceAddressbook sounds good. Current name is
> > > "KDE Addressbook (traditional)". Do you want to change it?
> >
> > I would use "Legacy
On Thursday 08 August 2013 09:38:16 Kevin Krammer wrote:
> On Thursday, 2013-08-08, Pali Rohár wrote:
> > On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote:
> > > On Tuesday, 2013-07-30, Thomas Lübking wrote:
> > > > @Kevin
> > > > How are chances about having query restrictions in
> > > > akona
On Tuesday 30 July 2013 22:58:42 Thomas Lübking wrote:
> Set #2 of comments:
>
> +QAction *actionComposeMail = m_window->findChild *>(QLatin1String("action_compose_mail")); +QAction
> *actionComposeDraft = m_window->findChild *>(QLatin1String("action_compose_draft")); ...
> +QAction *a
On Thursday, 2013-08-08, Pali Rohár wrote:
> On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote:
> > On Tuesday, 2013-07-30, Thomas Lübking wrote:
> > > +const KABC::Addressee::List &list = job->contacts();
> > > Since KABC is claimed deprecated, is there no replacement
> > > API?
> >
> > K
On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote:
> On Tuesday, 2013-07-30, Thomas Lübking wrote:
> > +void AkonadiAddressbookCompletionJob::result()
> > +{
> > +NameEmailList completion;
> > +
> > +const KABC::Addressee::List &list = job->contacts();
> > Since KABC is claimed deprecate
On Wednesday 31 July 2013 00:01:29 Thomas Lübking wrote:
> On Dienstag, 30. Juli 2013 23:23:13 CEST, Kevin Krammer wrote:
> >> +void KDEAddressbookProcess::slotApplicationLoaded()
> >> this is superfluous, you can bind the finished signal to
> >
> > Might even connect the signal to deleteLater dir
On Wednesday 31 July 2013 21:02:24 Thomas Lübking wrote:
> +KWalletPassword::KWalletPassword(QObject *parent) :
> PasswordInterface(parent) +{
> +/*
> + NOTE: This is only way how to set application name to
> KWallet widget.
>
> Just to be sure:
> +TrojitaPlugin::TrojitaPlugin(KontactInte
On Montag, 5. August 2013 17:09:58 CEST, Jan Kundrát wrote:
You're right that a defensive design would enforce this via
asserts and mention this in the docs. Patches for both are
welcome.
=P
+enum Type {
+Request,
+Store,
+Delete
+};
enums are extendable (th
On Tuesday, 30 July 2013 22:58:42 CEST, Thomas Lübking wrote:
What if there're successive sendMail calls before the password turned in?
The MSA classes are designed to only support a single submission during
their lifetime, so this is not a problem.
You're right that a defensive design would
On Tuesday, 30 July 2013 23:23:13 CEST, Kevin Krammer wrote:
Hmm. I guess the class could indeed be called KABCAddressbook or
KResourceAddressbook. But since those are framework names the user
visible
string should probably be something like "Legacy KDE Addressbook".
Agreed.
Cheers,
Jan
--
And the rest:
+void KWalletManager::open()
+{
+if (m_isOpening)
+return;
+if (m_wallet && m_wallet->isOpen()) {
+QTimer::singleShot(0, this, SLOT(walletOpened()));
*cough* - and why does the call need to be deferred anyway?
+void KWalletManager::walletOpened(bool opened)
On Dienstag, 30. Juli 2013 23:23:13 CEST, Kevin Krammer wrote:
+void KDEAddressbookProcess::slotApplicationLoaded()
this is superfluous, you can bind the finished signal to
Might even connect the signal to deleteLater directly?
That's what i meant - it's rarely required to write a slot to del
On Tuesday, 2013-07-30, Thomas Lübking wrote:
> +void AkonadiAddressbookCompletionJob::result()
> +{
> +NameEmailList completion;
> +
> +const KABC::Addressee::List &list = job->contacts();
> Since KABC is claimed deprecated, is there no replacement API?
KABC is a module dealing with cont
Set #2 of comments:
+QAction *actionComposeMail = m_window->findChild(QLatin1String("action_compose_mail"));
+QAction *actionComposeDraft = m_window->findChild(QLatin1String("action_compose_draft"));
...
+QAction *actionReplyPrivate = m_window->findChild(QLatin1String("action_reply_pr
On Montag, 29. Juli 2013 11:01:44 CEST, Jan Kundrát wrote:
On Wednesday, 24 July 2013 11:08:09 CEST, Pali Rohár wrote:
I rebased pali-gsoc-merge branch again with squashed fixes. It
contains replaced QEventLoop code, fixed hardcoded libraries in
CMakeLists.txt for building KDE plugins and other
On Wednesday, 24 July 2013 11:08:09 CEST, Pali Rohár wrote:
I rebased pali-gsoc-merge branch again with squashed fixes. It
contains replaced QEventLoop code, fixed hardcoded libraries in
CMakeLists.txt for building KDE plugins and other small fixes.
Hi Pali, I'm now back after my summer break.
Hello,
I rebased pali-gsoc-merge branch again with squashed fixes. It
contains replaced QEventLoop code, fixed hardcoded libraries in
CMakeLists.txt for building KDE plugins and other small fixes.
For compiling plugins I choosed option 1. (static link Common
library to each plugin). For more i
On Mittwoch, 10. Juli 2013 21:41:30 CEST, Pali Rohár wrote:
I played a lot with minimal size and on my machine there are no
scrollbars. But now I think that minimal size depends on used qt
theme and so we cannot predicate correct minmal size.
So is there any way to tell general settings tab w
On Wednesday 10 July 2013 20:59:21 Caspar Schutijser wrote:
> On Wednesday, July 10, 2013 1:16:39 PM CEST, Pali Rohár wrote:
> > I fixed this problem. Also that one which caused that tests
> > was not possible to compile. Patches pushed to my same git
> > branch.
>
> Thanks :)
>
>
> I read throu
On Wednesday 10 July 2013 21:35:09 Caspar Schutijser wrote:
> Hi Pali,
>
> One other thing, related to the GUI: the minimumSize of the
> added QComboBoxes in the settings dialog cause a horizontal
> scrollbar to appear in the settings dialog, at least on my
> computer. How about lowering the width
Hi Pali,
One other thing, related to the GUI: the minimumSize of the added
QComboBoxes in the settings dialog cause a horizontal scrollbar to
appear in the settings dialog, at least on my computer. How about
lowering the width of the minimumSize for a bit?
While we are at it, since the addition
On Wednesday, July 10, 2013 1:16:39 PM CEST, Pali Rohár wrote:
I fixed this problem. Also that one which caused that tests was
not possible to compile. Patches pushed to my same git branch.
Thanks :)
I read through the diff (that is, everything that has changed between
your version and the "m
On Monday 08 July 2013 22:04:33 Caspar Schutijser wrote:
> Hi Pali,
>
> On Monday, July 8, 2013 6:10:36 PM CEST, Pali Rohár wrote:
> > today I cleaned my git tree and created new (rebased) branch
> > which is ready for comments and then for merging to master.
>
> One piece of feedback for now.
>
Hi Pali,
On Monday, July 8, 2013 6:10:36 PM CEST, Pali Rohár wrote:
today I cleaned my git tree and created new (rebased) branch
which is ready for comments and then for merging to master.
One piece of feedback for now.
If I do this:
1) Go to Settings.
2) Select "None - Disable passwords" at
41 matches
Mail list logo
