On Thursday 08 August 2013 09:38:16 Kevin Krammer wrote: > On Thursday, 2013-08-08, Pali Rohár wrote: > > On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote: > > > On Tuesday, 2013-07-30, Thomas Lübking wrote: > > > > @Kevin > > > > How are chances about having query restrictions in > > > > akonadi (esp. return amount, there's little sense for > > > > any completer to show more than a dozen entries after > > > > you typed "ke" what might match some hundreds) > > > > > > ContactSearchJob::setLimit() should do the trick I guess. > > > > I already using setLimit, but this is not enough for > > trojita. Because trojita using list of email addresses and > > one contact can have more email addresses. And if I > > understand correctly setLimit will limit number of > > contacts. > > True, but it should still help, no? >
Yes, it can help, but it is not sufficient, only necessary. > > > > +class KDEAddressbook : public AddressbookInterface > > > > As mentioned before i guess this should always be > > > > KABCAddressbook instead to avoid the implication KABC > > > > would be the promoted KDE default. Kevin? > > > > > > Hmm. I guess the class could indeed be called > > > KABCAddressbook or KResourceAddressbook. But since those > > > are framework names the user visible string should > > > probably be something like "Legacy KDE Addressbook". > > > > KResourceAddressbook sounds good. Current name is > > "KDE Addressbook (traditional)". Do you want to change it? > > I would use "Legacy" instead of "Traditional". In KDE we made > the mistake of using "Traditional" when referrrng to the > KResource based data access and it really confuses users. > I had a discussion with our translators and they agree that > "legacy" is still the best option (difficult to translate but > still the best English word for the desired meaning). > > Which reminds me I should probably change our description > files at some point > > :) > > Cheers, > Kevin Ok, I will change it to legacy then. -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.