On Thursday, 2013-08-08, Pali Rohár wrote: > On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote: > > On Tuesday, 2013-07-30, Thomas Lübking wrote:
> > > + const KABC::Addressee::List &list = job->contacts(); > > > Since KABC is claimed deprecated, is there no replacement > > > API? > > > > KABC is a module dealing with contact data. The classes for > > holding/parsing/formatting data are still fine. > > The things that got depreated are the data access classes > > (extremely limited, awkward to use for asychronous backends, > > etc). > > KABC::Addressbook is deprecated. But KABC::Addressee not. Right? Yes, that is correct. Only the parts of KABC API have been deprecated that were related to the KResource system, i.e. data access and I/O. Data classes such as Addressee, Address, PhoneNumber, etc. are still in use and part of the official contact data API. > > > @Kevin > > > How are chances about having query restrictions in akonadi > > > (esp. return amount, there's little sense for any completer > > > to show more than a dozen entries after you typed "ke" what > > > might match some hundreds) > > > > ContactSearchJob::setLimit() should do the trick I guess. > > I already using setLimit, but this is not enough for trojita. > Because trojita using list of email addresses and one contact can > have more email addresses. And if I understand correctly setLimit > will limit number of contacts. True, but it should still help, no? > > > +class KDEAddressbook : public AddressbookInterface > > > As mentioned before i guess this should always be > > > KABCAddressbook instead to avoid the implication KABC would > > > be the promoted KDE default. Kevin? > > > > Hmm. I guess the class could indeed be called KABCAddressbook > > or KResourceAddressbook. But since those are framework names > > the user visible string should probably be something like > > "Legacy KDE Addressbook". > > KResourceAddressbook sounds good. Current name is > "KDE Addressbook (traditional)". Do you want to change it? I would use "Legacy" instead of "Traditional". In KDE we made the mistake of using "Traditional" when referrrng to the KResource based data access and it really confuses users. I had a discussion with our translators and they agree that "legacy" is still the best option (difficult to translate but still the best English word for the desired meaning). Which reminds me I should probably change our description files at some point :) Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring
signature.asc
Description: This is a digitally signed message part.
