On Tuesday, 30 July 2013 22:58:42 CEST, Thomas Lübking wrote:
What if there're successive sendMail calls before the password turned in?
The MSA classes are designed to only support a single submission during
their lifetime, so this is not a problem.
You're right that a defensive design would enforce this via asserts and
mention this in the docs. Patches for both are welcome.
+ enum Type {
+ Request,
+ Store,
+ Delete
+ };
enums are extendable (though i'm absolutely not sure about
compilers here, we'd have to research this)
-> you could likely move this into PasswordJob, have a barrier enum Type
{
Request = 0,
Store,
Delete,
UserType = 256
};
and in doubt enum Type {
Foo = UserType + 1,
};
in some inheriting class
I don't follow here -- do we expect to have something inherit from this
class?
I agree with the rest of the comments (in all three mails). Thanks for the
review!
Cheers,
Jan
--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
