Re: [trojita] Patch seemingly submitted to Arch Linux builds by upstream breaks icons

2021-08-05 Thread Thomas Lübking
Am Thu, Aug 05, 2021 at 01:09:14PM +0200 schrieb Oskar Roesler: I now built trojita-0.7-4 instead of 0.7.-5 and icons works again. I had to make git reset HEAD~2 bc of some Arch internal commit. These are the problematic patches: trojita-highdpi.patch::"https://invent.kde.org/pim/troji

Re: [trojita] No bold for text/plain mail (monospace font) in message viewer

2021-02-16 Thread Thomas Lübking
Am Tue, Feb 16, 2021 at 05:10:47PM +0100 schrieb Oskar Roesler: Am Dienstag, 16. Februar 2021 17:03:36 CET schrieb Erik Quaeghebeur: Hack has a bold variant. Checked for that with test message containing *bold*, /italic/, _underline_. Bold doesn't work for me on this Laptop configured with KD

Re: [trojita] No bold for text/plain mail (monospace font) in message viewer

2021-02-16 Thread Thomas Lübking
Am Fri, Feb 12, 2021 at 01:54:45PM +0100 schrieb Erik Quaeghebeur: On a new computer, I have the problem that Trojitá does not display monospace text bold. Such text is used for text with stars around in text/plain parts in the message viewer. On my old computer, bold is shown. Bold is also sho

Re: [trojita] Interface language option?

2017-11-01 Thread Thomas Lübking
On Wed, Nov 01, 2017 at 10:22:24PM +0200, Γιώργος Κωστόπουλος wrote: Hi! :-) Any option to change the interface language -> English? I can't find any related setting and changing the KDE language -> English, doesn't affect Trojita. Tried LANG=en_US.UTF-8 trojita ?

Re: [trojita] Automatic PGP Decryption

2017-04-24 Thread Thomas Lübking
On Mon, Apr 24, 2017 at 01:28:38PM +0200, Jan Kundrát wrote: I'm quite aware of the reasoning behind that approach Out of curiosity: what is the *reasoning* to skip mime headers and rely on mailbody parsing heuristics? Got a link? Yes: "legacy crap", "outlook produces such mails and is the st

Re: [trojita] Link URL in status bar

2017-04-20 Thread Thomas Lübking
PS: I was wrong about the 5.4 branch requirement in the last message - it's actually because of the QTimer::singleShot to a functor which was not available before 5.4. So you'd just have to unwind that and remove the branch (right now, showing a tooltip is not even attempted for you - regardless

Re: [trojita] Link URL in status bar

2017-04-20 Thread Thomas Lübking
On Thu, Apr 20, 2017 at 04:58:18PM +0100, Andy Bennett wrote: Does it need to use a timer at all? Is it acceptable for the tooltip to stay there until the cursor is moved away from the link? The timer is required to delay *showing* the tooltip (so webview doesn't immediately hide it again), so

Re: [trojita] Compile Trojitá on Windows

2016-08-04 Thread Thomas Lübking
On Thu, Aug 04, 2016 at 05:57:36PM +0800, lizong...@neiwang.cn wrote: VS 2010 ... CMake Error at CMakeLists.txt:46 (message): Your compiler doesn't support C++11's alignof You need MSVC 2015 or compile using clang/gcc instead of MSVC Older MSVC versions severely lack C++11 support (and in cas

Re: [trojita] profile does not persist after WM session restart

2016-03-09 Thread Thomas Lübking
On Wed, Mar 09, 2016 at 11:38:51PM +0100, Erik Quaeghebeur wrote: > I use different Trojita instances with different profiles set (-p > ) to access different accounts. When restarting my window > management session, e.g., after a shutdown, the profile information is not > preserved, so that multipl

[trojita] Re: best complier for trojita

2016-02-18 Thread Thomas Lübking
Taking this back to the mailing list (thus keeping most of your mail), please ensure to CC it on reply. (@Jan, __alignof isn't the same as __alignof__ and doesn't work on abstract classes) On Donnerstag, 18. Februar 2016 14:52:18 CEST, иван нецкин wrote: i have to admit i'm a junior programme

[trojita] Re: best complier for trojita

2016-02-16 Thread Thomas Lübking
On Dienstag, 16. Februar 2016 16:12:12 CEST, Jan Kundrát wrote: On Tuesday, 16 February 2016 14:45:22 CET, иван нецкин wrote: Hi, could you please tell me your compiler.While building your project i got lots of error, thanks in advance! You need a compiler which supports C++11. GCC 4.8+ and Cl

[trojita] Re: Could not parse IMAP ENVELOPE

2016-01-25 Thread Thomas Lübking
On Montag, 25. Januar 2016 12:36:07 CEST, Jan Kundrát wrote: On Monday, 25 January 2016 04:47:41 CET, SagaXu wrote: * 1 FETCH (UID 1325373061 INTERNALDATE "22-Dec-2015 15:57:52 +0800" ENVELOPE ("22-Dec-2015 15:57:50 +0800" "=?UTF-8?B?UmU6IFFBIENsYXJpZmljYXRpb25z?=" (("=?UTF-8?B?U2FnYVh1?=" NIL

Re: [trojita] Deprecating the Qt4 version and the RHEL6, Ubuntu 12.04, Debian 7 and Harmattan builds

2016-01-18 Thread Thomas Lübking
This mostly concerns Pali, but here's my 2¢ If the KABC plugin hasn't been in any release, i'd depend the strategy on desire and schedule to "port" it to Qt5 If there's no prospection for support in Qt5, i'd recommend to 1. drop it 2. make a final Qt4 supporting release 3. deprecate Qt4 The r

Re: [trojita] The personal notes in the addressbook are not saved

2015-10-27 Thread Thomas Lübking
On Dienstag, 27. Oktober 2015 21:23:00 CET, Dimitrios Glentadakis wrote: So, i understand that it is not written in the file but only in memory. Probably is fixed in git though No, actually *that* is a problem: diff --git a/src/Plugins/AbookAddressbook/AbookAddressbook.cpp b/src/Plugins/Abook

Re: [trojita] The personal notes in the addressbook are not saved

2015-10-27 Thread Thomas Lübking
On Dienstag, 27. Oktober 2015 20:52:22 CET, Dimitrios Glentadakis wrote: I write a personal note in a contact's details [notes] and after restarting trojita the note has been disappeared I run the 0.5 version Works for me - (git master, though) Do you get a dialog that asks whether you want t

[trojita] Re: Deprecating the Qt4 version and the RHEL6, Ubuntu 12.04, Debian 7 and Harmattan builds

2015-10-08 Thread Thomas Lübking
On Donnerstag, 8. Oktober 2015 16:30:18 CEST, Pali Rohár wrote: I prefer old and abandoned software which is working instead of new super-über-modern non working buggy slow one... You. Are. Missing. The. Point. If you deperately want to stay with kdepim and aborted kdepim from KDE 4.2 you'll a

[trojita] Re: Deprecating the Qt4 version and the RHEL6, Ubuntu 12.04, Debian 7 and Harmattan builds

2015-10-08 Thread Thomas Lübking
On Donnerstag, 8. Oktober 2015 10:10:41 CEST, Pali Rohár wrote: Do not know... Until I choose other system/software for PIM. (And no akonadi is still not fast and usable on my devices.) Speed aside, I even question the architecture of akonadi. However relying on an aborted PIM stack has certain

[trojita] Re: Deprecating the Qt4 version and the RHEL6, Ubuntu 12.04, Debian 7 and Harmattan builds

2015-10-08 Thread Thomas Lübking
On Donnerstag, 8. Oktober 2015 09:38:45 CEST, Pali Rohár wrote: I know that there is some PPA for Qt5. I did not try it because KDE4 plugins (addressbook) is incompatible with Qt5. This is something which I need... The never-to-be-ported KABC addressbook? Ie. you're restricted to Qt4 forever?

[trojita] Re: Building IMAP core.

2015-09-08 Thread Thomas Lübking
On Dienstag, 8. September 2015 21:48:42 CEST, Peter Bočan wrote: I do wonder how to test the IMAP part? Which classes are essential and where to start? Assuming you're not asking for how to run the unit tests: you're basically asking "What tools do I need? How do I use them?" but you're not t

Re: [trojita] periodic imap refresh change mouse cursor

2015-05-28 Thread Thomas Lübking
On Donnerstag, 28. Mai 2015 12:30:03 CEST, Pali Rohár wrote: Its good question. When I'm composing new email and every 30s I see cursor change it is 1) annoying and hard to write + think about new email and 2) for me (and probably) other users looks like some error... One could constrain the c

Re: [trojita] freezing when search a text

2015-05-22 Thread Thomas Lübking
On Freitag, 22. Mai 2015 12:26:08 CEST, Jan Kundrát wrote: ...but the m_associatedWebView is a QPointer, and it is guarded And this is why guarded pointers are shit - they do weird things ;-) The object is still there, but it's only a qwidget - but we access the dying object as if it still wa

[trojita] Re: 2 new features

2015-05-22 Thread Thomas Lübking
On Freitag, 22. Mai 2015 12:29:50 CEST, Jan Kundrát wrote: It won't be that simple, unfortunately. Our code uses multiple QWebView instances to show multipart messages; for example, when someone forwards you an e-mail as an attachment, you'll have at least two QWebView widgets next to each oth

Re: [trojita] 2 new features

2015-05-22 Thread Thomas Lübking
On Freitag, 22. Mai 2015 06:34:28 CEST, Dimitrios Glentadakis wrote: Hi, i'd like to propose two new features 1) Print 2) right click > copy selected text (2) is available in current master. As much as (1) is a running gag here around, it will probably be required to allow widespread usage i

Re: [trojita] freezing when search a text

2015-05-22 Thread Thomas Lübking
On Freitag, 22. Mai 2015 06:49:34 CEST, Dimitrios Glentadakis wrote: I don't know if it is only me or maybe i have a hardware problem also, if i select a word and right click on it and choose 'Search...' after trojita freezes, i have to kill the process. Stalls in #0 0xb521a70a in ?? () fro

Re: [trojita] freezing when search a text

2015-05-22 Thread Thomas Lübking
On Freitag, 22. Mai 2015 06:49:34 CEST, Dimitrios Glentadakis wrote: I don't know if it is only me or maybe i have a hardware problem also, if i select a word and right click on it and choose 'Search...' after trojita freezes, i have to kill the process. It happens (on Qt5 builds can't try Qt

Re: [trojita] New user questions

2015-05-14 Thread Thomas Lübking
On Donnerstag, 14. Mai 2015 10:52:30 CEST, Jan Kundrát wrote: On Thursday, 14 May 2015 05:39:23 CEST, Thomas Lübking wrote: We'd require an explicit save button if this is considered a supported condition/environment. I thought that NETWM was pretty widespread; IMHO it's fine to

Re: [trojita] New user questions

2015-05-13 Thread Thomas Lübking
On Donnerstag, 14. Mai 2015 01:18:17 CEST, Hari Sundar wrote: Thanks, 1) I use xmonad, and was hitting `esc` to dismiss the dialog, which was not giving me the option to save the changes. Interesting. The AddressBook intercepts its closing to show a modal dialog - it sounds as if xmonad eith

Re: [trojita] New user questions

2015-05-13 Thread Thomas Lübking
On Donnerstag, 14. Mai 2015 00:09:53 CEST, Hari Sundar wrote: 1. The addressbook does not seem to work. When I click on the icon next to a sender (etc), I get the dialog, and it seems to add it momentarily, but the changes do not persist. Upon closing the addressbook dialog, you should get a "sa

[trojita] Re: Welcome page not translated

2015-03-24 Thread Thomas Lübking
On Dienstag, 24. März 2015 12:35:18 CEST, Kevin Krammer wrote: http://trojita.flaska.net/welcome.html That's because KDE's localization infrastructure doesn't support this use case, as far as I know. Patches welcome; it shouldn't be that hard to do it, considering that they were able to add su

Re: [trojita] Redesigning the UI

2015-03-20 Thread Thomas Lübking
On Freitag, 20. März 2015 13:26:10 CET, Jan Kundrát wrote: Would it make sense for Trojita to look like this by default? What do you think? I'd rather move the toolbar to the right hand. On the left, it resembles the look of many vertical tab bars (eg. think of opera) and most of the actions a

Re: [trojita] User Agent Info Leak

2015-03-03 Thread Thomas Lübking
On Dienstag, 3. März 2015 13:10:43 CET, Jan Kundrát wrote: What do others think, should we make this user-configurable? While the OP is largely exaggerating on the topic, this might be a valuable feature for some very exposed people, who're likely subject to specialized attacks (we're not ta

Re: [trojita] Build mode, debug symbols, asserts

2015-01-07 Thread Thomas Lübking
On Mittwoch, 7. Januar 2015 09:25:25 CEST, Pali Rohár wrote: Re debug symbols Should stay by default. Another question is: What do you mean by "default" above? When you "cmake .." w/o further adjustments, this should result in an O2 build. Whether you'd like to support a build type type tha

Re: [trojita] Build mode, debug symbols, asserts

2015-01-06 Thread Thomas Lübking
On Dienstag, 6. Januar 2015 18:15:02 CEST, Jan Kundrát wrote: - Report all reasonable warnings. +1 (for sure) Warnings are IMHO quite useful because they can hint about possible problems in the code. If there's a known comflict (where we cannot avoid a warning but know it's ok) and this gets

[trojita] Clang fun with templates

2015-01-03 Thread Thomas Lübking
Hi everybody, please see https://gerrit.vesnicky.cesnet.cz/r/#/c/300/1 for reference. --- Attached is a stripped-down testcase of the PartVisitor template used in trojita. $ tar -xJf template_test.txz $ cd template_test $ g++ -o test main.cpp class.cpp # this should have worked nicely, wher

Re: [trojita] periodic imap refresh change mouse cursor

2014-12-20 Thread Thomas Lübking
Am Samstag, 20. Dezember 2014 schrieb Pali Rohár : > Patch did not help :-( Updating takes more time, so I still see > cursor change. How much time does it take? Cheers, Thomas

Re: [trojita] periodic imap refresh change mouse cursor

2014-12-18 Thread Thomas Lübking
On Donnerstag, 18. Dezember 2014 17:14:43 CEST, Jan Kundrát wrote: Could you please push it to Gerrit? :) Afaiu, Pali just wanted a patch to try for himself - but: "sure" =) https://gerrit.vesnicky.cesnet.cz/r/251 Cheers, Thomas

Re: [trojita] periodic imap refresh change mouse cursor

2014-12-18 Thread Thomas Lübking
On Donnerstag, 18. Dezember 2014 10:42:04 CEST, Pali Rohár wrote: I do not know if 500ms is enough for me (when updating about 40 imap folders), but if you can provide easy/small patch I can test it what happens... It's not a very complex patch. Given your concerns and a personal flavor, I ra

Re: [trojita] periodic imap refresh change mouse cursor

2014-12-17 Thread Thomas Lübking
On Mittwoch, 17. Dezember 2014 17:22:48 CEST, Pali Rohár wrote: What do you think about changing Trojita code to not change mouse cursor when doing that periodic imap refresh? My 2¢ a) it should be Qt::BusyCursor, not Qt::WaitCursor (the UI isn't locked, you can still successfully interact w/

[trojita] Silence Zuul?

2014-12-16 Thread Thomas Lübking
Would it be possible and make sense to have the build service send mails only a) on failure b) to the committer(s)? The Zuul state is hinted on the webpage anyway and nobody is really interested in "yes, builds as expected" mails and if it doesn't build, that would mostly concern the author. I

[trojita] Re: Change in trojita[master]: CHANGELOG:Fix inconsistent checkbox state BUG:340698 CCBUG:3...

2014-12-14 Thread Thomas Lübking
Ah, sh** On Sonntag, 14. Dezember 2014 17:12:23 CEST, Thomas Lübking wrote: On Sonntag, 14. Dezember 2014 16:43:10 CEST, Nuno Hultberg wrote: Thomas, I'll add markReplyModeHandpicked(). I am using kate. Settings/Configure Editor/Editing/Indentation/->Spaces: "4 characters"

Re: [trojita] SettingsDialog size control patch

2014-10-23 Thread Thomas Lübking
On Freitag, 24. Oktober 2014 01:21:06 CEST, Jan Kundrát wrote: If the original change is not perfect, but works on its own, then one can upload a followup change. This is done by checking out the original change and placing another commit as a child of the old one. Gerrit will make sure that t

[trojita] SettingsDialog size control patch

2014-10-23 Thread Thomas Lübking
Sorry, took a bit longer (I wasn't all happy about "when fix size", maybe am still not) The core problem is QTabWidget, which does not behave like other widgets on a layout update (since it contains an unlayouted QStackedWidget which holds the actual tabwidgets) The attached patch seeks to a

Re: [trojita] Feedback on UI for message redirection

2014-08-13 Thread Thomas Lübking
On Mittwoch, 13. August 2014 19:11:56 CEST, Karan Luthra wrote: In the initial UI mockup that started this thread, this wasn't so. Infact in the redirection use-case, the subject field was serving the purpose of identifying the message picked for redirection to be the correct, intended one. Th

[trojita] Slow rendering giant mail

2014-08-08 Thread Thomas Lübking
Jan, when attempting the scroll-to-filter thing you concerned that it would cause trouble with a slow rendering giant mail under your possession. Would that "just" be Crispin's "Multi-media mail demonstration" or something else and if the latter, is it publically available or could you share i

[trojita] Re: Opinion Needed - Subject Lines for Forwarded Mails

2014-08-01 Thread Thomas Lübking
On Freitag, 1. August 2014 14:19:00 CEST, Karan Luthra wrote: If we keep making a new format for Fwd prefix count out of the scope of this patch, then which out of the two original alternatives can we move forward with, atleast for now? 1. Just append a "Fwd: " to the subject line when a forwa

[trojita] Re: Opinion Needed - Subject Lines for Forwarded Mails

2014-07-31 Thread Thomas Lübking
On Donnerstag, 31. Juli 2014 21:44:58 CEST, Karan Luthra wrote: I am not sure whether picking up a new way of conveying this (compressed) information is good for inter-operability. While these suggestions are well thought, and serve the purpose well, they are still not part of any standard or

[trojita] Re: Opinion Needed - Subject Lines for Forwarded Mails

2014-07-31 Thread Thomas Lübking
On Donnerstag, 31. Juli 2014 20:06:23 CEST, Karan Luthra wrote: While my first go was at alternative 1, because who doesn't want a neat looking subject line; After some discussion on IRC with Jan and offline with Jai (darkapex), I saw the use-cases for the information conveyed by multiple "Fwd

[trojita] Re: Mozilla ISP Database Auto-configuration Class

2014-07-21 Thread Thomas Lübking
On Montag, 21. Juli 2014 23:21:37 CEST, Matt Richardson wrote: but that might be preferable to automatically sending the user's email address to a third-party. Is that actually reuqired or could one modify the sent address john@gmail.com -> trojita.f...@gmail.com Ultimately you want the da

Re: [trojita] Multiaccuointing

2014-07-19 Thread Thomas Lübking
On Samstag, 19. Juli 2014 11:09:54 CEST, Anton Müller wrote: Hello friends of very fast imap clients, does any one of know i recieve the mail more than one account? https://bugs.kde.org/show_bug.cgi?id=321374 However, see http://article.gmane.org/gmane.mail.trojita.general/884 The patch is pa

[trojita] Re: Built trojita on MSVC2012

2014-06-25 Thread Thomas Lübking
On Mittwoch, 25. Juni 2014 10:12:28 CEST, kang joni wrote: Recently I do small hack to make it build on msvc2012, https://drive.google.com/file/d/0B7YRdCK_Bnn6RUtSNkszZlZLZXc/edit?usp=sharing thanks , hope will useful and sorry dont have time to write the patch :) Forwarded, though not sure whe

[trojita] Re: "System Error" when using Gmail

2014-05-27 Thread Thomas Lübking
On Dienstag, 27. Mai 2014 17:38:50 CEST, Steve Dodd wrote: Hi everyone, I've finally gotten around to setting up Trojita 0.4.1 again, currently against a test Gmail account. Periodically Gmail seems to close the connections with "BYE system error" or similar How many ppl. are behind your IP? F

[trojita] Re: Bizarre one-off crash while attaching a file

2014-05-13 Thread Thomas Lübking
On Dienstag, 13. Mai 2014 05:48:41 CEST, James Harkins wrote: Admittedly, there isn't much that can be done about this at present -- but, I just tried to attach a 500 MB PDF to any message, and Trojita chewed up 100% of one of the cores for a few seconds before crashing. Unfortunately, I'm runn

[trojita] Re: Unread message count fails to update

2014-05-09 Thread Thomas Lübking
On Freitag, 9. Mai 2014 11:43:51 CEST, James Harkins wrote: On May 9, 2014 1:47:07 PM Jan Kundrát wrote: That's exactly how Trojita works. You say that it doesn't work that way for you. I am confused how this could happen, and the IMAP logs might help me reproduce that issue. I see, thanks f

Re: [trojita] Supported mailbox formats

2014-05-01 Thread Thomas Lübking
On Donnerstag, 1. Mai 2014 16:57:48 CEST, atalantt...@gmail.com wrote: Hi, which mailbox formats are supported by Trojitá? None - it's an IMAP client (with an optional SQL cache) It does not operate on "local" mail (unless your IMAP server is local) Cheers, Thomas

Re: [trojita] Where is the address book located?

2014-04-23 Thread Thomas Lübking
Am Mittwoch, 23. April 2014 schrieb James Harkins : > Hi, > > Because of a hardware failure, I am unexpectedly forced to migrate to > a new system. > > I had saved some contacts into Trojita's address book, and I would > like to copy them to the new system. (The hard drive from the old > system is

[trojita] Re: Using QActions for next/previous message and inside-message scrolling

2014-04-09 Thread Thomas Lübking
On Mittwoch, 9. April 2014 16:39:53 CEST, Jan Kundrát wrote: Hi, Thomas, others, is there any reason why we don't have a couple of QActions for stuff like "go to next message" (key down), "previous one" (key up), "scroll message down" (space), "scroll message up" (backspace)? Afair the itemv

Re: [trojita] Fwd: Handful of usability issues

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 12:39:01 CEST, Jan Kundrát wrote: On Sunday, 30 March 2014 12:10:38 CEST, James Harkins wrote: - Can't use space in the message list to page through reading pane Try using the mouse wheel or send us patches which prevent focus stealing on space. Trivial. Have patch

Re: ---[trojita] send mail from courier-imap-ssl using Trojita e-mail client

2014-03-10 Thread Thomas Lübking
On Montag, 10. März 2014 14:31:55 CEST, Bertil wrote: but LOGINDISABLED ! I think that has to be fixed ! That's a matter of the IMAP server authentication config and ultimately means not to try plaintext athentication (will fail and the password would be transmitted unencrypted) - it has no

Re: [trojita] Trojita won't build on VC++ 2013 with openssl

2014-03-05 Thread Thomas Lübking
Am Mittwoch, 5. März 2014 schrieb Robin Rowe : > Thanks for the suggestion to build Qt with openssl. Still trying to make that work. > > The file openssl/include/ssl.h contains one line: > > ../../ssl/ssl.h > > This doesn't look like C++ to me. it's not and there's no "openssl" subdir to the Qt so

[trojita] Re: Trojita build on VC++ 2013

2014-03-02 Thread Thomas Lübking
On Sonntag, 2. März 2014 13:08:31 CEST, Robin Rowe wrote: On 2/21/2014 1:13 PM, Thomas Lübking wrote: Your Qt is very likely build w/o ssl support You are correct. So, I built OpenSSL as you suggested. However, when I try to build Qt with SSL, I get the errors below. I tried with QT4 and

[trojita] Re: Trojita build on VC++ 2013

2014-02-21 Thread Thomas Lübking
On Freitag, 21. Februar 2014 22:06:26 CEST, Robin Rowe wrote: Jan, Thanks. Using your patch I was able to get cmake to work. However, more issues... Can't build with msbuild. Can't build with Visual Studio. Your Qt is very likely build w/o ssl support, see eg. http://stackoverflow.com/ques

[trojita] Re: Systray unread count pull request

2014-01-08 Thread Thomas Lübking
On Mittwoch, 8. Januar 2014 19:41:04 CEST, Jan Kundrát wrote: - just INBOX, - all subscribed, - folders explicitly marked by the user as to be included (i.e. opt-in) I'd vote for opt-in with INBOX preselection, because of ... It would also mean that the program has to list folders recursivel

[trojita] Re: Systray unread count pull request

2014-01-02 Thread Thomas Lübking
On Donnerstag, 2. Januar 2014 19:48:31 CEST, Jan Kundrát wrote: If this change went in as-is, the systray message count would be completely useless to me, so I cannot accept it as-is. What might work well is a setting option for toggling whether to include just the INBOX, or all subscribed mail

[trojita] Re: Using 3rd party content on the Trojitá's website

2013-11-27 Thread Thomas Lübking
On Donnerstag, 28. November 2013 00:49:49 CEST, Jan Kundrát wrote: don't put too much effort in there, it's going to be obsolete in a couple of months anyway. Ok, thanks (just started playing around slightly =) Cheers, Thomas

[trojita] Re: Using 3rd party content on the Trojitá's website

2013-11-27 Thread Thomas Lübking
On Mittwoch, 27. November 2013 23:33:42 CEST, Jan Kundrát wrote: The problem of the current design is that it doesn't work on big screens or small screens; the font size is too small to be readable *cough* font:12px sans-serif; *cough* "surprise" :-P *never* define font sizes in px (unless

[trojita] Re: Using 3rd party content on the Trojitá's website

2013-11-26 Thread Thomas Lübking
On Dienstag, 26. November 2013 12:48:16 CEST, Caspar Schutijser wrote: On Monday, 25 November 2013 19:30:51 CEST, Jan Kundrát wrote: I have mixed feelings about this -- on one hand, privacy-conscious users can set up an appropriate block list themselves if they mind the additional tracking.

[trojita] Re: Slower than Thunderbird on large text emails

2013-10-24 Thread Thomas Lübking
On Donnerstag, 24. Oktober 2013 13:21:49 CEST, Mike Cardwell wrote: When I click it in the message list in Thunderbird, it takes 2 seconds to display it in the preview pane. In Trojita, the same action takes 6 times longer at 12 seconds. Let's assume both are locally cached (so no network impac

[trojita] Re: view-source bug

2013-10-17 Thread Thomas Lübking
On Donnerstag, 17. Oktober 2013 18:26:00 CEST, Jan Kundrát wrote: On Thursday, 17 October 2013 16:56:46 CEST, Mike Cardwell wrote: I tried sending myself an email using https://emailprivacytester.com/ and viewing it in Trojita. When I viewed it, an animated "Fetching Message" icon appeared over

[trojita] Re: Cannot load remote images on WIndows XP

2013-10-17 Thread Thomas Lübking
On Donnerstag, 17. Oktober 2013 19:14:42 CEST, Jan Kundrát wrote: I cannot help here, sorry. I don't see anything obvious or windows-version-depending within the WebKit sources, either. Missing image codec plugin? Cheers, Thomas

Re: [trojita] Adding a QScrollArea for recipients inside the ComposerWidget

2013-09-13 Thread Thomas Lübking
Fading version, replaces former patch.From 6eaaa2c88459cde9c36c4598a8d6cd83a4070919 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20L=C3=BCbking?= Date: Sat, 14 Sep 2013 01:03:00 +0200 Subject: [PATCH] cc scrolling --- src/Gui/ComposeWidget.cpp | 127 ++

[trojita] Re: Adding a QScrollArea for recipients inside the ComposerWidget

2013-09-13 Thread Thomas Lübking
On Dienstag, 10. September 2013 23:36:13 CEST, Jan Kundrát wrote: Could be, but IIRC I set that already. I suspect that this happened because the QFormLayout works on "fixed rows" and is not designed to "resize stuff that can be resized to better utilize the space". Ahhh, the beloved QFormL

[trojita] Re: GSoC: plugins & loader

2013-09-11 Thread Thomas Lübking
On Mittwoch, 11. September 2013 18:07:36 CEST, Pali Rohár wrote: Now I looked into qt4 source code and default priority is: 1. QLibraryInfo::location(QLibraryInfo::PluginsPath) 2. QCoreApplication::applicationFilePath() 3. QT_PLUGIN_PATH In addition, in Kontact the output of tha list will lik

[trojita] Re: Adding a QScrollArea for recipients inside the ComposerWidget

2013-09-10 Thread Thomas Lübking
On Dienstag, 10. September 2013 22:14:19 CEST, Jan Kundrát wrote: Hi, there's a problem with the compose widget -- when there are too many recipients, there is not much space left for the actual area where one could type the message. That's why I'd like to add a QScrollArea to the mix. I've tri

[trojita] Re: GSoC: plugins & loader

2013-09-10 Thread Thomas Lübking
On Dienstag, 10. September 2013 17:15:41 CEST, Jan Kundrát wrote: On Tuesday, 10 September 2013 11:52:35 CEST, Pali Rohár wrote: And what about using *only* QCoreApplication::libraryPaths() for searching trojita plugins? Would you like to store plugins as /usr/bin/trojita-plugins/trojita_plug

[trojita] Re: GSoC: plugins & loader

2013-09-09 Thread Thomas Lübking
On Montag, 9. September 2013 21:00:17 CEST, Pali Rohár wrote: On Monday 09 September 2013 20:52:37 Kevin Krammer wrote: On Monday, 2013-09-09, Pali Rohár wrote: On Monday 09 September 2013 20:26:27 Thomas Lübking wrote: On Montag, 9. September 2013 12:55:47 CEST, Pali Rohár wrote

[trojita] Re: GSoC: plugins & loader

2013-09-09 Thread Thomas Lübking
On Montag, 9. September 2013 12:55:47 CEST, Pali Rohár wrote: And my question is what do you think about searching for plugins in "./plugins/" directory (instead ".") and in $SOME_ENV_PATH directory? It is acceptable? $SOME_ENV_PATH seems reasonable (Qt allows envs to control plugin paths) an

[trojita] Re: GSoC: plugins & loader

2013-09-08 Thread Thomas Lübking
On Sonntag, 8. September 2013 14:19:02 CEST, Pali Rohár wrote: Ok, so I see that everybody is against loading plugins from application directory. What about this solution? Load plugins from system path specified at compile time and also from some application subdirectory (plugins). And thi

[trojita] Re: GSoC: plugins & loader

2013-09-07 Thread Thomas Lübking
On Samstag, 7. September 2013 10:15:47 CEST, Pali Rohár wrote: So why adding new code "impl = new" for each plugin, if Qt support Q_IMPORT_PLUGIN which adding plugin into QPluginLoader? To bypass your apparent linker hazzles? No linker trouble, no hard requirement. It's btw. also what QStyleFa

[trojita] Re: GSoC: plugins & loader

2013-09-06 Thread Thomas Lübking
On Samstag, 7. September 2013 02:18:48 CEST, Pali Rohár wrote: On Friday 06 September 2013 20:23:19 Jan Kundrát wrote: ...which is why I like Thomas' suggestion to use actual instantiation of the basic plugins like passwords-in-qsettings, i.e. the call to a "impl = new FooPlugin(...)". FooPlug

[trojita] Re: GSoC: plugins & loader

2013-09-06 Thread Thomas Lübking
On Freitag, 6. September 2013 12:27:08 CEST, Jan Kundrát wrote: Pali, Thomas, Caspar, Kevin -- which of these do you prefer? Assuming that ppl. will likely use either the trojita standalone XOR the kontact plugin, (3) seems fine. Not sure about the compile/link overhead (degree), though - CMa

[trojita] Re: Review Request 112168: Other visual changes to attachments

2013-09-03 Thread Thomas Lübking
On Mittwoch, 4. September 2013 01:48:20 CEST, Thomas Lübking wrote: On Aug. 20, 2013, 1:13 a.m., Jan Kundrát wrote: ... -> git.kde.org / thomas_attachment_layout Sorry, just ignore that mail - there was a pending reply in RB i didn't understand. Thomas

[trojita] Re: GSoC: IPC support

2013-08-30 Thread Thomas Lübking
On Donnerstag, 29. August 2013 20:46:32 CEST, Pali Rohár wrote: On Thursday 22 August 2013 12:49:08 Jan Kundrát wrote: On Thursday, 22 August 2013 12:46:34 CEST, Pali Rohár wrote: ... Not only from command line, but also used by external applications/scripts. Case a) I doubt any one will in

[trojita] Re: Upcoming KDE PIM Sprint

2013-08-23 Thread Thomas Lübking
On Freitag, 23. August 2013 12:27:39 CEST, Jan Kundrát wrote: On Tuesday, 20 August 2013 16:47:36 CEST, Kevin Krammer wrote: The Autumn sprint is usually our coding sprint [1], so it Thomas, Caspar, Pali -- would you be able to attend? Physically? Unlikely, sorry. (Even if there was a defin

[trojita] Re: master build fails?

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 19:57:29 CEST, Caspar Schutijser wrote: Weird. Do you really have the unmodified master branch? I hope so =) There's actually passwordWarning = new QLabel(scrollAreaWidgetContents); in ui_SettingsOutgoingPage.h BUT (hehe, sorry): There're relicts from qmake based

[trojita] Re: master build fails?

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 19:35:21 CEST, Caspar Schutijser wrote: What kind of error do you get? /home/src/KDE4/trojita/src/Gui/SettingsDialog.cpp: In Konstruktor »Gui::OutgoingPage::OutgoingPage(QWidget*, QSettings&)«: /home/src/KDE4/trojita/src/Gui/SettingsDialog.cpp:509:5: Fehler: »pa

[trojita] master build fails?

2013-08-13 Thread Thomas Lübking
For a while now, patch attached but i'm unsure whether that's just something local? (Somebody would have noticed?) Cheers, Thomas From d85b06b93691d05b49ce8d8d55945058e7b35803 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20L=C3=BCbking?= Date: Sun, 11 Aug 2013 13:18:36 +0200 Subject: [PATCH

[trojita] Re: GSoC: plugins & loader

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 12:39:58 CEST, Jan Kundrát wrote: - it works only on GCC Semi, see my other mail. - the linker flags one needs could be considered hackish Yesno. It's used to wrap static archives into shared objects, esp. when using them for toolkits. It's (afaics) rather uncom

[trojita] Re: GSoC: plugins & loader

2013-08-13 Thread Thomas Lübking
On Dienstag, 13. August 2013 08:26:51 CEST, Pali Rohár wrote: On Monday 12 August 2013 22:36:26 Jan Kundrát wrote: They way I understand it, Pali wants to support a configuration where there are no shared libraries, just the /usr/bin/trojita with some plugins statically linked in. Yes, I wa

Re: [trojita] GSoC: plugins & loader

2013-08-12 Thread Thomas Lübking
On Montag, 12. August 2013 15:48:25 CEST, Pali Rohár wrote: On Monday 12 August 2013 15:34:18 Jan Kundrát wrote: On Monday, 12 August 2013 15:30:16 CEST, Pali Rohár wrote: ... This providing support for fallback default plugins such as clear text password storage. This means when system troj

[trojita] [RFC] Re: support X-GM-THRID?

2013-08-12 Thread Thomas Lübking
On Montag, 12. August 2013 18:44:07 CEST, Jan Kundrát wrote: like a "Show Conversation" button in the header widget and on clicked() fire a new thread to "uid fetch (X-GM-THRID)" and on response trigger "uid search X-GM-THRID <64_bit_thread_id_here>" (by setting the search text to ":=X-GM-TH

[trojita] [RFC] support X-GM-THRID?

2013-08-11 Thread Thomas Lübking
Googles "threading" substitute. It requires X-GM-EXT-1 CAPABILITY, implementation could be like a "Show Conversation" button in the header widget and on clicked() fire a new thread to "uid fetch (X-GM-THRID)" and on response trigger "uid search X-GM-THRID <64_bit_thread_id_here>" (by setting t

[trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Thomas Lübking
On Samstag, 10. August 2013 18:15:57 CEST, Pali Rohár wrote: On Saturday 10 August 2013 17:48:27 Jan Kundrát wrote: On Saturday, 10 August 2013 17:13:28 CEST, Pali Rohár wrote: ... I wanted to have trojita mail client as small as possible without too many dependencies & libraries. ldd /usr/

[trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Thomas Lübking
On Samstag, 10. August 2013 17:13:28 CEST, Pali Rohár wrote: I think this option is cleaner solution Having core and Plugins operating on a common interface via a common shared library is a clean dependency chain. Whatever you can bring against it, it's for sure not "dirty". I understood you

[trojita] Re: GSoC: plugins & loader

2013-08-09 Thread Thomas Lübking
On Donnerstag, 8. August 2013 10:04:10 CEST, Pali Rohár wrote: On Wednesday 07 August 2013 15:07:39 Jan Kundrát wrote: On Wednesday, 17 July 2013 21:42:04 CEST, Pali Rohár wrote: My current code have common "interface" classes for password and addressbook plugins. Because trojita working only w

[trojita] Re: GSoC merge request

2013-08-09 Thread Thomas Lübking
On Freitag, 9. August 2013 10:18:02 CEST, Jan Kundrát wrote: Qt5's QTimer contains a special case for QTimer::singleShot(0) (I suspect a lot of stuff would break if it was removed). s/a/the/ - and yes, probably removing the special case wasn't a good idea. I'd like to improve my Qt-fu, so I'm

[trojita] Re: GSoC merge request

2013-08-08 Thread Thomas Lübking
On Donnerstag, 8. August 2013 19:57:56 CEST, Pali Rohár wrote: Reason why I used QTimer::singleShot was that it is offent used in trojita code. Just run wc -l: Yes, it's a very popular abuse, doesn't change it's an abuse. (Though FWWI: The coarse timer operates on 5% base, since 5% of 0 is 0

[trojita] Re: GSoC merge request

2013-08-08 Thread Thomas Lübking
On Donnerstag, 8. August 2013 15:52:56 CEST, Pali Rohár wrote: For emails with lot of recipients this could lead to application crash... For each email address trojita is starting job. You mean for OOM due to job overhead? You could still keep up to 32 jobs in parallel or so. (Everytime one re

[trojita] Re: GSoC merge request

2013-08-08 Thread Thomas Lübking
On Donnerstag, 8. August 2013 11:24:35 CEST, Kevin Krammer wrote: I think what Thomas was suggesting was to make the action objects directly accessible instead of making Qt traverse the QObject tree to find them. Exactly. Whether unilateral changes in the XML menu file breaks things doesn't mat

[trojita] Re: Addressbook interface for qt plugins

2013-08-07 Thread Thomas Lübking
On Montag, 5. August 2013 17:20:16 CEST, Jan Kundrát wrote: It might be better to separate this into two classes. One that implements the addressbook and one that implements the interface using an instance of that class. One reason is that anyone creating new plugins will look at the existing

[trojita] Re: Another GSoC review

2013-08-05 Thread Thomas Lübking
On Montag, 5. August 2013 22:32:48 CEST, Jan Kundrát wrote: On Monday, 5 August 2013 19:54:05 CEST, Thomas Lübking wrote: Did i miss this? Where's mentioned "does not work" (reason is perhaps lacking Q_OBJECT macro?) From pali-gsoc-merge:src/Common/PluginLoader.cpp: // NOT

  1   2   3   >