On Mittwoch, 7. Januar 2015 09:25:25 CEST, Pali Rohár wrote:

Re debug symbols
Should stay by default.
Another question is: What do you mean by "default" above?

When you "cmake .." w/o further adjustments, this should result in an O2 build. Whether you'd like to support a build type type that switches from O2 to O0 + gdwarf is orthogonal to my opinion in this regard.

I'm for setting default CMAKE_BUILD_TYPE to RelWithDebInfo and not for modifying CXXFLAGS.
The problem here are the impacts beyond. Certain macros as Q_ASSERT are noop if debug is disabled (and also some debug message printing) - I assume this is why Jan would prefer to keep Debug as default. And the default should be O2 ;-)

=> Either a new build type would be required or RelWithDebInfo be turned into a more "Debug"-a-like mode (unfortunalely leaving Release as the only "true" release mode)

I'd have to lookup whether it's possible w/ cmake to perform some smart handling here (ie. either introduce another "FullDbg" build mode or detect whether "Debug" was issued explicitly)

Cheers,
Thomas

Reply via email to