On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch o
On Thu, 22 Aug 2024 19:36:00 GMT, Albert Mingkun Yang wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix hash shift for 32 bit builds
>
> src/hotspot/share/gc/shared/gcForwarding.cpp line 37:
>
>> 35: size_t ma
On Thu, 22 Aug 2024 17:30:14 GMT, Albert Mingkun Yang wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove hashcode leftovers from SA
>
> src/hotspot/share/gc/serial/serialArguments.cpp line 33:
>
>> 31: void Se
On Fri, 23 Aug 2024 16:23:19 GMT, Leonid Mesnik wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> make/Images.gmk line 135:
>
>> 133: #
>> 134: # Param1 - VM variant (e.g., server,
On Fri, 30 Aug 2024 07:25:54 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/serial/serialArguments.cpp line 33:
>>
>>> 31: void SerialArguments::initialize_heap_flags_and_sizes() {
>>> 32: GenArguments::initialize_heap_flags_and_sizes();
>>> 33: GCForwarding::initialize_flags(MaxNewSize
On Fri, 30 Aug 2024 07:27:45 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/shared/gcForwarding.cpp line 37:
>>
>>> 35: size_t max_narrow_heap_size = right_n_bits(NumLowBitsNarrow - Shift);
>>> 36: if (UseCompactObjectHeaders && max_heap_size > max_narrow_heap_size *
>>> HeapWordSize)
On Thu, 22 Aug 2024 20:08:43 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
I attempted to check stack trace in the core generated by [SEGV example in
upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv/upcall/Main.java)
with `jhsdb jstack`, however it failed with
On Fri, 30 Aug 2024 07:18:47 GMT, Thomas Stuefe wrote:
> [...] And the enum values would have to be in that namespace in any case, so
> we wont get around having to qualify all "mtXXX" flags NMT::mtXXX.
We already have to solve essentially that problem because its now a scoped
enum. We curren
On Thu, 29 Aug 2024 16:17:09 GMT, Stefan Karlsson wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemType` is much more suitable name.
>>
>> There is a
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Fri, 30 Aug 2024 09:14:11 GMT, Yasumasa Suenaga wrote:
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv
On Fri, 30 Aug 2024 09:14:11 GMT, Yasumasa Suenaga wrote:
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv
On Mon, 26 Aug 2024 02:07:39 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also update build to link properly
>
> I understand the cost overhead experienced by any individual Java run may
On Thu, 22 Aug 2024 17:12:09 GMT, Albert Mingkun Yang wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove hashcode leftovers from SA
>
> src/hotspot/share/gc/serial/defNewGeneration.cpp line 707:
>
>> 705:
On Fri, 30 Aug 2024 11:07:46 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/serial/defNewGeneration.cpp line 707:
>>
>>> 705: } else if (obj->is_forwarded()) {
>>> 706: // To restore the klass-bits in the header.
>>> 707: obj->forward_safe_init_mark();
>>
>> I wonder
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wall) and use a much
> more fine-grained approach to disabling s
Yes, I guess we could get rid of atomics for VirtualMemory since we lock
anyway in order to update the internal memory model.
In that case, maybe it only makes sense to split MemoryCounter into “live”
and “flat” classes, since VirtualMemory will effectively be flat anyway.
Thanks!
Robert Toyonag
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
> Move JVM implementation access flags that are not specified by the classfile
> format into Klass so we can shrink AccessFlags to u2 in a future change.
>
> Tested with tier1-7.
>
> NOTE: there are arm, ppc and s390 changes to this that are just a guess.
> Also, graal changes.
Coleen Phillim
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 21:03:09 GMT, Matias Saavedra Silva
wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 694:
>
>> 69
On Thu, 29 Aug 2024 22:40:43 GMT, Dean Long wrote:
>> src/hotspot/share/oops/klass.hpp line 436:
>>
>>> 434: #endif
>>> 435: static ByteSize bitmap_offset(){ return
>>> byte_offset_of(Klass, _bitmap); }
>>> 436: static ByteSize misc_flags_offset(){ return
>>> by
On Thu, 29 Aug 2024 22:03:39 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp line 76:
>
>> 74: load_kla
On Fri, 30 Aug 2024 13:45:16 GMT, Yudi Zheng wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 274:
>
>> 272: nonstatic_f
> The tests time out because of dedlock of of the thread that is in transition
> and thread changing field watches.
>
> They use JvmtiThreadState_lock and JvmtiVTMSTransitionDisabler.
>
> The change field watch require disabler, but attempt to use it only when
> already locked in
>
> void
>
On Fri, 30 Aug 2024 14:00:44 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Fri, 30 Aug 2024 11:35:51 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in clang, which is a rather
>> big sledgehammer to get rid of some warnings that proliferate in a few areas
>> of the build.
>>
>> We should instead leave -Wunused turned on (as done by
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch o
On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch o
On Wed, 28 Aug 2024 21:40:57 GMT, Chris Plummer wrote:
> Only allocate the cmdQueueLock once rather than allocate each time there is a
> new connection (and destroy when the connection is terminated).
>
> Currently each time there is a new debug agent connection established, the
> cmdQueueLock
On Wed, 28 Aug 2024 21:40:57 GMT, Chris Plummer wrote:
> Only allocate the cmdQueueLock once rather than allocate each time there is a
> new connection (and destroy when the connection is terminated).
>
> Currently each time there is a new debug agent connection established, the
> cmdQueueLock
On Fri, 30 Aug 2024 11:15:23 GMT, Stefan Karlsson wrote:
>> I was thinking the same, but there's a problem with that. If we get a
>> promotion failure in the young gen, we are leaving the dead objects marked
>> as forwarded. Then when the Full GC scans these regions with dead objects it
>> wil
On Fri, 30 Aug 2024 00:07:50 GMT, Alex Menkov wrote:
> The fix improves Attch API protocol and implements updated protocol on
> windows; shared code is ready to implement updated protocol support on other
> platforms.
> More detailed explanations on the 1st comment.
>
> Testing: tier1,tier2,ti
On Fri, 30 Aug 2024 14:50:45 GMT, Leonid Mesnik wrote:
>> The tests time out because of dedlock of of the thread that is in
>> transition and thread changing field watches.
>>
>> They use JvmtiThreadState_lock and JvmtiVTMSTransitionDisabler.
>>
>> The change field watch require disabler, bu
On Fri, 30 Aug 2024 18:18:03 GMT, Daniel D. Daugherty
wrote:
> You use the word `symbols`, e.g., `each argument is resticted by 1024
> symbols`. Do you really mean characters or bytes?
Bytes. The code used `char` buffers with fixed size.
-
PR Comment: https://git.openjdk.org/jdk/
On Fri, 30 Aug 2024 14:00:44 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Fri, 30 Aug 2024 16:59:13 GMT, Leonid Mesnik wrote:
>> Only allocate the cmdQueueLock once rather than allocate each time there is
>> a new connection (and destroy when the connection is terminated).
>>
>> Currently each time there is a new debug agent connection established, the
>> cmdQueu
> Move JVM implementation access flags that are not specified by the classfile
> format into Klass so we can shrink AccessFlags to u2 in a future change.
>
> Tested with tier1-7.
>
> NOTE: there are arm, ppc and s390 changes to this that are just a guess.
> Also, graal changes.
Coleen Phillim
On Fri, 30 Aug 2024 14:11:08 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 274:
>>
>>> 272: nonstatic_field(Klass, _bitmap,
>>>uintx) \
>>> 273: nonstatic_field(K
On Fri, 30 Aug 2024 14:00:44 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Fri, 30 Aug 2024 09:14:11 GMT, Yasumasa Suenaga wrote:
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv
On Fri, 30 Aug 2024 17:09:58 GMT, Leonid Mesnik wrote:
>> Only allocate the cmdQueueLock once rather than allocate each time there is
>> a new connection (and destroy when the connection is terminated).
>>
>> Currently each time there is a new debug agent connection established, the
>> cmdQueu
When SA fails to open/attach to a core file on linux or OSX, include a note
about using LIBSAPROC_DEBUG=1 in the error message. No one remembers this
magic, so it is useful to provide here. Even I always have to resort to looking
up the symbol in the SA source since I can never remember it. The
On Fri, 30 Aug 2024 20:18:15 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/ReattachStressTest.java line 76:
>>
>>> 74: // Read the first character of output to make sure we've
>>> waited until the
>>> 75: // debuggee is ready. This will be the debug agent's
>>> "Lis
On Fri, 30 Aug 2024 12:58:17 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/ci/ciKlass.cpp line 233:
>>
>>> 231: jint ciKlass::misc_flags() {
>>> 232: assert(is_loaded(), "not loaded");
>>> 233: GUARDED_VM_ENTRY(
>>
>> To Compiler folks: I don't think the VM_ENTRY is necessary, but if i
On Sat, 31 Aug 2024 00:04:57 GMT, Chris Plummer wrote:
>> Only allocate the cmdQueueLock once rather than allocate each time there is
>> a new connection (and destroy when the connection is terminated).
>>
>> Currently each time there is a new debug agent connection established, the
>> cmdQueu
On Fri, 30 Aug 2024 21:25:18 GMT, Vladimir Ivanov wrote:
>> I added a global typedef klass_flags_t because it didn't look confusing vs
>> KlassFlags and KlassFlags_t, and the lower case convention is something we
>> usually use for typedefs.
>
> I agree with Dean. I don't see why the value can'
On Sat, 31 Aug 2024 04:21:17 GMT, Yasumasa Suenaga wrote:
>> I attempted to check stack trace in the core generated by [SEGV example in
>> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativese
> Only allocate the cmdQueueLock once rather than allocate each time there is a
> new connection (and destroy when the connection is terminated).
>
> Currently each time there is a new debug agent connection established, the
> cmdQueueLock is allocated. It is then destroyed when the connection i
On Fri, 30 Aug 2024 20:28:11 GMT, Chris Plummer wrote:
> Thanks for fixing this. The SA changes look fine. You'll need an FFM expert
> for the hotspot changes.
Thank you!
> Is it possible to provide a test case? Maybe make a call into some blocking
> native API and then run jstack on the proc
On Fri, 30 Aug 2024 20:22:38 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix jvmci code.
>> - Some C2 refactoring.
>> - Assembly corrections from Matias and Dean.
>
> src/hotspot/share
> I attempted to check stack trace in the core generated by [SEGV example in
> upcall](https://github.com/YaSuenag/garakuta/blob/841452d9176dab1ddbb552009c180530eb81190b/NativeSEGV/ffm/upcall/src/main/java/com/yasuenag/garakuta/nativesegv/upcall/Main.java)
> with `jhsdb jstack`, however it failed
On Fri, 30 Aug 2024 21:35:49 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/opto/library_call.cpp line 3777:
>>
>>> 3775: Node* p = basic_plus_adr(kls, in_bytes(Klass::misc_flags_offset()));
>>> 3776: Node* mods = make_load(nullptr, p, TypeInt::UBYTE, T_BOOLEAN,
>>> MemNode::unordered);
On Fri, 30 Aug 2024 21:51:49 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
> Move JVM implementation access flags that are not specified by the classfile
> format into Klass so we can shrink AccessFlags to u2 in a future change.
>
> Tested with tier1-7.
>
> NOTE: there are arm, ppc and s390 changes to this that are just a guess.
> Also, graal changes.
Coleen Phillim
On Fri, 30 Aug 2024 20:54:33 GMT, Chris Plummer wrote:
> When SA fails to open/attach to a core file on linux or OSX, include a note
> about using LIBSAPROC_DEBUG=1 in the error message. No one remembers this
> magic, so it is useful to provide here. Even I always have to resort to
> looking u
On Wed, 28 Aug 2024 21:40:57 GMT, Chris Plummer wrote:
> Only allocate the cmdQueueLock once rather than allocate each time there is a
> new connection (and destroy when the connection is terminated).
>
> Currently each time there is a new debug agent connection established, the
> cmdQueueLock
60 matches
Mail list logo
