On Thu, 22 Aug 2024 17:30:14 GMT, Albert Mingkun Yang <ay...@openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove hashcode leftovers from SA
>
> src/hotspot/share/gc/serial/serialArguments.cpp line 33:
>
>> 31: void SerialArguments::initialize_heap_flags_and_sizes() {
>> 32: GenArguments::initialize_heap_flags_and_sizes();
>> 33: GCForwarding::initialize_flags(MaxNewSize + MaxOldSize);
>
> Can one use `MaxHeapSize` here?
Good catch. This is actually a bug that is causing the CDS tests to fail. The
used variables have not yet been initialized at this point. I tried making the
suggested change and that fixed at least one of the CDS failures.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1738101667
