On Fri, 30 Aug 2024 20:54:33 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> When SA fails to open/attach to a core file on linux or OSX, include a note > about using LIBSAPROC_DEBUG=1 in the error message. No one remembers this > magic, so it is useful to provide here. Even I always have to resort to > looking up the symbol in the SA source since I can never remember it. The > extra output you get with LIBSAPROC_DEBUG=1 is often enough for the user to > determine the root cause, or at least help an SA engineer determine the cause. > > Test by running all SA tests and also tier1. > > Also did manual testing with forced errors reading core files to make sure > the error output is as expected. Marked as reviewed by amenkov (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/20800#pullrequestreview-2273635470
