On Tue, 3 Sep 2024 08:42:23 GMT, Yudi Zheng wrote:
>> I made the change to refactor the getMiscFlags function, but if you want to
>> add knowledge of the KlassFlags class (and InstanceKlassFlags also), you
>> could do that separately from this PR.
>
> I think JVMCI already knows these type via
On Fri, 30 Aug 2024 20:23:54 GMT, Coleen Phillimore wrote:
>> I don't think the JVMCI knows about the type KlassFlags - I used the same
>> code that I used for InstanceKlass::_misc_flags._flags (see above this).
>
> I made the change to refactor the getMiscFlags function, but if you want to
>
On Fri, 30 Aug 2024 21:25:18 GMT, Vladimir Ivanov wrote:
>> I added a global typedef klass_flags_t because it didn't look confusing vs
>> KlassFlags and KlassFlags_t, and the lower case convention is something we
>> usually use for typedefs.
>
> I agree with Dean. I don't see why the value can'
On Fri, 30 Aug 2024 12:58:17 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/ci/ciKlass.cpp line 233:
>>
>>> 231: jint ciKlass::misc_flags() {
>>> 232: assert(is_loaded(), "not loaded");
>>> 233: GUARDED_VM_ENTRY(
>>
>> To Compiler folks: I don't think the VM_ENTRY is necessary, but if i
On Fri, 30 Aug 2024 14:11:08 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 274:
>>
>>> 272: nonstatic_field(Klass, _bitmap,
>>>uintx) \
>>> 273: nonstatic_field(K
On Fri, 30 Aug 2024 13:45:16 GMT, Yudi Zheng wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 274:
>
>> 272: nonstatic_f
On Thu, 29 Aug 2024 22:03:39 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp line 76:
>
>> 74: load_kla
On Thu, 29 Aug 2024 22:40:43 GMT, Dean Long wrote:
>> src/hotspot/share/oops/klass.hpp line 436:
>>
>>> 434: #endif
>>> 435: static ByteSize bitmap_offset(){ return
>>> byte_offset_of(Klass, _bitmap); }
>>> 436: static ByteSize misc_flags_offset(){ return
>>> by
On Thu, 29 Aug 2024 21:03:09 GMT, Matias Saavedra Silva
wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 694:
>
>> 69
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 22:29:43 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/share/ci/ciKlass.cpp line 231:
>
>> 229: // --
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to t
On Thu, 29 Aug 2024 16:28:29 GMT, Yudi Zheng wrote:
>> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 484:
>>
>>> 482: declare_constant(JVMCINMethodData::SPECULATION_LENGTH_BITS)
>>>\
>>> 483:
>>>\
>>>
On Thu, 29 Aug 2024 16:39:51 GMT, John R Rose wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add in graal flags and a comment.
>
> src/hotspot/share/oops/klass.hpp line 198:
>
>> 196: #endif
>> 197:
>> 198:
> Move JVM implementation access flags that are not specified by the classfile
> format into Klass so we can shrink AccessFlags to u2 in a future change.
>
> Tested with tier1-7.
>
> NOTE: there are arm, ppc and s390 changes to this that are just a guess.
> Also, graal changes.
Coleen Phillim
23 matches
Mail list logo
