On Mon, 20 Jan 2025 21:25:51 GMT, Simon Tooke wrote:
> This fix widens the regex used to determine if a JAVAHEAP line is correct in
> the output of System.map/System.dump_map.
This pull request has now been integrated.
Changeset: 1ed396b4
Author: Simon Tooke
Committer: Severin G
On Tue, 21 Jan 2025 13:50:31 GMT, Kevin Walls wrote:
>> @kevinjwalls thanks for the suggestion. I wish I could duplicate your issue.
>> I prefer to leave 'cow' in, as the goal of this test is to ensure System.map
>> works, not to confirm the implementation of a specific garbage collector.
>>
On Tue, 21 Jan 2025 10:26:41 GMT, Kevin Walls wrote:
>> This fix widens the regex used to determine if a JAVAHEAP line is correct in
>> the output of System.map/System.dump_map.
>
> Hi,
> From our logs - existing passes on macos aarch64 include a line which
> matches, e.g.:
>
> 0x0007c800-
This fix widens the regex used to determine if a JAVAHEAP line is correct in
the output of System.map/System.dump_map.
-
Commit messages:
- widen JAVAHEAP regex again
Changes: https://git.openjdk.org/jdk/pull/23205/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23205&rang
On Mon, 23 Dec 2024 18:43:07 GMT, Simon Tooke wrote:
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to
On Thu, 9 Jan 2025 03:05:47 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test SystemMap with and without ZGC
>
> test/hotspot/jtreg/serviceability/dcmd/vm/System
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to the jtreg
> SystemMapTest.
Simon Tooke has updated the
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to the jtreg
> SystemMapTest.
Simon Tooke has updated the
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to the jtreg
> SystemMapTest.
Simon Tooke has updated the pull re
On Wed, 25 Dec 2024 00:26:30 GMT, Leonid Mesnik wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine jtreg tags per review
>
> test/hotspot/jtreg/serviceability/dcmd/vm/System
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to the jtreg
> SystemMapTest.
Simon Tooke has updated the
This test fixes an issue with incomplete Windows threads not yet having a
stack. A test for a null stack_base is added to guard against the potential
null dereference. An additional test using ZGC is added to the jtreg
SystemMapTest.
-
Commit messages:
- Merge branch 'pr_8346717
On Mon, 16 Dec 2024 10:17:06 GMT, Stefan Karlsson wrote:
> [JDK-8319875](https://bugs.openjdk.org/browse/JDK-8319875) updated jcmd
> System.map to support macOS but the tests are now failing on macosx-aarch64
> with ZGC.
>
> serviceability/dcmd/vm/SystemDumpMapTest.java
> serviceability/dcmd/v
On Wed, 11 Sep 2024 18:22:00 GMT, Simon Tooke wrote:
> This is a port of #16301 to macOS.
>
> System.map and System.dump_map are implemented using the macOS API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstu
On Thu, 12 Dec 2024 19:46:37 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 35 commits:
>>
>> - Merge branch 'openjdk:master' into pr_macos_
On Tue, 10 Dec 2024 12:28:12 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix crash due to uninitilized pointer
>
> BTW make sure you merge and test again befo
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 35 commits:
- Merge branch 'openjdk:master' into pr_mac
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
fix crash due to uninitilized pointer
-
Changes:
- all: https://git.op
On Mon, 9 Dec 2024 13:17:35 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add constant
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 49:
>
>> 47
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with two additional
commits since the last revision:
- whitespace error
- changes from revue
-
Changes:
- all: https:/
On Sat, 7 Dec 2024 08:34:45 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> combine like 128MB regions
>
> src/hotspot/os/bsd/memMapPrinte
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
add constant
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20953/fi
On Thu, 5 Dec 2024 17:45:06 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix trailing whitesdpae errors
>
> src/hotspot/os/bsd/memMapPrinter_macosx
On Thu, 5 Dec 2024 17:41:00 GMT, Thomas Stuefe wrote:
>>> @tstuefe I ran an experiment with raw mmap, and there's no way to
>>> differentiate between one large allocation of 5*128MB and 5 smaller
>>> allocations of 128MB. I _could_ add code to fold these, but we risk loosing
>>> information.
>
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
fix whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/209
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
combine like 128MB regions
-
Changes:
- all: https://git.op
On Thu, 5 Dec 2024 16:04:10 GMT, Thomas Stuefe wrote:
>>> @tstuefe I've look into your test, and I will modify the PR to display
>>> these regions - it was incorrectly identifying them as "free". As to the
>>> strange vmmap behaviour, I found that the two sections appeared in
>>> different pla
On Thu, 5 Dec 2024 14:32:53 GMT, Thomas Stuefe wrote:
>> Hi @stooke !
>>
>>> Hello, @tstuefe , and thanks for your comments. I'll address a few here
>>> while I work on the others. I have changed the os-specific names to
>>> lowercase, but I don't think it makes them stand out more. The square
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
fix trailing whitesdpae errors
-
Changes:
- all: https://git.op
On Mon, 2 Dec 2024 14:52:38 GMT, Thomas Stuefe wrote:
>> Hello, @tstuefe , and thanks for your comments. I'll address a few here
>> while I work on the others.
>> I have changed the os-specific names to lowercase, but I don't think it
>> makes them stand out more. The square brackets were int
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
latest cleanup, get rid of dll info
-
Changes:
- all: https://git.op
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
change format strings to display all digits properly
-
Changes:
- all:
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
some rework and fix core dump
-
Changes:
- all: https://git.op
t)
> [sample output using
> ZGC](https://github.com/user-attachments/files/17558067/zgc_map.txt)
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
lowercase tag names, display dll addresses
-
Changes:
- all: https:/
On Mon, 4 Nov 2024 14:04:58 GMT, Thomas Stuefe wrote:
>>> Looking good, small nits remain. Could you share an example output (maybe
>>> one run with G1, one with ZGC?)
>>
>> @tstuefe, Sample output for G1 and ZGC has been attached to the description
>> (and I fixed the ZGC test)
>
> Hi @stooke
- this PR adds the macOS
> implementation and enables the common code for macOS 64 bit.
>
> The System.map tests are also reworked to be cleaner for the three
> implementations.
>
> [Sample output](https://github.com/user-attachments/files/17517412/sample.txt)
Simo
On Tue, 29 Oct 2024 08:01:49 GMT, Thomas Stuefe wrote:
> Looking good, small nits remain. Could you share an example output (maybe one
> run with G1, one with ZGC?)
Sample output for G1 and ZGC has been attached to the description (and I fixed
the ZGC test)
-
PR Comment: https://
- this PR adds the macOS
> implementation and enables the common code for macOS 64 bit.
>
> The System.map tests are also reworked to be cleaner for the three
> implementations.
>
> [Sample output](https://github.com/user-attachments/files/17517412/sample.txt)
Simo
- this PR adds the macOS
> implementation and enables the common code for macOS 64 bit.
>
> The System.map tests are also reworked to be cleaner for the three
> implementations.
>
> [Sample output](https://github.com/user-attachments/files/17517412/sample.txt)
Simo
On Tue, 29 Oct 2024 08:01:13 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTes
- this PR adds the macOS
> implementation and enables the common code for macOS 64 bit.
>
> The System.map tests are also reworked to be cleaner for the three
> implementations.
>
> [Sample output](https://github.com/user-attachments/files/17517412/sample.txt)
Simo
On Tue, 29 Oct 2024 07:59:54 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 212:
>
>
On Tue, 29 Oct 2024 07:56:42 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 79:
>
>&
On Fri, 25 Oct 2024 15:09:18 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes from review
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 120:
>
>
- this PR adds the macOS
> implementation and enables the common code for macOS 64 bit.
>
> The System.map tests are also reworked to be cleaner for the three
> implementations.
>
> [Sample output](https://github.com/user-attachments/files/17517412/sample.txt)
Simo
This is a port of #16301 to macOS.
System.map and System.dump_map are implemented using the macOS API and provide
roughly the same information in the same format. Most of the heavy lifting was
implemented by @tstuefe in https://github.com/openjdk/jdk/pull/16301 - this PR
adds the macOS impleme
On Thu, 22 Aug 2024 18:36:39 GMT, Simon Tooke wrote:
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
&
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
clean up whitespace error
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2068
On Wed, 16 Oct 2024 00:03:32 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up test code
>
> Hi @stooke , I was away on vacation when you made the updates.
>
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
clean up comments per PR review
-
Changes:
- all: https://git.openjdk.org/jdk/
On Wed, 16 Oct 2024 00:02:13 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up test code
>
> test/hotspot/gtest/runtime/test_os.cpp line 413:
>
>
On Tue, 15 Oct 2024 23:52:35 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clean up test code
>
> test/hotspot/gtest/runtime/test_os.cpp line 422:
>
>>
On Mon, 23 Sep 2024 02:13:33 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete commented out code
>
> Changes requested by dholmes (Reviewer).
Hello, @dholm
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
clean up test code
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20683/file
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
spelling mistake
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20683/file
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
odd github behaviour
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2068
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contai
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
remove accidently commited file
-
Changes:
- all: https://git.openjdk.org/jdk/
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
account for Windows behviour changes
-
Changes:
- all: https://gi
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
feedback from review
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2068
On Mon, 23 Sep 2024 02:01:47 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete commented out code
>
> test/hotspot/gtest/runtime/test_os.cpp line 442:
On Mon, 23 Sep 2024 01:59:01 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete commented out code
>
> test/hotspot/gtest/runtime/test_os.cpp line 434:
>
>
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
delete commented out code
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2068
gt; Please note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
fix realpath test on macOS
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Thu, 19 Sep 2024 04:27:54 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove tabs
>
> test/hotspot/gtest/runtime/test_os.cpp line 453:
>
>> 451:
On Thu, 19 Sep 2024 04:24:09 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove tabs
>
> test/hotspot/gtest/runtime/test_os.cpp line 433:
>
>> 431: e
On Wed, 18 Sep 2024 10:18:28 GMT, Simon Tooke wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::real
On Wed, 18 Sep 2024 03:59:36 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Define MAX_PATH if required
>
> test/hotspot/gtest/runtime/test_os.cpp line 386:
ase note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
remove tabs
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20683/files
-
ase note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contai
On Thu, 15 Aug 2024 13:45:16 GMT, Simon Tooke wrote:
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same forma
ase note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
fix realpath() test for POSIX
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Tue, 17 Sep 2024 13:17:49 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove trailing whitespace
>
> Thanks Thomas -
> It's understood what the info i
On Tue, 17 Sep 2024 09:24:12 GMT, Thomas Stuefe wrote:
>> Sorry if I'm holding this up. The reasoning did get confusing to me.
>>
>> We are not always good at documenting these commands. But at some point,
>> somebody among us will hopefully document them, or explain it to somebody
>> who wi
ase note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
Define MAX_PATH if required
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2068
ase note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
use MAX_PATH only
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20683/file
ase note that guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
added gtest for realpath
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2068
On Fri, 13 Sep 2024 05:57:13 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - remove empty line
>> - fix indentation
>> - fix missing return
On Wed, 11 Sep 2024 23:57:11 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1196:
>
On Thu, 12 Sep 2024 16:01:52 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove calls to fatal(), remove segment lengt output
>> - use nullptr ins
On Thu, 12 Sep 2024 19:43:53 GMT, Kevin Walls wrote:
>> Hello @kevinjwalls , and thank you for your review! I have attempted to
>> address your concerns with my use of 'fatal()' by replacing with a message
>> in the returned output and an assert().
>>
>> I have also adjusted the spacing of th
@tstuefe in #16301 - this PR adds the Windows
> implementation and enables the common code for Windows 64 bit.
>
> [Sample output (with NMT
> enabled)](https://github.com/user-attachments/files/16982072/sample_windows_map.txt)
Simon Tooke has updated the pull request incremental
@tstuefe in #16301 - this PR adds the Windows
> implementation and enables the common code for Windows 64 bit.
>
> [Sample output (with NMT
> enabled)](https://github.com/user-attachments/files/16982072/sample_windows_map.txt)
Simon Tooke has updated the pull request incremental
On Wed, 11 Sep 2024 14:57:08 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> Hi,
> Great to bring up a Windows version of this.
>
>
@tstuefe in #16301 - this PR adds the Windows
> implementation and enables the common code for Windows 64 bit.
>
> [Sample output (with NMT
> enabled)](https://github.com/user-attachments/files/16663332/vm_memory_map_760.txt)
Simon Tooke has updated the pull request incrementall
On Thu, 5 Sep 2024 21:04:34 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - simplify windwos realpath() implementation
>> - get rid of os::posix::realpath() and
On Wed, 11 Sep 2024 14:31:43 GMT, Julian Waters wrote:
>> Simon Tooke has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - remove empty line
>> - fix indentation
>> - fix missing return statement
&
On Wed, 11 Sep 2024 14:43:24 GMT, Simon Tooke wrote:
>> src/hotspot/os/windows/os_windows.cpp line 5330:
>>
>>> 5328: if (result == nullptr) {
>>> 5329: errno = ENAMETOOLONG;
>>> 5330: }
>>
>> This is a bit of an assumption. What
On Thu, 12 Sep 2024 00:47:21 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> properly test for buffer too small for path
>
> src/hotspot/os/posix/os_posix.cpp
hat guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with three additional
commits since the last revision:
- remove empty line
- fix indentation
- fix missing return statement
-
Changes:
- all: htt
hat guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with one additional
commit since the last revision:
properly test for buffer too small for path
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2068
On Wed, 11 Sep 2024 17:26:15 GMT, Thomas Stuefe wrote:
>> I was thinking about this - my original intent was to be fatal only on a
>> debug build, not release. I have added a message in the output, and changed
>> these to warnings (for both release and debug)
>
> I would prefer an assert here.
On Wed, 11 Sep 2024 14:59:52 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same informatio
On Wed, 11 Sep 2024 14:12:48 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - prevent VM crash on invalid jcmd
>> - changes from review
>
> src/hotspot/share
@tstuefe in #16301 - this PR adds the Windows
> implementation and enables the common code for Windows 64 bit.
>
> [Sample output (with NMT
> enabled)](https://github.com/user-attachments/files/16663332/vm_memory_map_760.txt)
Simon Tooke has updated the pull request incrementally wit
On Thu, 5 Sep 2024 21:03:56 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - simplify windwos realpath() implementation
>> - get rid of os::posix::realpath() and
hat guidelines for doing this appear in
> src/hotspot/share/runtime/os.hpp
Simon Tooke has updated the pull request incrementally with two additional
commits since the last revision:
- move os::realpath() to previous location
- move os::realpath() to previous location
-
Changes
On Tue, 10 Sep 2024 15:09:03 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix overly restrictive test
>
> I am not a Reviewer but this looks mostly good t
On Tue, 10 Sep 2024 15:03:41 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix overly restrictive test
>
> src/hotspot/os/windows/memMapPrinter
1 - 100 of 120 matches
Mail list logo
