On Tue, 21 Jan 2025 13:50:31 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> @kevinjwalls thanks for the suggestion. I wish I could duplicate your issue. >> I prefer to leave 'cow' in, as the goal of this test is to ensure System.map >> works, not to confirm the implementation of a specific garbage collector. >> That was the consensus reached when ZGC caused the first failure on macOS. > >> ....prefer to leave 'cow' in, as the goal of this test is to ensure >> System.map works, not to confirm the implementation of a specific garbage >> collector. That was the consensus reached when ZGC caused the first failure >> on macOS. > > Sure, it doesn't matter hugely. Presumably you intended to sanity-check the > output in reasonable detail, and that gives us the test we have. I don't > see any output so far where the cow lines for classes.jsa will happen, I > think the "p/a JAVAHEAP" lines will match and the test will remove that > regex, meaning success. But leaving it in is not a problem for me. @kevinjwalls thanks for looking at this - I'll submit it now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23205#issuecomment-2604853645
