On Wed, 11 Sep 2024 23:57:11 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1196:
>
>> 1194: void SystemDumpMapDCmd::execute(DCmdSource source, TRAPS) {
>> 1195: const char* name = _filename.value();
>> 1196: if (name == NULL || name[0] == 0) {
>
> Suggestion:
>
> if (name == nullptr ...
done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1758973435
