On Mon, 23 Sep 2024 01:59:01 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Simon Tooke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete commented out code > > test/hotspot/gtest/runtime/test_os.cpp line 434: > >> 432: #if defined(_WINDOWS) >> 433: EXPECT_TRUE(returnedBuffer == buffer); >> 434: EXPECT_TRUE(errno == 0); > > I thought we concluded you cannot guarantee that errno==0 after a successful > call? Agreed and deleted. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1791595967
