On Tue, 15 Oct 2024 23:52:35 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Simon Tooke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> clean up test code > > test/hotspot/gtest/runtime/test_os.cpp line 422: > >> 420: errno = 0; >> 421: const char* returnedBuffer = os::realpath(nosuchpath, buffer, >> sizeof(nosuchpath) - 2); >> 422: /* Returns ENOENT on Linux, ENAMETOOLONG on Windows */ > > Suggestion: > > /* Reports ENOENT on Linux, ENAMETOOLONG on Windows */ > > and similarly below. The difference is important, thanks - fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1803022082
