On Tue, 10 Sep 2024 15:03:41 GMT, Sonia Zaldana Calles <szald...@openjdk.org>
wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix overly restrictive test
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>
>> 96: out.put('r');
>> 97: } else {
>> 98: fatal("Unknown Windows memory state value: 0x%x",
>> mem_info.State);
>
> Small nit - indentation.
Fixed.
> src/hotspot/share/services/diagnosticCommand.hpp line 984:
>
>> 982: };
>> 983:
>> 984: #if defined(LINUX) || defined(_WIN64)
>
> We also need to update the description for the diagnostic commands.
> Currently, both `System.dump_map` and `System.map` state they're enabled for
> linux only.
A good catch - I'd already found this while preparing a macOS implementation.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1754554144
PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1754553340
