On Thu, 5 Sep 2024 21:04:34 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Simon Tooke has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - simplify windwos realpath() implementation >> - get rid of os::posix::realpath() and os::win32::realpath() > > src/hotspot/share/runtime/os.hpp line 672: > >> 670: >> 671: // A safe implementation of realpath which will not cause a buffer >> overflow if the resolved path >> 672: // is longer than PATH_MAX. > > Nit: remove leading space to align with text on previous line. done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1756918131
