On Thu, 25 May 2023 16:00:51 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Wed, 24 May 2023 15:14:26 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed dead code, accepted code style suggestions.
>
> src/java.base/share/classes/sun/security/provider/HSS.java lin
On Wed, 24 May 2023 16:22:55 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed dead code, accepted code style suggestions.
>
> src/java.base/share/classes/sun/security/provider/HSS.java lin
On Thu, 18 May 2023 19:11:32 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 18 May 2023 19:11:32 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 18 May 2023 19:11:32 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 18 May 2023 16:18:02 GMT, Andrey Turbanov wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More input checks.
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 410:
>
>> 408: fin
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Wed, 17 May 2023 20:01:26 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Wed, 17 May 2023 20:01:26 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Wed, 17 May 2023 11:15:41 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Mon, 15 May 2023 16:14:24 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Mon, 15 May 2023 09:30:04 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/SHA2.java line 51:
>>
>>> 49:
>>> 50: private static final int ITERATION = 64;
>>> 51: private static final int BLOCKSIZE = 64;
>>
>> I'm not sure if it's worth defining this. A
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Mon, 15 May 2023 09:45:10 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Fri, 12 May 2023 22:11:07 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed Length from HSSPublicKey, changed the handling of X509 encoded
>> keys in the factory, did some more beautifi
On Fri, 12 May 2023 14:27:18 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Thu, 11 May 2023 19:32:50 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reintroduced Length for HSSPublicKey, added more @Override annotations
>
> src/java.base/share/classes/sun/security/pr
On Thu, 11 May 2023 17:01:20 GMT, Sean Mullan wrote:
>> Yes, I also think with `writeReplace` you can make `L` and `lmsPublicKey`
>> transient and there is no need to make `LMSPublicKey` serializable.
>
> `L` should be `transient` too as @wangweij noted.
Made L transient
-
PR Revi
On Thu, 11 May 2023 16:19:01 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reintroduced Length for HSSPublicKey, added more @Override annotations
>
> src/java.base/share/classes/sun/security/pr
On Thu, 11 May 2023 09:36:17 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 11 May 2023 16:33:25 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reintroduced Length for HSSPublicKey, added more @Override annotations
>
> src/java.base/share/classes/sun/security/pr
On Thu, 11 May 2023 09:36:17 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Tue, 9 May 2023 14:26:46 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 661:
>>
>>> 659:
>>> 660: @SuppressWarnings("deprecation")
>>> 661: HSSPublicKey(byte[] keyArray) throws InvalidKeyException {
>>
>> [I deleted my earlier comm
On Thu, 11 May 2023 09:36:17 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 11 May 2023 09:36:17 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 11 May 2023 09:36:17 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 11 May 2023 09:36:17 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Thu, 11 May 2023 06:02:01 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 571:
>>
>>> 569: preCandidate[21] = (byte) 0x80;
>>> 570:
>>> 571: byte[] preZi = hashBuf.clone();
>>
>> We can just call `hashbufSha256_32
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Wed, 10 May 2023 22:17:52 GMT, Weijun Wang wrote:
>> Done.
>
> There are much more in this class.
You are right. I have added many more. I hope I have found all of them.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1190885719
On Thu, 11 May 2023 06:27:39 GMT, Ferenc Rakoczi wrote:
> I had considered that and decided not to use it. In my opinion, Java Enum is
> much more complicated than it should be for this case.
OK.
> Efficiency is not a concern here
OK.
> but I also don't see how enum could be more efficient.
On Thu, 11 May 2023 06:14:10 GMT, Xue-Lei Andrew Fan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> serialization fixes, more code shaping
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 165:
On Wed, 10 May 2023 15:20:50 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Wed, 10 May 2023 22:11:09 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> serialization fixes, more code shaping
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 571:
>
>>
On Wed, 10 May 2023 15:20:50 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Wed, 10 May 2023 15:20:50 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Wed, 10 May 2023 15:15:55 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 47:
>>
>>> 45:
>>> 46: @Deprecated
>>> 47: protected void engineSetParameter(String param, Object value) {
>>
>> Better to add `@Override` as much as you can.
>
>
On Wed, 10 May 2023 15:20:50 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Wed, 10 May 2023 15:20:50 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request
On Tue, 9 May 2023 14:26:46 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 661:
>>
>>> 659:
>>> 660: @SuppressWarnings("deprecation")
>>> 661: HSSPublicKey(byte[] keyArray) throws InvalidKeyException {
>>
>> [I deleted my earlier comm
On Tue, 9 May 2023 14:37:36 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> agreeing with the newest review comments
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 47:
>
>>
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 9 May 2023 13:38:42 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> agreeing with the newest review comments
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 661:
>
>>
On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Mon, 8 May 2023 14:14:42 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Mon, 8 May 2023 16:38:01 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 528:
>>
>>> 526: // update()-digest() sequence) which is parametrized so that
>>> the digest output is copied back into this buffer.
>>> 527: // This way, we av
On Mon, 8 May 2023 20:14:01 GMT, Mark Powers wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 240:
>>
>>> 238: public final static int LMS_SHA256_M32_H20 = 8;
>>> 239: public final static int LMS_SHA256_M32_H25 = 9;
>>> 240: public final static in
On Thu, 4 May 2023 21:13:24 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Mon, 8 May 2023 16:29:49 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressing more review comments from @wangweij and @seanjmullan
>
> src/java.base/share/classes/sun/security/provider/H
On Mon, 8 May 2023 16:13:01 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressing more review comments from @wangweij and @seanjmullan
>
> src/java.base/share/classes/sun/security/provider/H
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Mon, 8 May 2023 16:24:27 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressing more review comments from @wangweij and @seanjmullan
>
> src/java.base/share/classes/sun/security/provider/H
On Mon, 8 May 2023 16:16:23 GMT, Weijun Wang wrote:
>> Ok. Try to keep your line lengths to about 80 chars.
>
> I think so too. This class is only used by tests now so it will not have any
> negative performance impact on real users. If we want to move it into the
> public one day then we don't
On Thu, 4 May 2023 21:24:16 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Mon, 8 May 2023 14:58:00 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Mon, 8 May 2023 14:58:00 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Mon, 8 May 2023 15:22:07 GMT, Sean Mullan wrote:
>> Yes, I think so. If someone wants to test with several different keys by
>> first creating RawKeySpec objects from an array in which a few bytes are
>> changed between the calls and and then use these KeySpecs to create the
>> actual keys,
On Mon, 8 May 2023 13:33:01 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/util/RawKeySpec.java line 37:
>>
>>> 35: */
>>> 36: public RawKeySpec(byte[] key) {
>>> 37: keyArr = key.clone();
>>
>> Does this need to be cloned if it is an internal class?
>
>
On Mon, 8 May 2023 13:32:38 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 823:
>>
>>> 821: index += siglist[i].sigArrayLength();
>>> 822: pubList[i] = new LMSPublicKey(sigArr, index,
>>> false);
>>> 823:
On Mon, 8 May 2023 14:58:00 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Mon, 8 May 2023 15:02:55 GMT, Ferenc Rakoczi wrote:
>> Without that, I get:
>>
>> /Users/ferakocz/dev/git-repos/jdk/open/src/java.base/share/classes/sun/security/provider/HSS.java:813:
>> warning: [deprecation] key in X509Key has been deprecated
>> key = new
>> DerOutputStream()
On Mon, 8 May 2023 13:32:29 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 745:
>>
>>> 743:
>>> 744: @Override
>>> 745: protected T engineGetKeySpec(Key key,
>>> Class keySpec) throws InvalidKeySpecException {
>>
>> Usually when
On Mon, 8 May 2023 14:10:54 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 796:
>>
>>> 794:
>>> 795: @Override
>>> 796: @SuppressWarnings("deprecation")
>>
>> Why do you need the `SuppressWarnings` annotation here?
>> `sun.util.Le
On Mon, 8 May 2023 13:32:21 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 94:
>>
>>> 92: result &= lmsVerify(lmsPubKey, sig.siglist[sig.Nspk],
>>> messageStream.toByteArray());
>>> 93: return result;
>>> 94: } catch
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Mon, 8 May 2023 12:38:36 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Mon, 8 May 2023 12:59:05 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Thu, 4 May 2023 20:00:18 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Fri, 5 May 2023 19:34:32 GMT, Sean Mullan wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/p
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 21:43:19 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request i
On Tue, 2 May 2023 20:48:37 GMT, Weijun Wang wrote:
>> Done.
>
> Where?
Done now. Sorry about it.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1183075152
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revisio
On Tue, 2 May 2023 20:45:38 GMT, Weijun Wang wrote:
>> Ferenc Rakoczi has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new comm
On Tue, 2 May 2023 20:32:33 GMT, Ferenc Rakoczi wrote:
>> Done
>
> Done.
Where?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1183036679
On Tue, 2 May 2023 20:33:40 GMT, Ferenc Rakoczi wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 213:
>>
>>> 211:
>>> 212: static class LMSUtils {
>>> 213: public final static int LMS_RESERVED = 0;
>>
>> Is the `LMS_RESERVED` and `LMOTS_RESERVED` constants
On Tue, 2 May 2023 20:44:27 GMT, Ferenc Rakoczi wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has refreshed the contents of
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
> SHA-256/192 parameters recommended.
Ferenc Rakoczi has refreshed the contents of this pull request, and previous
commits have been removed. The
1 - 100 of 113 matches
Mail list logo
