On Thu, 4 May 2023 21:13:24 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding key translation, finally block, removing 24-byte LMOTS parameters
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 181:
>
>> 179: try {
>> 180: lmParams = new LMParams(type);
>> 181: lmotsParams = LMOTSParams.of(otsType);
>
> Try to code `LMParams` and `LMOTSParams` the same style by choosing from
> using a constructor or static `of` method. Should `LMParams` be renamed to
> `LMSParams`?
Done.
> src/java.base/share/classes/sun/security/provider/HSS.java line 294:
>
>> 292: LMOTSignature(byte[] sigArray, LMOTSParams lmotsParams) throws
>> InvalidParameterException {
>> 293: int inLen = sigArray.length;
>> 294: if (inLen < 4)
>
> Add braces around the one-line block. Same as in lines 300, 173, 461, 472,
> 487, 569, 571, and 783.
Done
> src/java.base/share/classes/sun/security/provider/HSS.java line 357:
>
>> 355: break;
>> 356:
>> 357: /*
>
> Remove commented-out lines if they cannot be supported on time.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1188534977
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1188535603
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1188535363
