On Wed, 10 May 2023 22:11:09 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> serialization fixes, more code shaping > > src/java.base/share/classes/sun/security/provider/HSS.java line 571: > >> 569: preCandidate[21] = (byte) 0x80; >> 570: >> 571: byte[] preZi = hashBuf.clone(); > > We can just call `hashbufSha256_32.clone()` here. We'll think about what to > do when more params are supported in the future, together with the next line. hashBuf is assigned at the initialisation of the LMOTSParams object. If (when) we introduce more algorithms, the initialisation code and the digestFixedLengthPreprocessed() code needs to be changed only (its first parameter should be such that it can use the hash algorithm that the object would be initialised to use). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1190671593
