On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi <d...@openjdk.org> wrote:
>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
> agreeing with the newest review comments
src/java.base/share/classes/sun/security/provider/HSS.java line 101:
> 99: }
> 100:
> 101: static class LMSPublicKey implements Serializable {
Add a `writeReplace` method. Look at other `PublicKey` implementations for an
example.
src/java.base/share/classes/sun/security/provider/HSS.java line 540:
> 538: throw new ProviderException("Digest implementation not
> found", e);
> 539: }
> 540: byte[] result = new byte[md.getDigestLength()];
No need to allocate an array here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1188643495
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1188630397
