On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi <d...@openjdk.org> wrote:

>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC 
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with 
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   agreeing with the newest review comments

src/java.base/share/classes/sun/security/provider/HSS.java line 474:

> 472:                 sha256Fix = new SHA2.SHA256();
> 473:             } else {
> 474:                 sha256Fix = null;

Or, shall we throw a `ProviderException` or even an `AssertionError` here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1188613928

Reply via email to