On Mon, 8 May 2023 14:58:00 GMT, Ferenc Rakoczi <d...@openjdk.org> wrote:

>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC 
>> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with 
>> SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressing more review comments from @wangweij and @seanjmullan

src/java.base/share/classes/sun/security/provider/HSS.java line 106:

> 104:     }
> 105: 
> 106:     protected boolean lmsVerify(LMSPublicKey lmsPublicKey, LMSignature 
> sig, byte[] message) throws SignatureException {

We probably should put this method into an inner class and make it static.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1187644587

Reply via email to