On Mon, 8 May 2023 14:10:54 GMT, Ferenc Rakoczi <d...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/provider/HSS.java line 796:
>>
>>> 794:
>>> 795: @Override
>>> 796: @SuppressWarnings("deprecation")
>>
>> Why do you need the `SuppressWarnings` annotation here?
>> `sun.util.Length.length()` is not deprecated.
>
> Without that, I get:
>
> /Users/ferakocz/dev/git-repos/jdk/open/src/java.base/share/classes/sun/security/provider/HSS.java:813:
> warning: [deprecation] key in X509Key has been deprecated
> key = new
> DerOutputStream().putOctetString(keyArray).toByteArray();
> ^
Sorry, that one is if I remove another deprecation suppression. But the root
cause is the same here, without the message I get
/Users/ferakocz/dev/git-repos/jdk/open/src/java.base/share/classes/sun/security/provider/HSS.java:705:
warning: [deprecation] key in X509Key has been deprecated
return key.length * 8; // length in bits
^
error: warnings found and -Werror specified
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1187556505
