On Fri Aug 1, 2025 at 11:13 AM CEST, Shannon Sterz wrote:
> the find command previously also found the already migrated rrd files
> under `pve-{vm,node,storage}-9.0` and reported them as needing to
> migrate them. the provided command to would of course not migrate them
> so the warni
`pve2-` prefixed folders to prevent
that.
Signed-off-by: Shannon Sterz
---
PVE/CLI/pve8to9.pm | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 4d61cd831..834432b95 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9
On Thu Jul 31, 2025 at 3:56 PM CEST, Thomas Lamprecht wrote:
> On Thu, 31 Jul 2025 15:51:42 +0200, Friedrich Weber wrote:
>> Pressure stall information are actually in percent. This is not
>> mentioned explicitly in the documentation, but e.g. in the kernel
>> source [1]:
>>
>> > The percentage of
ecated name to the vm and took a snapshots with
"vm-" as well as "-vm" in the name, everything worked fine for me. so
consider this:
Tested-by: Shannon Sterz
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources
Signed-off-by: Shannon Sterz
---
changes since v1:
- instead of adapting how we set mirrors to the new deb822 format,
simply remove this code altogether in favor of using the cdn.
Proxmox/Install.pm | 6
On Thu Jul 31, 2025 at 11:00 AM CEST, Fabian Grünbichler wrote:
> On July 24, 2025 4:35 pm, Thomas Lamprecht wrote:
>> Am 24.07.25 um 12:11 schrieb Shannon Sterz:
>>> newer isos ship with new deb822 style repository configurations in
>>> `/etc/apt/sources.list.d/debian.s
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> In this series we:
-->8 snip 8<--
other than the nits i send, consider this:
Reviewed-by: Shannon Sterz
___
pve-devel mailing list
pve-devel@lists.proxmox.
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval
> ---
> ui/src/dashboard/top_entities.rs | 1 +
> ui/src/pve/qemu.rs | 2 ++
> ui/src/remotes/add_wizard.rs | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a/ui/src/d
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> In certain languages (e.g. spanish) CT and VM would have different
> genders, hence it is not possible to use the same string.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> www/manager6/dc/MetricServerView.js | 2 +-
> www/man
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval
> ---
> src/Utils.js| 2 ++
> src/panel/NotificationConfigView.js | 1 +
> src/window/ZFSDetail.js | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> These will be displayed in translator editors and provide context for
> translators.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> www/tape/DriveStatus.js | 1 +
> www/window/DataStoreEdit.js | 1 +
> www/window/S3ClientEdi
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> We error when the fields are empty, hence must is more appropiate.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> src/widget/form/field.rs| 2 +-
> src/widget/form/number.rs | 4 ++--
> src/widget/form/selector.rs | 2 +-
>
nonexistent snapshot states
here, as both `$parentsnap` and `$childsnap` would be undefined.
Signed-off-by: Shannon Sterz
---
consider this more of a suggestion, but the autovivification here made
this bug somewhat more annoying to debug and i don't really see a reason
not to check that
the name after the last underscore.
Use `[^\s_]` to match everything that is not a whitespace and not the
underscore character.
Signed-off-by: Shannon Sterz
---
src/PVE/Storage/LVMPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE
Superseeded-by:
https://lore.proxmox.com/pve-devel/20250729121151.159797-1-s.st...@proxmox.com/T/#u
On Tue Jul 29, 2025 at 11:41 AM CEST, Shannon Sterz wrote:
> zfs itself does not track the refquota per snapshot so we need handle
> this ourselves. otherwise rolling back a volume that ha
storage.
this implementation tries to do so by leveraging a user property per
snapshot.
Reported-by: Lukas Wagner
Suggested-by: Fabian Grünbichler
Signed-off-by: Shannon Sterz
Reviewed-by: Fiona Ebner
---
Notes:
keeping fiona's R-b from v2 as v3 basically just incorporate
Superseeded-by:
https://lore.proxmox.com/pve-devel/20250729094114.66153-1-s.st...@proxmox.com/T/#u
On Mon Jul 28, 2025 at 4:43 PM CEST, Shannon Sterz wrote:
> zfs itself does not track the refquota per snapshot so we need handle
> this ourselves. this implementation tries to do so by leve
storage.
this implementation tries to do so by leveraging a user property per
snapshot.
Reported-by: Lukas Wagner
Suggested-by: Fabian Grünbichler
Signed-off-by: Shannon Sterz
---
src/PVE/Storage/ZFSPoolPlugin.pm | 44 +++-
1 file changed, 43 insertions(+), 1
On Mon Jul 28, 2025 at 4:43 PM CEST, Shannon Sterz wrote:
> zfs itself does not track the refquota per snapshot so we need handle
> this ourselves. this implementation tries to do so by leveraging a
> user property per snapshot.
>
> Signed-off-by: Shannon Sterz
> ---
>
&
zfs itself does not track the refquota per snapshot so we need handle
this ourselves. this implementation tries to do so by leveraging a
user property per snapshot.
Signed-off-by: Shannon Sterz
---
this approach is not backward compatible, meaning that changes to volume
sizes between snapshot
newer isos ship with new deb822 style repository configurations in
`/etc/apt/sources.list.d/debian.sources`. make the installer set the
mirror in the correct file again.
Signed-off-by: Shannon Sterz
---
only did some rudimentary testing here, but fixing this up might be nice
in the long run
n PVE::Tools::file_read_firstline($pwfile);
> +my $contents = PVE::Tools::file_read_firstline($pwfile);
> +
> +return eval { decode('UTF-8', $contents, 1) } // $contents;
> }
>
> sub pbs_encryption_key_file_name {
other
he strings show
up in the *.po files and, thus, poedit, after running make do_update (to
avoid possibly resetting the submodules again). So consider all four
patches:
Reviewed-by: Shannon Sterz
Tested-by: Shannon Sterz
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
dedicated replication network
> +replication: secure,network=10.1.2.0/24
> +
>
> Command-line Interface Examples
> ---
looks good to me, so:
Reviewed-by: Shannon Sterz
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
sequioa dropped the `--binary` flag for keyring generation and only
outputs ascii armored keyrings. so make it dearmor the key afterward
to keep the key format consistent with the file ending (".gpg") again.
Signed-off-by: Shannon Sterz
---
aplinfo/Makefile | 4 +++-
1 file
would always output them in an armored
formart. gpgv cannot handle armored keys and would therefore fail to
verify signatures.
while sqv is pre-installed, adding it as an explicit dependency should
still avoid problems if it is removed at some point (like gpgv was).
Closes: #6539
Signed-off-by: Sh
previously the help button would disappear once either the
"Notifications" or "Retention" tabs was opened. this removes an
unnecessary extra container and sets the value for all tab so that the
help button stays present.
Signed-off-by: Shannon Sterz
---
this may look worse
Signed-off-by: Shannon Sterz
---
de.po | 139 ++
1 file changed, 52 insertions(+), 87 deletions(-)
diff --git a/de.po b/de.po
index 0166bb6..c5cbf65 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
sorry the list got dropped again :/
Forwarded message from Shannon Sterz on Fri Jul 18, 2025 at 10:39 AM:
On Thu Jul 17, 2025 at 7:27 PM CEST, Thomas Lamprecht wrote:
> Am 17.07.25 um 15:32 schrieb Shannon Sterz:
>> On Thu Jul 17, 2025 at 1:55 PM CEST, Thomas Lamprecht wrote:
>>&
so they better match the repository definitions above
Signed-off-by: Shannon Sterz
---
pve-package-repos.adoc | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc
index 063bc6f..a5b233a 100644
--- a/pve
so they better match the repository definitions above
Signed-off-by: Shannon Sterz
---
pve-package-repos.adoc | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc
index 063bc6f..9406e2f 100644
--- a/pve
On Thu Jul 17, 2025 at 11:38 AM CEST, Thomas Lamprecht wrote:
> (Cc'ing the pve-devel list again)
sorry about that
-# sha512sum /etc/apt/trusted.gpg.d/proxmox-release-trixie.gpg
-7da6fe34168adc6e479327ba517796d4702fa2f8b4f0a9833f5ea6e6b48f6507a6da403a274fe201595edc86a84463d50
so they better match the repository defintions above
Signed-off-by: Shannon Sterz
---
pve-package-repos.adoc | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc
index 063bc6f..4af8a51 100644
--- a/pve-package
fixes up some outdated uses of the old package repositories and adds a
bit more explanation for users trying to install the firmware package
Signed-off-by: Shannon Sterz
---
pve-package-repos.adoc | 12 ++--
pveceph.adoc | 2 +-
2 files changed, 11 insertions(+), 3 deletions
at
least 4 disks are required.
this is also inconsistent with the tui installer that will always
complain about the amount of disks not being correct.
Signed-off-by: Shannon Sterz
---
Proxmox/Install.pm | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/
On Mon Jul 14, 2025 at 2:41 PM CEST, Alexander Abraham wrote:
> The documentation on VM templates has been expanded and
> explanations added about advantages/disadvantages, how
> they can be worked with and how to create them.
generally we prefer commit message to use the present imperative. so:
On Mon Jul 14, 2025 at 10:38 AM CEST, Aaron Lauterer wrote:
> By printing the site and component, the person installing it manuall has
> a final check to see if the correct repository is being used.
>
> Signed-off-by: Aaron Lauterer
> ---
>
> Notes:
> I intially tried to get the repo definitio
On Fri Jul 4, 2025 at 8:20 PM CEST, Daniel Kral wrote:
> Add documentation about HA Resource Affinity rules, what effects those
> have on the CRS scheduler, and what users can expect when those are
> changed.
>
> There are also a few points on the rule conflicts/errors list which
> describe some co
On Wed Jun 11, 2025 at 1:37 PM CEST, Maximiliano Sandoval wrote:
> The catalog-{lang}.mo files are generated only with strings that are
> relevant to the proxmox-datacenter-manager instead of the whole
> {lang}.po file. The msgmerge command will produce all strings containing
> in the {lang}.po fil
On Mon Jun 2, 2025 at 4:14 PM CEST, Alexander Abraham wrote:
> A field for OIDC audiences was added, logic to handle these audiences,
> and the audiences supplied by an OIDC IDP are validated against
> the audiences a user saves in their realm domains
> configuration.
>
> Signed-off-by: Alexander A
On Mon Apr 28, 2025 at 4:03 PM CEST, Shan Shaji wrote:
> The `onPopInvoked` callback is deprecated as of
> Flutter v3.22.0-12.0.pre. This patch replaces it
> with the `onPopInvokedWithResult` callback.
>
> Signed-off-by: Shan Shaji
> ---
> lib/pages/main_layout_slim.dart | 2 +-
> lib/st
On Thu Apr 24, 2025 at 12:54 PM CEST, Shan Shaji wrote:
> Omit `devtools_options.yaml` file and generated dart files
> from source control.
>
> `devtools_options.yaml` file is a config file for storing the
> extension enablement states of flutter dev tools. By adding
> `devtools_options.yaml`
> as
this is mentioned in the `systemd.time(7)` manpage, but adding it here
to should give it more exposure. it's very handy and hopefully avoids
some frustration for users less familiar with calendar events.
Signed-off-by: Shannon Sterz
---
calendar-events.adoc | 5 +
1 file chang
On Tue Apr 8, 2025 at 4:39 PM CEST, Thomas Lamprecht wrote:
> Am 08.04.25 um 16:33 schrieb Shannon Sterz:
>> Signed-off-by: Shannon Sterz
>> ---
>> de.po | 226 +-
>> 1 file changed, 98 insertions(+), 128 deletion
Signed-off-by: Shannon Sterz
---
de.po | 226 +-
1 file changed, 98 insertions(+), 128 deletions(-)
diff --git a/de.po b/de.po
index 1c1965d..7339f83 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
Signed-off-by: Shannon Sterz
---
de.po | 226 +-
1 file changed, 98 insertions(+), 128 deletions(-)
diff --git a/de.po b/de.po
index 1c1965d..c291c2f 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
frr is already shipped as part of pve now and does not need to be
installed separatelly.
Signed-off-by: Shannon Sterz
---
pvesdn.adoc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 5d5d27b..86bf963 100644
--- a/pvesdn.adoc
+++ b
On Mon Mar 31, 2025 at 12:03 PM CEST, Fabian Grünbichler wrote:
> this has been the default for Debian since Bullseye[0].
>
> besides password setting for the PAM/PVE/PMG realms, this is also used
> to hash cloud-init passwords for Linux VMs, where only a subset of
> prefixes is currently allowed.
On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote:
> Add initial documentation for the openfabric and ospf options.
>
> Signed-off-by: Gabriel Goller
> ---
> pvesdn.adoc | 155
> 1 file changed, 155 insertions(+)
>
> diff --git a/pvesdn.
some manufacturer seem to report leading white space in the
`ID_SERIAL_SHORT` field. the regex failed here, as it just didn't
match the whitespace at all.
reported on the forum:
https://forum.proxmox.com/threads/nvme-drive-serial-unknown.163480/#post-754953
Signed-off-by: Shannon Sterz
---
On Fri Feb 28, 2025 at 3:01 PM CET, Stefan Hanreich wrote:
> ASNs are 32-bit unsigned integers where the maximum value is
> 4294967295.
>
> Signed-off-by: Stefan Hanreich
> ---
> src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
On Wed Mar 5, 2025 at 5:10 PM CET, Laurențiu Leahu-Vlăducu wrote:
> Hello everyone,
>
> I would need some feedback on a feature that was requested multiple
> times by different users over the years. Specifically, many people have
> complained that synchronizing Active Directory groups to PVE
> part
On Tue Mar 4, 2025 at 4:41 PM CET, Alexander Zeidler wrote:
> * ZFS: Restructure the sentence.
should this be XFS? you restructure a sentence about XFS/ext4 below, but
not ZFS
> * BTRFS: Explain the swap configuration options in a little more detail.
>
> Signed-off-by: Alexander Zeidler
> ---
>
On Tue Mar 4, 2025 at 4:41 PM CET, Alexander Zeidler wrote:
> * Introduce sections and subsections to enable better readability.
> * Move screenshots to their corresponding installation step and add
> blank lines for proper formatting.
>
> Notable changes:
>
> Step 1:
> * Since the EULA is only a
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote:
> * Describe what the installer does, this was earlier included in the
> installation introduction
> * Mention the importance of a redundant disk setup
> * s/CD-ROM/DVD/
> * Rephrase and expand the boot tip
>
> Signed-off-by: Alexander Z
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote:
> * Mention all currently available install options and link to them
> (interactive installer, unattended, on top of Debian)
> * Remove installer details and link to the installer, where the
> information will be included by a subseque
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote:
> * Consistently use "medium" (singular), as only one is needed for
> installation (filename "pve-installation-media.adoc" not renamed)
>
> * Revise the introduction:
> ** Remove CD-ROM (too little storage space) but keep DVD
> ** Copy t
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote:
> Signed-off-by: Alexander Zeidler
> ---
> pve-system-requirements.adoc | 29 -
> 1 file changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc
>
.
Signed-off-by: Shannon Sterz
---
pveum.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pveum.adoc b/pveum.adoc
index 81565ab..0cc267e 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -160,7 +160,7 @@ as an authentication protocol.
OpenID Connect::
-OpenID Connect is
On Thu Feb 27, 2025 at 11:00 AM CET, Thomas Lamprecht wrote:
> Am 27.02.25 um 10:42 schrieb Shannon Sterz:
>> this
>
> this what?
sent a v2 to fix this:
Superseeded-by:
https://lore.proxmox.com/pve-devel/20250304144927.235339-1-s.st...@proxmox.com/
>
>>
>>
On Thu Feb 27, 2025 at 11:00 AM CET, Thomas Lamprecht wrote:
> Am 27.02.25 um 10:42 schrieb Shannon Sterz:
>> this
>
> this what?
hm strange, sorry that seems to have gotten cut of:
this switches the use of OATH 2.0 to the correct spelling of OAuth 2.0.
it also makes it clear
this
Signed-off-by: Shannon Sterz
---
pveum.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pveum.adoc b/pveum.adoc
index 81565ab..0cc267e 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -160,7 +160,7 @@ as an authentication protocol.
OpenID Connect::
-OpenID
On Fri Jan 24, 2025 at 3:37 PM CET, Maximiliano Sandoval wrote:
> The catalog-{lang}.mo files are generated only with strings that are
> relevant to the proxmox-datacenter-manager instead of the whole
> {lang}.po file. The msgmerge command will produce all strings containing
> in the {lang}.po file
On Thu Feb 20, 2025 at 3:37 PM CET, Alexander Abraham wrote:
> The Flutter frontend of PVE was not compilable for Android
> with the versions of different tools set in the project files.
> The versions of the tools causing this problem was updated
> and the app compiles for Android.
>
> Signed-off-
otherwise, `volname.vmdk.raw` would be picked up as a `vmdk` formatted
image, which may not be desired.
Signed-off-by: Shannon Sterz
---
src/PVE/Storage/ESXiPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage
On Fri Nov 29, 2024 at 2:18 PM CET, Christian Ebner wrote:
> On 11/29/24 14:09, Shannon Sterz wrote:
> > On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote:
> >> Allow to select the change detection mode when performing manual
> >> backups of containers with Prox
On Fri Nov 29, 2024 at 2:08 PM CET, Christoph Heiss wrote:
> It's been the preferred mailing list archive for some time now.
>
> Signed-off-by: Christoph Heiss
> ---
> getting-help.adoc | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/getting-help.adoc b/getting-help.
On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote:
> Allow to select the change detection mode when performing manual
> backups of containers with Proxmox Backup Server as target, just like
> for the advanced backup job options introduced by commit 3b21f19f
> ("www: advanced backup: add pbs
On Tue Nov 26, 2024 at 11:21 AM CET, Thomas Lamprecht wrote:
> Am 26.11.24 um 10:27 schrieb Shannon Sterz:
> > actually i needed to adapt this to add support for attachments, which
> > require reworking the multipart logic a bit too. i can factor that out
> > into it's ow
Signed-off-by: Shannon Sterz
---
de.po | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/de.po b/de.po
index cec4e02..ae8195d 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-Version: proxmox translations\n&
Signed-off-by: Shannon Sterz
---
de.po | 71 +++
1 file changed, 27 insertions(+), 44 deletions(-)
diff --git a/de.po b/de.po
index fc4684f..4a7ea2a 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
On Mon Nov 25, 2024 at 11:19 PM CET, Thomas Lamprecht wrote:
> Am 25.11.24 um 11:22 schrieb Lukas Wagner:
>> Ping for patches 3-6, these were never applied.
>> They do not add any functional changes, but only aim to improve
>> code style and add some tests.
>>
>
>
> I applied them now, thanks!
>
>
On Thu Nov 21, 2024 at 3:28 PM CET, Maximiliano Sandoval wrote:
> Splitting translatable strings deprives translators for context which
> might be needed for getting the correct tenses or genders. See [1] for
> example.
>
> [1]
> https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Never(
Signed-off-by: Shannon Sterz
---
de.po | 206 +-
1 file changed, 87 insertions(+), 119 deletions(-)
diff --git a/de.po b/de.po
index c2284c1..5f987e2 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
On Tue Nov 19, 2024 at 12:58 PM CET, Maximiliano Sandoval wrote:
>
> Christian Ebner writes:
>
> > On 11/19/24 12:48, Maximiliano Sandoval wrote:
> >> Christian Ebner writes:
> >>
> >>> #: proxmox-widget-toolkit/src/Utils.js:315
> >>> -#, fuzzy
> >>> msgid "static"
> >>> -msgstr "Statico"
> >
On Tue Nov 19, 2024 at 12:55 PM CET, Christian Ebner wrote:
> On 11/19/24 12:48, Maximiliano Sandoval wrote:
> >
> > Christian Ebner writes:
> >
> >> #: proxmox-widget-toolkit/src/Utils.js:315
> >> -#, fuzzy
> >> msgid "static"
> >> -msgstr "Statico"
> >> +msgstr ""
> >
> > This translation is
-hashes',
> + deleteDefaultValue: false,
> + bind: {
> + hidden: '{!sevEnabled}',
> + disabled: '{!sevEnabled}',
> + },
> + },
> +],
> +});
> +
> +Ext.define('PVE.qemu.SevEdit', {
> +extend: 'Proxmox.window.Edit',
> +
> +subject: gettext('SEV'),
tiny nit: i think this falls into the same category as TFA and if we
don't translate that, we probably shouldn't translate SEV here either. i
also couldn't find any translations of this term on the internet, but
that's probably due to this feature being much more niche than TFA
> +
> +items: {
> + xtype: 'pveSevInputPanel',
> +},
> +
> +width: 400,
> +
> +initComponent: function() {
> + let me = this;
> +
> + me.callParent();
> +
> + me.load({
> + success: function(response) {
> + let conf = response.result.data;
> + let amd_sev = conf['amd-sev'] || '__default__';
> + me.setValues(PVE.Parser.parsePropertyString(amd_sev, 'type'));
> + },
> + });
> +},
> +});
With the two tiny nits, consider this:
Reviewed-by: Shannon Sterz
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Mon Nov 18, 2024 at 12:16 PM CET, Markus Frank wrote:
> add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV
> enable" patch.
>
> Signed-off-by: Markus Frank
> ---
> qm.adoc | 103
> 1 file changed, 103 insertions(+)
>
> d
these icons are multiply style because they seem to be handled
differently across products. so this in essence "double inverts" them
in the context where that is needed
Signed-off-by: Shannon Sterz
---
src/proxmox-dark/scss/other/_icons.scss | 7 +++
1 file changed, 7 insertion
On Tue Nov 12, 2024 at 10:16 AM CET, Dominik Csapak wrote:
> one comment inline
>
> On 11/11/24 12:35, Timothy Nicholson wrote:
> > Several strings that should probably also be translated now use
> > the gettext function to be translated.
> >
> > Signed-off-by: Timothy Nicholson
> > ---
> > [0]: h
On Fri Nov 8, 2024 at 12:30 PM CET, Moayad Almalat wrote:
>
> Allow four-octet MAC prefixes in Web UI validation
> update the MAC prefix validation in the Web UI to support four-octet
> prefixes.
>
> Signed-off-by: Moayad Almalat
> ---
> src/Toolkit.js | 2 +-
> 1 file changed, 1 insertion(+), 1
On Tue Oct 29, 2024 at 1:22 PM CET, Christoph Heiss wrote:
> The patch title implies that it only adds a utility function, but the
> patch itself also includes usage for it. Something like
>
> "fix #5787: ui: include guest name in confirmation dialog"
>
> or similar would probably be a better fit
when creating new users or updating existing passwords this new
minimum is enforced which aligns with NIST's latest recommendations
[1].
[1]: https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver
Signed-off-by: Shannon Sterz
---
src/PVE/API2/AccessControl.pm | 2 +-
src/PVE/API2/Us
so products can independently specify the minimum length of new
passwords
Signed-off-by: Shannon Sterz
---
src/window/PasswordEdit.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/window/PasswordEdit.js b/src/window/PasswordEdit.js
index bc54b8d..e012a0d 100644
this only impacts new passwords
Signed-off-by: Shannon Sterz
---
www/manager6/Workspace.js | 1 +
www/manager6/dc/UserEdit.js | 2 +-
www/manager6/dc/UserView.js | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index
this series pushes the minimum of 5 characters up to at least 8 for pve.
this puts our password policy in line with NIST's latest recommendation
[1].
[1]: https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver
pve-manager:
Shannon Sterz (1):
ui: workspace/user view: change pas
On Sun Sep 29, 2024 at 10:52 AM CEST, =?utf-8?B?SmFtZXMgQnJvd24=?= wrote:
> https://github.com/proxmox/pve-common/pull/11
Hi,
thanks for your contribution! Please note that the GitHub repositories
are read-only and we do not accept pull requests there. Would you mind
re-submitting the patches in
note that the gui's default is a bit "fake". it pre-sets the field to
`x86-64-v2-AES`, but if you click the little "x" next to it, the field
will be cleared and if you submit the form like that the default ends up
being `kvm64` again. this happens because the final config file does not
specify a cp
On Tue Jul 30, 2024 at 3:44 PM CEST, Igor Thaller wrote:
> The issue is related to the 'Summary' tab under 'Datacenter' inside a
> cluster. To get a steady reading of the storage size data, the frontend
> requests the '/api2/json/cluster/resources' every three seconds to
> retrieve the necessary da
On Mon Jul 29, 2024 at 5:19 PM CEST, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck
> ---
> v2:
> - added metadata_services config option
> - added Sysprep section
> - fixed typos and clarified some parts
>
> qm-cloud-init.adoc | 147 +
> 1 file c
On Mon Jul 29, 2024 at 12:25 PM CEST, Aaron Lauterer wrote:
>
>
> On 2024-07-26 14:22, Shannon Sterz wrote:
> > On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote:
> >> The new optional bridge_vids field allows to set that property via the
> >> GUI. Sinc
On Mon Jul 29, 2024 at 11:53 AM CEST, Theodor Fumics wrote:
> Split the "Add Virtual Machine" menu into separate options
> for Virtual Machines and Containers to reduce confusion.
> This change follows feedback from a user in [1], who had difficulty
> finding the container option.
>
> [1]
> https:
On Fri Jul 26, 2024 at 3:27 PM CEST, Theodor Fumics wrote:
> The SNAT option is only applicable to Simple and EVPN zone types.
> For other zone types, this field is irrelevant and can cause confusion.
> This commit hides the SNAT field when it is not applicable to the
> selected zone type, improvin
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
> changes since v2:
> * added checks to handle empty lists
>
> PVE/API2/Network.pm | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Network.pm b/PVE/AP
On Tue Jul 23, 2024 at 3:33 PM CEST, Aaron Lauterer wrote:
> Make clear that it affects only out-/inbound traffic and can be used if
> the underlying physical NICs support only a limited number of VLANs when
> offloading is possible.
>
> Signed-off-by: Aaron Lauterer
> ---
> After some off-list di
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote:
> This is one step to make it possible to define the VLAN IDs and ranges
> for bridges.
>
> It is expected to be used in combination with the `-list` magic
> property. Therefore it defines and checks the validity of a single list
> item tha
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote:
> The new optional bridge_vids field allows to set that property via the
> GUI. Since the backend needs to support it, the field needs to be
> explicitly enabled.
>
> For now, Proxmox VE (PVE) is the use case.
>
> Signed-off-by: Aaron Laute
ui: network: enable bridge_vids field
>
> PVE/API2/Network.pm | 15 ++-
> www/manager6/node/Config.js | 1 +
> 2 files changed, 15 insertions(+), 1 deletion(-)
thanks for this, i did a short review of the code. i have a couple of
minor issue, but other than that t
On Fri Jun 7, 2024 at 11:43 AM CEST, Jing Luo wrote:
> gcc warns (-Werror=type-limits) that it will always be false for the
> if statement. This is because here s->aid is defined as char, while
> proxmox_restore_open_image() returns an int. Change the type to int.
> Strangely gcc warns it on arm64
On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote:
> Signed-off-by: Daniel Krambrock
> ---
> src/PVE/Cluster.pm | 1 +
> src/PVE/DataCenterConfig.pm | 9 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
> index f899dbe..059c
1 - 100 of 102 matches
Mail list logo
