[pve-devel] [PATCH installer] install: set postfix config compatibility level to 3.6 to avoid warning

2025-08-05 Thread Shannon Sterz
otherwise postfix will complain about using a backward compatible config. since we don't seem to use anything that would be problematic here anyway [1], just bump the version to avoid spamming the logs. [1]: https://www.postfix.org/COMPATIBILITY_README.html Signed-off-by: Shannon

[pve-devel] [PATCH i18n] update german translation

2025-08-05 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 797 +++--- 1 file changed, 319 insertions(+), 478 deletions(-) diff --git a/de.po b/de.po index 9769afc..8808913 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

[pve-devel] [PATCH i18n] update german translation

2025-08-05 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 791 +++--- 1 file changed, 316 insertions(+), 475 deletions(-) diff --git a/de.po b/de.po index 7d0ecc8..d68ca22 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

Re: [pve-devel] [PATCH manager] fix #6599: ui: use font-awesome instead of png icons

2025-08-04 Thread Shannon Sterz
On Mon Aug 4, 2025 at 1:48 PM CEST, Fiona Ebner wrote: > Am 04.08.25 um 12:50 PM schrieb Shannon Sterz: >> previously we used custom png rendered icons for guests and storages >> in the add menu of a pool, as well as for mountpoints for containers. >> these appeared blur

[pve-devel] [PATCH manager] fix #6599: ui: use font-awesome instead of png icons

2025-08-04 Thread Shannon Sterz
font-awesome regardless, so there are no down-sides here. Signed-off-by: Shannon Sterz --- www/manager6/grid/PoolMembers.js | 4 ++-- www/manager6/lxc/Resources.js| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid

Re: [pve-devel] [PATCH manager] pve8to9: don't report already migrated files as needing to be migrated

2025-08-01 Thread Shannon Sterz
On Fri Aug 1, 2025 at 11:13 AM CEST, Shannon Sterz wrote: > the find command previously also found the already migrated rrd files > under `pve-{vm,node,storage}-9.0` and reported them as needing to > migrate them. the provided command to would of course not migrate them > so the warni

[pve-devel] [PATCH manager] pve8to9: don't report already migrated files as needing to be migrated

2025-08-01 Thread Shannon Sterz
`pve2-` prefixed folders to prevent that. Signed-off-by: Shannon Sterz --- PVE/CLI/pve8to9.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index 4d61cd831..834432b95 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9

Re: [pve-devel] applied: [PATCH manager] ui: RRD graphs: display PSI as percent

2025-07-31 Thread Shannon Sterz
On Thu Jul 31, 2025 at 3:56 PM CEST, Thomas Lamprecht wrote: > On Thu, 31 Jul 2025 15:51:42 +0200, Friedrich Weber wrote: >> Pressure stall information are actually in percent. This is not >> mentioned explicitly in the documentation, but e.g. in the kernel >> source [1]: >> >> > The percentage of

Re: [pve-devel] [PATCH storage 0/4] fix snapshot filename regressions

2025-07-31 Thread Shannon Sterz
ecated name to the vm and took a snapshots with "vm-" as well as "-vm" in the name, everything worked fine for me. so consider this: Tested-by: Shannon Sterz ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH installer v2] install: don't select a debian mirror based on the country anymore

2025-07-31 Thread Shannon Sterz
://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources Signed-off-by: Shannon Sterz --- changes since v1: - instead of adapting how we set mirrors to the new deb822 format, simply remove this code altogether in favor of using the cdn. Proxmox/Install.pm | 6

Re: [pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

2025-07-31 Thread Shannon Sterz
On Thu Jul 31, 2025 at 11:00 AM CEST, Fabian Grünbichler wrote: > On July 24, 2025 4:35 pm, Thomas Lamprecht wrote: >> Am 24.07.25 um 12:11 schrieb Shannon Sterz: >>> newer isos ship with new deb822 style repository configurations in >>> `/etc/apt/sources.list.d/debian.s

Re: [pve-devel] [PATCH backup/manager/pmg-gui/pmg-yew-quarantine-gui/proxmox-datacenter-manager/widget-toolkit/yew-mobile-gui/yew-widget-toolkit v2 00/16] Improve translatable strings

2025-07-30 Thread Shannon Sterz
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > In this series we: -->8 snip 8<-- other than the nits i send, consider this: Reviewed-by: Shannon Sterz ___ pve-devel mailing list pve-devel@lists.proxmox.

Re: [pve-devel] [PATCH proxmox-datacenter-manager v2 1/2] add context to translatable strings

2025-07-30 Thread Shannon Sterz
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > ui/src/dashboard/top_entities.rs | 1 + > ui/src/pve/qemu.rs | 2 ++ > ui/src/remotes/add_wizard.rs | 1 + > 3 files changed, 4 insertions(+) > > diff --git a/ui/src/d

Re: [pve-devel] [PATCH manager v2 2/3] improve some translatable strings

2025-07-30 Thread Shannon Sterz
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > In certain languages (e.g. spanish) CT and VM would have different > genders, hence it is not possible to use the same string. > > Signed-off-by: Maximiliano Sandoval > --- > www/manager6/dc/MetricServerView.js | 2 +- > www/man

Re: [pve-devel] [PATCH widget-toolkit v2 2/3] add context to translatable strings

2025-07-30 Thread Shannon Sterz
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > src/Utils.js| 2 ++ > src/panel/NotificationConfigView.js | 1 + > src/window/ZFSDetail.js | 1 + > 3 files changed, 4 insertions(+) > > diff --git a

Re: [pve-devel] [PATCH backup v2 1/3] add translators comments to some translations

2025-07-30 Thread Shannon Sterz
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > These will be displayed in translator editors and provide context for > translators. > > Signed-off-by: Maximiliano Sandoval > --- > www/tape/DriveStatus.js | 1 + > www/window/DataStoreEdit.js | 1 + > www/window/S3ClientEdi

Re: [pve-devel] [PATCH yew-widget-toolkit v2 1/1] improve translatable strings

2025-07-30 Thread Shannon Sterz
On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > We error when the fields are empty, hence must is more appropiate. > > Signed-off-by: Maximiliano Sandoval > --- > src/widget/form/field.rs| 2 +- > src/widget/form/number.rs | 4 ++-- > src/widget/form/selector.rs | 2 +- >

[pve-devel] [PATCH qemu-server 1/1] qemu-server: exit delete early if we cannot find a snapshot

2025-07-30 Thread Shannon Sterz
nonexistent snapshot states here, as both `$parentsnap` and `$childsnap` would be undefined. Signed-off-by: Shannon Sterz --- consider this more of a suggestion, but the autovivification here made this bug somewhat more annoying to debug and i don't really see a reason not to check that

[pve-devel] [PATCH pve-storage 1/1] fix #6587: parse snapshot names beginning from the first underscore

2025-07-30 Thread Shannon Sterz
the name after the last underscore. Use `[^\s_]` to match everything that is not a whitespace and not the underscore character. Signed-off-by: Shannon Sterz --- src/PVE/Storage/LVMPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE

Re: [pve-devel] [PATCH pve-storage v2] fix #6561: zfspool: track refquota for subvolumes via user properties

2025-07-29 Thread Shannon Sterz
Superseeded-by: https://lore.proxmox.com/pve-devel/20250729121151.159797-1-s.st...@proxmox.com/T/#u On Tue Jul 29, 2025 at 11:41 AM CEST, Shannon Sterz wrote: > zfs itself does not track the refquota per snapshot so we need handle > this ourselves. otherwise rolling back a volume that ha

[pve-devel] [PATCH pve-storage v3] fix #6561: zfspool: track refquota for subvolumes via user properties

2025-07-29 Thread Shannon Sterz
storage. this implementation tries to do so by leveraging a user property per snapshot. Reported-by: Lukas Wagner Suggested-by: Fabian Grünbichler Signed-off-by: Shannon Sterz Reviewed-by: Fiona Ebner --- Notes: keeping fiona's R-b from v2 as v3 basically just incorporate

Re: [pve-devel] [PATCH pve-storage] fix #6561: zfspool: track refquota for subvolumes via user properties

2025-07-29 Thread Shannon Sterz
Superseeded-by: https://lore.proxmox.com/pve-devel/20250729094114.66153-1-s.st...@proxmox.com/T/#u On Mon Jul 28, 2025 at 4:43 PM CEST, Shannon Sterz wrote: > zfs itself does not track the refquota per snapshot so we need handle > this ourselves. this implementation tries to do so by leve

[pve-devel] [PATCH pve-storage v2] fix #6561: zfspool: track refquota for subvolumes via user properties

2025-07-29 Thread Shannon Sterz
storage. this implementation tries to do so by leveraging a user property per snapshot. Reported-by: Lukas Wagner Suggested-by: Fabian Grünbichler Signed-off-by: Shannon Sterz --- src/PVE/Storage/ZFSPoolPlugin.pm | 44 +++- 1 file changed, 43 insertions(+), 1

Re: [pve-devel] [PATCH pve-storage] fix #6561: zfspool: track refquota for subvolumes via user properties

2025-07-28 Thread Shannon Sterz
On Mon Jul 28, 2025 at 4:43 PM CEST, Shannon Sterz wrote: > zfs itself does not track the refquota per snapshot so we need handle > this ourselves. this implementation tries to do so by leveraging a > user property per snapshot. > > Signed-off-by: Shannon Sterz > --- > &

[pve-devel] [PATCH pve-storage] fix #6561: zfspool: track refquota for subvolumes via user properties

2025-07-28 Thread Shannon Sterz
zfs itself does not track the refquota per snapshot so we need handle this ourselves. this implementation tries to do so by leveraging a user property per snapshot. Signed-off-by: Shannon Sterz --- this approach is not backward compatible, meaning that changes to volume sizes between snapshot

[pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

2025-07-24 Thread Shannon Sterz
newer isos ship with new deb822 style repository configurations in `/etc/apt/sources.list.d/debian.sources`. make the installer set the mirror in the correct file again. Signed-off-by: Shannon Sterz --- only did some rudimentary testing here, but fixing this up might be nice in the long run

Re: [pve-devel] [PATCH storage v2] fix #5181: pbs: store and read passwords as unicode

2025-07-23 Thread Shannon Sterz
n PVE::Tools::file_read_firstline($pwfile); > +my $contents = PVE::Tools::file_read_firstline($pwfile); > + > +return eval { decode('UTF-8', $contents, 1) } // $contents; > } > > sub pbs_encryption_key_file_name { other

Re: [pve-devel] [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by

2025-07-23 Thread Shannon Sterz
he strings show up in the *.po files and, thus, poedit, after running make do_update (to avoid possibly resetting the submodules again). So consider all four patches: Reviewed-by: Shannon Sterz Tested-by: Shannon Sterz ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH docs v2] pvesr: Document replication network setting

2025-07-23 Thread Shannon Sterz
dedicated replication network > +replication: secure,network=10.1.2.0/24 > + > > Command-line Interface Examples > --- looks good to me, so: Reviewed-by: Shannon Sterz ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/2] apl: make keyring generation output keys as binary again

2025-07-22 Thread Shannon Sterz
sequioa dropped the `--binary` flag for keyring generation and only outputs ascii armored keyrings. so make it dearmor the key afterward to keep the key format consistent with the file ending (".gpg") again. Signed-off-by: Shannon Sterz --- aplinfo/Makefile | 4 +++- 1 file

[pve-devel] [PATCH manager 1/2] fix #6539: apl: use sqv instead of gpgv to verify signatures

2025-07-22 Thread Shannon Sterz
would always output them in an armored formart. gpgv cannot handle armored keys and would therefore fail to verify signatures. while sqv is pre-installed, adding it as an explicit dependency should still avoid problems if it is removed at some point (like gpgv was). Closes: #6539 Signed-off-by: Sh

[pve-devel] [PATCH manager] fix #6534: ui: keep displaying help button in backup edit dialog

2025-07-18 Thread Shannon Sterz
previously the help button would disappear once either the "Notifications" or "Retention" tabs was opened. this removes an unnecessary extra container and sets the value for all tab so that the help button stays present. Signed-off-by: Shannon Sterz --- this may look worse

[pve-devel] [PATCH i18n] update German translation

2025-07-18 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 139 ++ 1 file changed, 52 insertions(+), 87 deletions(-) diff --git a/de.po b/de.po index 0166bb6..c5cbf65 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

[pve-devel] Fwd: Re: [PATCH docs] package-repos: update key file path and hashes

2025-07-18 Thread Shannon Sterz
sorry the list got dropped again :/ Forwarded message from Shannon Sterz on Fri Jul 18, 2025 at 10:39 AM: On Thu Jul 17, 2025 at 7:27 PM CEST, Thomas Lamprecht wrote: > Am 17.07.25 um 15:32 schrieb Shannon Sterz: >> On Thu Jul 17, 2025 at 1:55 PM CEST, Thomas Lamprecht wrote: >>&

[pve-devel] [PATCH docs] package-repos: update key file path and hashes

2025-07-18 Thread Shannon Sterz
so they better match the repository definitions above Signed-off-by: Shannon Sterz --- pve-package-repos.adoc | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc index 063bc6f..a5b233a 100644 --- a/pve

[pve-devel] [PATCH docs] package-repos: update key file path and hashes

2025-07-17 Thread Shannon Sterz
so they better match the repository definitions above Signed-off-by: Shannon Sterz --- pve-package-repos.adoc | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc index 063bc6f..9406e2f 100644 --- a/pve

Re: [pve-devel] [PATCH docs] package-repos: update key file path and hashes

2025-07-17 Thread Shannon Sterz
On Thu Jul 17, 2025 at 11:38 AM CEST, Thomas Lamprecht wrote: > (Cc'ing the pve-devel list again) sorry about that -# sha512sum /etc/apt/trusted.gpg.d/proxmox-release-trixie.gpg -7da6fe34168adc6e479327ba517796d4702fa2f8b4f0a9833f5ea6e6b48f6507a6da403a274fe201595edc86a84463d50

[pve-devel] [PATCH docs] package-repos: update key file path and hashes

2025-07-17 Thread Shannon Sterz
so they better match the repository defintions above Signed-off-by: Shannon Sterz --- pve-package-repos.adoc | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc index 063bc6f..4af8a51 100644 --- a/pve-package

[pve-devel] [PATCH docs] pveceph/package-repos: adapt further to new deb822 format

2025-07-16 Thread Shannon Sterz
fixes up some outdated uses of the old package repositories and adds a bit more explanation for users trying to install the firmware package Signed-off-by: Shannon Sterz --- pve-package-repos.adoc | 12 ++-- pveceph.adoc | 2 +- 2 files changed, 11 insertions(+), 3 deletions

[pve-devel] [PATCH installer] gui: don't assume 'single' btrfs mode if user selects exactely 1 disk

2025-07-16 Thread Shannon Sterz
at least 4 disks are required. this is also inconsistent with the tui installer that will always complain about the amount of disks not being correct. Signed-off-by: Shannon Sterz --- Proxmox/Install.pm | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/

Re: [pve-devel] [PATCH pve-docs] fix #4717: Expanded the section on VM templates

2025-07-14 Thread Shannon Sterz
On Mon Jul 14, 2025 at 2:41 PM CEST, Alexander Abraham wrote: > The documentation on VM templates has been expanded and > explanations added about advantages/disadvantages, how > they can be worked with and how to create them. generally we prefer commit message to use the present imperative. so:

Re: [pve-devel] [PATCH v2 3/3] pveceph: print repo metadata when installing from manual

2025-07-14 Thread Shannon Sterz
On Mon Jul 14, 2025 at 10:38 AM CEST, Aaron Lauterer wrote: > By printing the site and component, the person installing it manuall has > a final check to see if the correct repository is being used. > > Signed-off-by: Aaron Lauterer > --- > > Notes: > I intially tried to get the repo definitio

Re: [pve-devel] [PATCH docs v3 1/1] ha: add documentation about ha resource affinity rules

2025-07-08 Thread Shannon Sterz
On Fri Jul 4, 2025 at 8:20 PM CEST, Daniel Kral wrote: > Add documentation about HA Resource Affinity rules, what effects those > have on the CRS scheduler, and what users can expect when those are > changed. > > There are also a few points on the rule conflicts/errors list which > describe some co

Re: [pve-devel] [PATCH proxmox-i18n v3] make: add proxmox-datacenter-manager translations

2025-06-27 Thread Shannon Sterz
On Wed Jun 11, 2025 at 1:37 PM CEST, Maximiliano Sandoval wrote: > The catalog-{lang}.mo files are generated only with strings that are > relevant to the proxmox-datacenter-manager instead of the whole > {lang}.po file. The msgmerge command will produce all strings containing > in the {lang}.po fil

Re: [pve-devel] [PATCH proxmox v2 1/1] fix #5076: Added logic to handle OIDC audiences

2025-06-03 Thread Shannon Sterz
On Mon Jun 2, 2025 at 4:14 PM CEST, Alexander Abraham wrote: > A field for OIDC audiences was added, logic to handle these audiences, > and the audiences supplied by an OIDC IDP are validated against > the audiences a user saves in their realm domains > configuration. > > Signed-off-by: Alexander A

Re: [pve-devel] [PATCH pve_flutter_frontend] navigation: replace deprecated `onPopInvoked` callback

2025-04-29 Thread Shannon Sterz
On Mon Apr 28, 2025 at 4:03 PM CEST, Shan Shaji wrote: > The `onPopInvoked` callback is deprecated as of > Flutter v3.22.0-12.0.pre. This patch replaces it > with the `onPopInvokedWithResult` callback. > > Signed-off-by: Shan Shaji > --- > lib/pages/main_layout_slim.dart | 2 +- > lib/st

Re: [pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files

2025-04-24 Thread Shannon Sterz
On Thu Apr 24, 2025 at 12:54 PM CEST, Shan Shaji wrote: > Omit `devtools_options.yaml` file and generated dart files > from source control. > > `devtools_options.yaml` file is a config file for storing the > extension enablement states of flutter dev tools. By adding > `devtools_options.yaml` > as

[pve-devel] [PATCH docs] calendar-events: add a note about `systemd-analyze calendar`

2025-04-14 Thread Shannon Sterz
this is mentioned in the `systemd.time(7)` manpage, but adding it here to should give it more exposure. it's very handy and hopefully avoids some frustration for users less familiar with calendar events. Signed-off-by: Shannon Sterz --- calendar-events.adoc | 5 + 1 file chang

Re: [pve-devel] [PATCH i18n] update German translations

2025-04-08 Thread Shannon Sterz
On Tue Apr 8, 2025 at 4:39 PM CEST, Thomas Lamprecht wrote: > Am 08.04.25 um 16:33 schrieb Shannon Sterz: >> Signed-off-by: Shannon Sterz >> --- >> de.po | 226 +- >> 1 file changed, 98 insertions(+), 128 deletion

[pve-devel] [PATCH i18n v2] update German translations

2025-04-08 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 226 +- 1 file changed, 98 insertions(+), 128 deletions(-) diff --git a/de.po b/de.po index 1c1965d..7339f83 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

[pve-devel] [PATCH i18n] update German translations

2025-04-08 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 226 +- 1 file changed, 98 insertions(+), 128 deletions(-) diff --git a/de.po b/de.po index 1c1965d..c291c2f 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

[pve-devel] [PATCH docs] sdn: drop `frr` from packages required by the evpn controller

2025-04-07 Thread Shannon Sterz
frr is already shipped as part of pve now and does not need to be installed separatelly. Signed-off-by: Shannon Sterz --- pvesdn.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 5d5d27b..86bf963 100644 --- a/pvesdn.adoc +++ b

Re: [pve-devel] [PATCH common 1/2] encrypt_pw: allow yescrypt in addition to sha256

2025-03-31 Thread Shannon Sterz
On Mon Mar 31, 2025 at 12:03 PM CEST, Fabian Grünbichler wrote: > this has been the default for Debian since Bullseye[0]. > > besides password setting for the PAM/PVE/PMG realms, this is also used > to hash cloud-init passwords for Linux VMs, where only a subset of > prefixes is currently allowed.

Re: [pve-devel] [PATCH pve-docs 1/1] fabrics: add initial documentation for sdn fabrics

2025-03-31 Thread Shannon Sterz
On Fri Mar 28, 2025 at 6:13 PM CET, Gabriel Goller wrote: > Add initial documentation for the openfabric and ospf options. > > Signed-off-by: Gabriel Goller > --- > pvesdn.adoc | 155 > 1 file changed, 155 insertions(+) > > diff --git a/pvesdn.

[pve-devel] [PATCH pve-storage] dismanagement: account for leading white space in serial number

2025-03-12 Thread Shannon Sterz
some manufacturer seem to report leading white space in the `ID_SERIAL_SHORT` field. the regex failed here, as it just didn't match the whitespace at all. reported on the forum: https://forum.proxmox.com/threads/nvme-drive-serial-unknown.163480/#post-754953 Signed-off-by: Shannon Sterz ---

Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN

2025-03-11 Thread Shannon Sterz
On Fri Feb 28, 2025 at 3:01 PM CET, Stefan Hanreich wrote: > ASNs are 32-bit unsigned integers where the maximum value is > 4294967295. > > Signed-off-by: Stefan Hanreich > --- > src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [pve-devel] Strategy for Active Directory and OpenID Connect groups and usernames with spaces and other special characters

2025-03-06 Thread Shannon Sterz
On Wed Mar 5, 2025 at 5:10 PM CET, Laurențiu Leahu-Vlăducu wrote: > Hello everyone, > > I would need some feedback on a feature that was requested multiple > times by different users over the years. Specifically, many people have > complained that synchronizing Active Directory groups to PVE > part

Re: [pve-devel] [PATCH docs 7/7] installer: revise intro of advanced ZFS/BTRFS configuration options

2025-03-05 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:41 PM CET, Alexander Zeidler wrote: > * ZFS: Restructure the sentence. should this be XFS? you restructure a sentence about XFS/ext4 below, but not ZFS > * BTRFS: Explain the swap configuration options in a little more detail. > > Signed-off-by: Alexander Zeidler > --- >

Re: [pve-devel] [PATCH docs 6/7] installer: revise installation steps and introduce sections

2025-03-05 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:41 PM CET, Alexander Zeidler wrote: > * Introduce sections and subsections to enable better readability. > * Move screenshots to their corresponding installation step and add > blank lines for proper formatting. > > Notable changes: > > Step 1: > * Since the EULA is only a

Re: [pve-devel] [PATCH docs 4/7] installer: revise introduction

2025-03-05 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote: > * Describe what the installer does, this was earlier included in the > installation introduction > * Mention the importance of a redundant disk setup > * s/CD-ROM/DVD/ > * Rephrase and expand the boot tip > > Signed-off-by: Alexander Z

Re: [pve-devel] [PATCH docs 3/7] installation: revise introduction

2025-03-05 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote: > * Mention all currently available install options and link to them > (interactive installer, unattended, on top of Debian) > * Remove installer details and link to the installer, where the > information will be included by a subseque

Re: [pve-devel] [PATCH docs 2/7] installation: prepare medium: revise subchapter

2025-03-04 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote: > * Consistently use "medium" (singular), as only one is needed for > installation (filename "pve-installation-media.adoc" not renamed) > > * Revise the introduction: > ** Remove CD-ROM (too little storage space) but keep DVD > ** Copy t

Re: [pve-devel] [PATCH docs 1/7] system-requirements: revise subchapter and provide more details

2025-03-04 Thread Shannon Sterz
On Tue Mar 4, 2025 at 4:40 PM CET, Alexander Zeidler wrote: > Signed-off-by: Alexander Zeidler > --- > pve-system-requirements.adoc | 29 - > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc >

[pve-devel] [PATCH docs v2] pveum: switch OATH 2.0 to the correct OAuth 2.0; use pve not Proxmox

2025-03-04 Thread Shannon Sterz
. Signed-off-by: Shannon Sterz --- pveum.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 81565ab..0cc267e 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -160,7 +160,7 @@ as an authentication protocol. OpenID Connect:: -OpenID Connect is

Re: [pve-devel] [PATCH docs] pveum: switch OATH 2.0 to the correct OAuth 2.0; use pve not Proxmox

2025-03-04 Thread Shannon Sterz
On Thu Feb 27, 2025 at 11:00 AM CET, Thomas Lamprecht wrote: > Am 27.02.25 um 10:42 schrieb Shannon Sterz: >> this > > this what? sent a v2 to fix this: Superseeded-by: https://lore.proxmox.com/pve-devel/20250304144927.235339-1-s.st...@proxmox.com/ > >> >>

Re: [pve-devel] [PATCH docs] pveum: switch OATH 2.0 to the correct OAuth 2.0; use pve not Proxmox

2025-02-27 Thread Shannon Sterz
On Thu Feb 27, 2025 at 11:00 AM CET, Thomas Lamprecht wrote: > Am 27.02.25 um 10:42 schrieb Shannon Sterz: >> this > > this what? hm strange, sorry that seems to have gotten cut of: this switches the use of OATH 2.0 to the correct spelling of OAuth 2.0. it also makes it clear

[pve-devel] [PATCH docs] pveum: switch OATH 2.0 to the correct OAuth 2.0; use pve not Proxmox

2025-02-27 Thread Shannon Sterz
this Signed-off-by: Shannon Sterz --- pveum.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 81565ab..0cc267e 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -160,7 +160,7 @@ as an authentication protocol. OpenID Connect:: -OpenID

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-02-25 Thread Shannon Sterz
On Fri Jan 24, 2025 at 3:37 PM CET, Maximiliano Sandoval wrote: > The catalog-{lang}.mo files are generated only with strings that are > relevant to the proxmox-datacenter-manager instead of the whole > {lang}.po file. The msgmerge command will produce all strings containing > in the {lang}.po file

Re: [pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

2025-02-21 Thread Shannon Sterz
On Thu Feb 20, 2025 at 3:37 PM CET, Alexander Abraham wrote: > The Flutter frontend of PVE was not compilable for Android > with the versions of different tools set in the project files. > The versions of the tools causing this problem was updated > and the app compiles for Android. > > Signed-off-

[pve-devel] [PATCH pve-storage] esxi: anchor vmdk regex in `parse_volname`

2024-12-10 Thread Shannon Sterz
otherwise, `volname.vmdk.raw` would be picked up as a `vmdk` formatted image, which may not be desired. Signed-off-by: Shannon Sterz --- src/PVE/Storage/ESXiPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Shannon Sterz
On Fri Nov 29, 2024 at 2:18 PM CET, Christian Ebner wrote: > On 11/29/24 14:09, Shannon Sterz wrote: > > On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: > >> Allow to select the change detection mode when performing manual > >> backups of containers with Prox

Re: [pve-devel] [PATCH docs] getting-help: update mailing list links to lore.proxmox.com

2024-11-29 Thread Shannon Sterz
On Fri Nov 29, 2024 at 2:08 PM CET, Christoph Heiss wrote: > It's been the preferred mailing list archive for some time now. > > Signed-off-by: Christoph Heiss > --- > getting-help.adoc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/getting-help.adoc b/getting-help.

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Shannon Sterz
On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: > Allow to select the change detection mode when performing manual > backups of containers with Proxmox Backup Server as target, just like > for the advanced backup job options introduced by commit 3b21f19f > ("www: advanced backup: add pbs

Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys

2024-11-29 Thread Shannon Sterz
On Tue Nov 26, 2024 at 11:21 AM CET, Thomas Lamprecht wrote: > Am 26.11.24 um 10:27 schrieb Shannon Sterz: > > actually i needed to adapt this to add support for attachments, which > > require reworking the multipart logic a bit too. i can factor that out > > into it's ow

[pve-devel] [PATCH i18n] de: update translation

2024-11-28 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/de.po b/de.po index cec4e02..ae8195d 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxmox translations\n&

[pve-devel] [PATCH i18n] de: update translation

2024-11-27 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 71 +++ 1 file changed, 27 insertions(+), 44 deletions(-) diff --git a/de.po b/de.po index fc4684f..4a7ea2a 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys

2024-11-26 Thread Shannon Sterz
On Mon Nov 25, 2024 at 11:19 PM CET, Thomas Lamprecht wrote: > Am 25.11.24 um 11:22 schrieb Lukas Wagner: >> Ping for patches 3-6, these were never applied. >> They do not add any functional changes, but only aim to improve >> code style and add some tests. >> > > > I applied them now, thanks! > >

Re: [pve-devel] [PATCH] webhook edit: do not split translatable strings

2024-11-21 Thread Shannon Sterz
On Thu Nov 21, 2024 at 3:28 PM CET, Maximiliano Sandoval wrote: > Splitting translatable strings deprives translators for context which > might be needed for getting the correct tenses or genders. See [1] for > example. > > [1] > https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Never(

[pve-devel] [PATCH i18n] de: update translations

2024-11-19 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 206 +- 1 file changed, 87 insertions(+), 119 deletions(-) diff --git a/de.po b/de.po index c2284c1..5f987e2 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Shannon Sterz
On Tue Nov 19, 2024 at 12:58 PM CET, Maximiliano Sandoval wrote: > > Christian Ebner writes: > > > On 11/19/24 12:48, Maximiliano Sandoval wrote: > >> Christian Ebner writes: > >> > >>> #: proxmox-widget-toolkit/src/Utils.js:315 > >>> -#, fuzzy > >>> msgid "static" > >>> -msgstr "Statico" > >

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Shannon Sterz
On Tue Nov 19, 2024 at 12:55 PM CET, Christian Ebner wrote: > On 11/19/24 12:48, Maximiliano Sandoval wrote: > > > > Christian Ebner writes: > > > >> #: proxmox-widget-toolkit/src/Utils.js:315 > >> -#, fuzzy > >> msgid "static" > >> -msgstr "Statico" > >> +msgstr "" > > > > This translation is

Re: [pve-devel] [PATCH manager v13 5/5] ui: add AMD SEV configuration to Options

2024-11-18 Thread Shannon Sterz
-hashes', > + deleteDefaultValue: false, > + bind: { > + hidden: '{!sevEnabled}', > + disabled: '{!sevEnabled}', > + }, > + }, > +], > +}); > + > +Ext.define('PVE.qemu.SevEdit', { > +extend: 'Proxmox.window.Edit', > + > +subject: gettext('SEV'), tiny nit: i think this falls into the same category as TFA and if we don't translate that, we probably shouldn't translate SEV here either. i also couldn't find any translations of this term on the internet, but that's probably due to this feature being much more niche than TFA > + > +items: { > + xtype: 'pveSevInputPanel', > +}, > + > +width: 400, > + > +initComponent: function() { > + let me = this; > + > + me.callParent(); > + > + me.load({ > + success: function(response) { > + let conf = response.result.data; > + let amd_sev = conf['amd-sev'] || '__default__'; > + me.setValues(PVE.Parser.parsePropertyString(amd_sev, 'type')); > + }, > + }); > +}, > +}); With the two tiny nits, consider this: Reviewed-by: Shannon Sterz ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH docs v13 4/5] add AMD SEV documentation

2024-11-18 Thread Shannon Sterz
On Mon Nov 18, 2024 at 12:16 PM CET, Markus Frank wrote: > add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV > enable" patch. > > Signed-off-by: Markus Frank > --- > qm.adoc | 103 > 1 file changed, 103 insertions(+) > > d

[pve-devel] [PATCH widget-toolkit] dark theme: make icons in the permissions tree in pve dark

2024-11-15 Thread Shannon Sterz
these icons are multiply style because they seem to be handled differently across products. so this in essence "double inverts" them in the context where that is needed Signed-off-by: Shannon Sterz --- src/proxmox-dark/scss/other/_icons.scss | 7 +++ 1 file changed, 7 insertion

Re: [pve-devel] [PATCH manager] fix #5847: ui: gettextize several strings in ui

2024-11-12 Thread Shannon Sterz
On Tue Nov 12, 2024 at 10:16 AM CET, Dominik Csapak wrote: > one comment inline > > On 11/11/24 12:35, Timothy Nicholson wrote: > > Several strings that should probably also be translated now use > > the gettext function to be translated. > > > > Signed-off-by: Timothy Nicholson > > --- > > [0]: h

Re: [pve-devel] [PATCH proxmox-widget-toolkit] ui: mac-prefix-validation

2024-11-08 Thread Shannon Sterz
On Fri Nov 8, 2024 at 12:30 PM CET, Moayad Almalat wrote: > > Allow four-octet MAC prefixes in Web UI validation > update the MAC prefix validation in the Web UI to support four-octet > prefixes. > > Signed-off-by: Moayad Almalat > --- > src/Toolkit.js | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [pve-devel] [PATCH manager v2] fix #5787: ui: add util function for guest confirmation dialog

2024-10-29 Thread Shannon Sterz
On Tue Oct 29, 2024 at 1:22 PM CET, Christoph Heiss wrote: > The patch title implies that it only adds a utility function, but the > patch itself also includes usage for it. Something like > > "fix #5787: ui: include guest name in confirmation dialog" > > or similar would probably be a better fit

[pve-devel] [PATCH access-control 3/3] api: enforce a minimum length of 8 on new passwords

2024-10-04 Thread Shannon Sterz
when creating new users or updating existing passwords this new minimum is enforced which aligns with NIST's latest recommendations [1]. [1]: https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Shannon Sterz --- src/PVE/API2/AccessControl.pm | 2 +- src/PVE/API2/Us

[pve-devel] [PATCH widget-toolkit 2/3] password edit: add a minimum length parameter

2024-10-04 Thread Shannon Sterz
so products can independently specify the minimum length of new passwords Signed-off-by: Shannon Sterz --- src/window/PasswordEdit.js | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/window/PasswordEdit.js b/src/window/PasswordEdit.js index bc54b8d..e012a0d 100644

[pve-devel] [PATCH manager 1/3] ui: workspace/user view: change password minimum length to 8

2024-10-04 Thread Shannon Sterz
this only impacts new passwords Signed-off-by: Shannon Sterz --- www/manager6/Workspace.js | 1 + www/manager6/dc/UserEdit.js | 2 +- www/manager6/dc/UserView.js | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index

[pve-devel] [PATCH manager/widget-toolkit/access-control 0/3] enforce minimum of 8 characters on new passwords

2024-10-04 Thread Shannon Sterz
this series pushes the minimum of 5 characters up to at least 8 for pve. this puts our password policy in line with NIST's latest recommendation [1]. [1]: https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver pve-manager: Shannon Sterz (1): ui: workspace/user view: change pas

Re: [pve-devel] Fix UTF-8 encoding issue in Tools.pm

2024-10-02 Thread Shannon Sterz
On Sun Sep 29, 2024 at 10:52 AM CEST, =?utf-8?B?SmFtZXMgQnJvd24=?= wrote: > https://github.com/proxmox/pve-common/pull/11 Hi, thanks for your contribution! Please note that the GitHub repositories are read-only and we do not accept pull requests there. Would you mind re-submitting the patches in

Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES

2024-10-02 Thread Shannon Sterz
note that the gui's default is a bit "fake". it pre-sets the field to `x86-64-v2-AES`, but if you click the little "x" next to it, the field will be cleared and if you submit the form like that the default ends up being `kvm64` again. this happens because the final config file does not specify a cp

Re: [pve-devel] SPAM: [PATCH manager] ui: dc summary: fix calculation of shared storage size

2024-07-31 Thread Shannon Sterz
On Tue Jul 30, 2024 at 3:44 PM CEST, Igor Thaller wrote: > The issue is related to the 'Summary' tab under 'Datacenter' inside a > cluster. To get a steady reading of the storage size data, the frontend > requests the '/api2/json/cluster/resources' every three seconds to > retrieve the necessary da

Re: [pve-devel] [PATCH v2 docs] cloudinit: add Windows cloudbase-init section

2024-07-29 Thread Shannon Sterz
On Mon Jul 29, 2024 at 5:19 PM CEST, Mira Limbeck wrote: > Signed-off-by: Mira Limbeck > --- > v2: > - added metadata_services config option > - added Sysprep section > - fixed typos and clarified some parts > > qm-cloud-init.adoc | 147 + > 1 file c

Re: [pve-devel] [PATCH widget-toolkit v3] fix #3892: Network: add bridge vids field for bridge_vids

2024-07-29 Thread Shannon Sterz
On Mon Jul 29, 2024 at 12:25 PM CEST, Aaron Lauterer wrote: > > > On 2024-07-26 14:22, Shannon Sterz wrote: > > On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > >> The new optional bridge_vids field allows to set that property via the > >> GUI. Sinc

Re: [pve-devel] [PATCH manager] ui: pool: separate "Add Virtual Machine" menu into distinct options

2024-07-29 Thread Shannon Sterz
On Mon Jul 29, 2024 at 11:53 AM CEST, Theodor Fumics wrote: > Split the "Add Virtual Machine" menu into separate options > for Virtual Machines and Containers to reduce confusion. > This change follows feedback from a user in [1], who had difficulty > finding the container option. > > [1] > https:

Re: [pve-devel] [PATCH manager] sdn: subnets: hide irrelevant fields depending on zone type

2024-07-26 Thread Shannon Sterz
On Fri Jul 26, 2024 at 3:27 PM CEST, Theodor Fumics wrote: > The SNAT option is only applicable to Simple and EVPN zone types. > For other zone types, this field is irrelevant and can cause confusion. > This commit hides the SNAT field when it is not applicable to the > selected zone type, improvin

Re: [pve-devel] [PATCH manager v3 5/6] fix #3893: api: network: add bridge_vids parameter

2024-07-26 Thread Shannon Sterz
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > changes since v2: > * added checks to handle empty lists > > PVE/API2/Network.pm | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Network.pm b/PVE/AP

Re: [pve-devel] [PATCH widget-toolkit v3 7/6 follow-up] Network: add explanation for bridge vids field

2024-07-26 Thread Shannon Sterz
On Tue Jul 23, 2024 at 3:33 PM CEST, Aaron Lauterer wrote: > Make clear that it affects only out-/inbound traffic and can be used if > the underlying physical NICs support only a limited number of VLANs when > offloading is possible. > > Signed-off-by: Aaron Lauterer > --- > After some off-list di

  1   2   >