On Mon Nov 25, 2024 at 11:19 PM CET, Thomas Lamprecht wrote: > Am 25.11.24 um 11:22 schrieb Lukas Wagner: >> Ping for patches 3-6, these were never applied. >> They do not add any functional changes, but only aim to improve >> code style and add some tests. >> > > > I applied them now, thanks! > > btw. I totally forgot to mention today that Shannon might need these sendmail > stuff too for the internal tooling she works on, so maybe making this public, > or moving it to a micro-crate could indeed be worth it. > Copying such small stuff more than once is most of the time a good signal that > it might be nonetheless good to share it; but no hard feelings either way from > my side, I just wanted to note that use case before I forget it.
actually i needed to adapt this to add support for attachments, which require reworking the multipart logic a bit too. i can factor that out into it's own `proxmox-sendmail` crate or similar and make `proxmox-notify`'s sendmail endpoint use that too. if that's desired, i can send patches for that too. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
