On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> These will be displayed in translator editors and provide context for
> translators.
>
> Signed-off-by: Maximiliano Sandoval <m.sando...@proxmox.com>
> ---
> www/tape/DriveStatus.js | 1 +
> www/window/DataStoreEdit.js | 1 +
> www/window/S3ClientEdit.js | 2 ++
> 3 files changed, 4 insertions(+)
>
> diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js
> index 881bc1fdd..4405e4380 100644
> --- a/www/tape/DriveStatus.js
> +++ b/www/tape/DriveStatus.js
> @@ -335,6 +335,7 @@ Ext.define('PBS.TapeManagement.DriveStatusGrid', {
> if (!value) {
> return gettext('Dynamic');
> }
> + // TRANSLATORS: As in "fixed block size"
> return `${gettext('Fixed')} -
> ${Proxmox.Utils.format_size(value)}`;
> },
> },
> diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
> index b414bd4c0..e12fea09f 100644
> --- a/www/window/DataStoreEdit.js
> +++ b/www/window/DataStoreEdit.js
> @@ -229,6 +229,7 @@ Ext.define('PBS.DataStoreEdit', {
> },
> },
> {
> + // TRANSLATORS: As in "options of the prune operation"
> title: gettext('Prune Options'),
> xtype: 'pbsPruneInputPanel',
> cbind: {
> diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
> index f0a5efba8..ca70dbbb2 100644
> --- a/www/window/S3ClientEdit.js
> +++ b/www/window/S3ClientEdit.js
> @@ -57,6 +57,7 @@ Ext.define('PBS.window.S3ClientEdit', {
> xtype: 'proxmoxtextfield',
> name: 'port',
> fieldLabel: gettext('Port'),
> + // TRANSLATORS: this is a port number
> emptyText: gettext('default (443)'),
> cbind: {
> deleteEmpty: '{!isCreate}',
> @@ -80,6 +81,7 @@ Ext.define('PBS.window.S3ClientEdit', {
> xtype: 'proxmoxtextfield',
> name: 'region',
> fieldLabel: gettext('Region'),
> + // TRANSLATORS: this is a region code
nit: your indentation seems to use tabs here and spaces otherwise?
also i'd prefer something like "this is an S3 region code" just to
clarify this a bit further (region codes can be many things imo and you
don't necessarily have the context that this is relevant for the s3
datastores here)
> emptyText: gettext('default (us-west-1)'),
> cbind: {
> deleteEmpty: '{!isCreate}',
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
