On Fri Aug 1, 2025 at 11:13 AM CEST, Shannon Sterz wrote:
> the find command previously also found the already migrated rrd files
> under `pve-{vm,node,storage}-9.0` and reported them as needing to
> migrate them. the provided command to would of course not migrate them
> so the warning persisted even after the command was run.
>
> limit the find command to the old `pve2-` prefixed folders to prevent
> that.
>
> Signed-off-by: Shannon Sterz <s.st...@proxmox.com>
> ---
> PVE/CLI/pve8to9.pm | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
> index 4d61cd831..834432b95 100644
> --- a/PVE/CLI/pve8to9.pm
> +++ b/PVE/CLI/pve8to9.pm
> @@ -1880,7 +1880,17 @@ sub check_rrd_migration {
> };
> eval {
> run_command(
> - ['find', '/var/lib/rrdcached/db', '-type', 'f', '!',
> '-name', '*.old'],
> + [
> + 'find',
> + '/var/lib/rrdcached/db',
> + '-path',
> + '*pve2-*',
> + '-type',
> + 'f',
> + '!',
> + '-name',
> + '*.old',
> + ],
> outfunc => $count_occurences,
> noerr => 1,
> );
I guess this should have had the following added:
Reported-by: Friedrich Weber <f.we...@proxmoc.com>
Reported-by: Daniel Herzig <d.her...@proxmox.com>
as both have reported this issue independently from me
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
