note that the gui's default is a bit "fake". it pre-sets the field to
`x86-64-v2-AES`, but if you click the little "x" next to it, the field
will be cleared and if you submit the form like that the default ends up
being `kvm64` again. this happens because the final config file does not
specify a cpu type in this case and, hence, the old default is used for
compatability reasons.
so, this effectively removes the ability to set *no* cpu type via the
cli if i'm not mistaken. might be worth considering.
On Tue Oct 1, 2024 at 4:08 PM CEST, Maximiliano Sandoval wrote:
> This makes it so newly created VMs, e.g. with `qm create` will have the
> same default value as VMs created via the web UI.
>
> Signed-off-by: Maximiliano Sandoval <m.sando...@proxmox.com>
> ---
> I am not entirely sure if there is side-effect that I am not taking into
> account.
>
> PVE/API2/Qemu.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index d25a79fe..383218fd 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -1152,6 +1152,10 @@ __PACKAGE__->register_method({
> $conf->{vmgenid} = PVE::QemuServer::generate_uuid();
> }
>
> + if (!defined($param->{cpu})) {
> + $conf->{cpu} = 'x86-64-v2-AES';
> + }
> +
> my $machine_conf =
> PVE::QemuServer::Machine::parse_machine($conf->{machine});
> my $machine = $machine_conf->{type};
> if (!$machine || $machine =~ m/^(?:pc|q35|virt)$/) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
