On Sun, Feb 2, 2025 at 9:50 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Sawada-san,
>
> > I think it's a good idea to support it at least on HEAD. I've attached
> > a patch for that.
>
> +1. I've confirmed that pg_rewind and -R can't output dbname for now,
> and your patch allows to do it.
>
> Few
On Mon, Feb 03, 2025 at 02:18:21PM -0600, Sami Imseih wrote:
> I think we should just block Foreign tables as we do with
> partition tables. Attached patch does that.
Unless there's some existing way to specify a FREEZE option in the FDW API
(I assume there isn't), I agree with this.
> I was also
Hi Nisha.
Some review comments for patch v67-0001.
==
src/backend/replication/slot.c
ReportSlotInvalidation:
Please see my previous post [1] where I gave some reasons why I think
the _() macro should be used only for the *common* part of the hint
messages. If you agree, then the following c
On Tue, 2024-01-23 at 12:32 +0900, Michael Paquier wrote:
> Slightly off topic and while I don't forget about it.. Please find
> attached a copy of the patch posted around [1] to be able to define
> injection points with input arguments, so as it is possible to
> execute
> callbacks with values co
On Tue, 2025-02-04 at 12:50 +0900, Michael Paquier wrote:
> On Tue, Feb 04, 2025 at 09:21:49AM +0900, Michael Paquier wrote:
> > Being able to pass down some runtime states to a callback is
> > something
> > I've drafted a patch for, as of:
> > https://www.postgresql.org/message-id/z23zce4w1djuk...
Peter Eisentraut writes:
> During the developer meeting at FOSDEM last Thursday,
BTW, are there minutes available from that meeting? In past years
some notes have been posted on the wiki, but I'm failing to find
anything right now.
regards, tom lane
Pavel Stehule writes:
> Did you do some performance checks?
This is a good question to ask ...
> I tried some worst case
> CREATE OR REPLACE FUNCTION fx(int)
> RETURNS int AS $$
> SELECT $1 + $1
> $$ LANGUAGE SQL IMMUTABLE;
... but I don't think tests like this will give helpful answers.
That
On Mon, 3 Feb 2025 at 13:56, Aleksander Alekseev
wrote:
> > """
> > The status of this patch cannot be changed in this commitfest. You
> > must modify it in the one where it's open!
> > """
>
> Ooops, never mind.
I also thought that error was pretty silly. So it will be changed in
the next releas
po 3. 2. 2025 v 17:00 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > Did you do some performance checks?
>
> This is a good question to ask ...
>
> > I tried some worst case
>
> > CREATE OR REPLACE FUNCTION fx(int)
> > RETURNS int AS $$
> > SELECT $1 + $1
> > $$ LANGUAGE SQL IMMUTABLE;
Inlined the hex encode/decode functions in "src/include/utils/builtins.h"
similar to pg_popcount() in pg_bitutils.h.
---
Chiranmoy
v3-0001-SVE-support-for-hex-encode-and-hex-decode.patch
Description: v3-0001-SVE-support-for-hex-encode-and-hex-decode.patch
Hi Peter,
> prefix= should only be set when running the "install" target, not when
> building (make all).
I see. I confirm that works. Still, don’t all the other parameters work when
passed to any/all targets? Should this one have an extension-specific name?
>> So I suspect the issue is that,
Hi,
I was looking at COPY FREEZE and I found that it's
possible to run this command on a foreign table,
This really does not make sense as this
optimization cannot be applied to a remote table and it
can give a user a false impression that it was.
"""
postgres=# begin;
BEGIN
postgres=*# create fo
On Mon, Feb 03, 2025 at 12:45:24PM -0800, Jeff Davis wrote:
> A couple questions on the injection points framework:
>
> * The patch allows forcing the partition fan-out to one. I could
> imagine forcing it to a specific value, is there a way to do that?
>
> * The injection_points extension offers
Hi,
For each of the logging functions (see elog.c) there is an associated
XXX_internal function which is equivalent to its partner, but doesn't
translate the fmt message parameter.
errmsg
errmsg_internal - same as errmsg, but doesn't translate the fmt string
errdetail
errdetail_internal - same b
On Sun, Feb 02, 2025 at 10:38:32PM -0500, Tom Lane wrote:
> If I complain about it I gotta fix it, huh? Okay, done.
Thanks. :D
--
Michael
signature.asc
Description: PGP signature
On Mon, Feb 3, 2025 at 6:35 PM Shlok Kyal wrote:
>
> I reviewed the v66 patch. I have few comments:
>
> 1. I also feel the default value should be set to '0' as suggested by
> Vignesh in 1st point of [1].
>
+1. This will ensure that the idle slots won't be invalidated by
default, the same as HEAD
On Tue, Feb 4, 2025 at 4:02 AM Peter Smith wrote:
>
> On Mon, Feb 3, 2025 at 5:34 PM Amit Kapila wrote:
> >
> > On Mon, Feb 3, 2025 at 6:16 AM Peter Smith wrote:
> > >
> > >
> > > 2.
> > > + appendStringInfo(&err_hint, "You might need to increase \"%s\".",
> > > + "max_slot_wal_keep_size");
> >
Pavel Stehule writes:
> I did multiple benchmarking, and still looks so the proposed patch doesn't
> help and has significant overhead
Yeah, your fx() test case is clearly worse. For me,
HEAD:
regression=# do $$
begin
for i in 1..100 loop
perform fx((random()*100)::int); -- or fx2
On Mon, Feb 3, 2025 at 11:29 AM Alex Friedman wrote:
>
> Hi Sami,
>
> Thanks for the feedback.
>
> > 1/ Remove this as
> > "(50% of the maximum, which is about 20GB),"
> >
> > [1] tried to avoid explaining this level of detail, and I
> > agree with that.
>
> I feel it is critical for users to know
Hi,
Zhang Mingli
www.hashdata.xyz
On Feb 4, 2025 at 04:18 +0800, Sami Imseih , wrote:
>
> This really does not make sense as this
> optimization cannot be applied to a remote table and it
> can give a user a false impression that it was.
+1,
```
+ /*
+ * Raise an error on foreign tables as it's
I wrote:
> But wait: HEAD takes
> Time: 6632.709 ms (00:06.633)
> to do the same thing. So somehow the new-style SQL function
> stuff is very materially slower in this use-case, with or
> without this patch. I do not understand why.
"perf" tells me that in the fx3 test, a full third of the runti
On Mon, 2025-02-03 at 12:45 -0800, Jeff Davis wrote:
> * The patch allows forcing the partition fan-out to one. I could
> imagine forcing it to a specific value, is there a way to do that?
I hit "send" too quickly and this caused test failures in CI. Attaching
v2.
Changes:
* a new injection po
Hi Nikita,
On Wed, Dec 18, 2024 at 12:11 AM Nikita Malakhov wrote:
>
> Hi hackers!
>
> This thread is further work continued in [1], where Amit Langote
> suggested starting discussion on the remaining SQL/JSON feature
> 'PLAN clause for JSON_TABLE' anew.
>
> We'd like to help with merging SQL/JSO
Hi Nisha.
Some review comments for patch v1-0001
==
GENERAL - Missing Test case?
1.
Should there be some before/after test case for 'active_since' value
with invalid slots to verify that the patch is doing what it says?
==
src/backend/replication/slot.c
ReplicationSlotAcquire:
2.
I sa
On Tue, 28 Jan 2025 at 08:40, Ajin Cherian wrote:
>
> Here's a patch-set created based on the design changes proposed by Hou-san.
Few comments:
1) Shouldn't we do the same thing for other DecodeXXX functions?
@@ -915,6 +915,11 @@ DecodeInsert(LogicalDecodingContext *ctx,
XLogRecordBuffer *buf)
On Friday, January 31, 2025 9:43 PM Kuroda, Hayato/黒田 隼人
>
> Dear Ajin, Hou,
>
> > - Snapshot construction
>
> I understand the approach that we do not try to filter for all the workloads;
> do
> just best-effort.
>
> 3.
> Both ReorderBuffer and RelFileLocatorFilterCache have the same lifeti
> On 3 Feb 2025, at 23:18, Tom Lane wrote:
>
> But I don't want to think of
> EEOP_PARAM_CALLBACK as being specifically tied to PL/pgSQL.
I've found 1 users on Github [0]. And a lot of copied code like [1]. And there
might be some unindexed cases.
Let's keep paramarg2.
Best regards, Andrey
Attached is a patch that adds a few injection points for hash
aggregation.
A couple questions on the injection points framework:
* The patch allows forcing the partition fan-out to one. I could
imagine forcing it to a specific value, is there a way to do that?
* The injection_points extension of
I like the ntypes idea: please find attached version 3 which implements it.
I wrote it slightly differently as I did not want to leave any chance of it
escaping the if else blocks without a match.
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & T
On Mon, Feb 3, 2025 at 5:55 PM Alvaro Herrera wrote:
>
> On 2025-Feb-03, Ashutosh Bapat wrote:
>
> > ```
> > If the
> > constraint is NOT ENFORCED, the database system
> > will
> > not check the constraint. It is then up to the application code to
> > ensure that the cons
On Mon, Feb 3, 2025 at 1:07 PM Tom Lane wrote:
> As presented, I think this fails the translatability guideline
Thanks, good point. Please find attached a slightly more verbose version
that should be better for translations.
For myself, if we were going to do something like this, I'd kind of
On Sun, Feb 2, 2025 at 10:00 PM Peter Smith wrote:
>
> On Mon, Feb 3, 2025 at 4:50 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Sawada-san,
> >
> > > I think it's a good idea to support it at least on HEAD. I've attached
> > > a patch for that.
> >
> > +1. I've confirmed that pg_rewind and -R
Barring objections, I am planning to commit this one soon. I might move
the addition of analyze_delay_point() to its own patch, but otherwise I
think it looks good to go.
--
nathan
On Fri, Jan 31, 2025 at 03:23:56PM +0100, Jelte Fennema-Nio wrote:
> At the FOSDEM dev meeting we discussed potential improvements to the
> commitfest app and how to handle deploying future changes with minimal
> disruption to existing workflows. We're going to try a new approach:
> announcing a ne
On Mon, Feb 3, 2025 at 5:34 PM Amit Kapila wrote:
>
> On Mon, Feb 3, 2025 at 6:16 AM Peter Smith wrote:
> >
> >
> > 2.
> > + appendStringInfo(&err_hint, "You might need to increase \"%s\".",
> > + "max_slot_wal_keep_size");
> > break;
> > 2a.
> > In this case, shouldn't you really be using macr
Greg Sabino Mullane writes:
> I like the ntypes idea: please find attached version 3 which implements it.
> I wrote it slightly differently as I did not want to leave any chance of it
> escaping the if else blocks without a match.
Hmm, I was envisioning being a little more in-your-face about the
On Tue, Feb 4, 2025 at 8:37 AM Peter Smith wrote:
>
> Some review comments for patch v1-0001
>
> ==
> GENERAL - Missing Test case?
>
> 1.
> Should there be some before/after test case for 'active_since' value
> with invalid slots to verify that the patch is doing what it says?
>
I think the e
On Monday, February 3, 2025 8:03 PM Nisha Moond
wrote:
>
> Hi Hackers,
> (CC people involved in the earlier discussion)
>
> Right now, it is possible for the 'inactive_since' value of an invalid
> replication
> slot to be updated multiple times, which is unexpected behavior.
> As suggested in
On Tue, Feb 04, 2025 at 09:21:49AM +0900, Michael Paquier wrote:
> Being able to pass down some runtime states to a callback is something
> I've drafted a patch for, as of:
> https://www.postgresql.org/message-id/z23zce4w1djuk...@paquier.xyz
Oops. I've posted an incorrect link here, I meant this
Dmitrii Bondar писал(а) 2025-01-29 16:53:
Hi, Hackers!
I was testing a connection pooler with `make installcheck` and noticed
that `check_foreign_key()` from the `refint` library reuses the same
cached plan for cascade `UPDATE`/`DELETE` operations. As a result, a
cascade `DELETE` is applied a
On Mon, Feb 03, 2025 at 12:17:27PM +0100, Daniel Gustafsson wrote:
> The numbers are quite outdated but the gist of it holds. If we speed it up
> serverside we need to counter that with a higher iteration count, and for a
> rogue client it's unlikely to matter since it wont use our code anyways.
>
On Mon, Feb 3, 2025 at 5:38 PM Tom Lane wrote:
> One problem with it is that while we can leave "List of ???" out of the
> set of translatable strings easily, we can't currently do that for the
> argument of pg_log_error because it's automatically a gettext trigger. I'd
> rather not burden trans
Peter Smith writes:
> I noticed today that there is no 'errhint_internal' function partner
> for the 'errhint' function.
> Now, it might seem that hints are always intended for user output so
> of course, you'll always want them translated...
Yeah, I think that was the reasoning. If it needs a
Greg Sabino Mullane writes:
> ... For this
> particular item, I'm still of the opinion that leaving it as "List of
> relations" is a pretty good default for some future somebody who forgets to
> update the lists of relation types. New types are certainly not going to
> happen often. Better "List o
Greg Sabino Mullane writes:
> I toyed with that for a bit, but as you say, without generating a ton of
> combinations to translate, we'd have to fall back on run-time
> constructions. Neither is ideal. I also realized that I almost never type
> "\dti". Very common for me are \d and \dt and \dv etc
HI Nathan
> I had the opportunity to bring this patch up for discussion at the
> developer meeting at FOSDEM PGDay last week [0]. We discussed a subset
> of the topics folks have already written about in this thread, and AFAICT
> there was general approval among the attendees for proceeding with t
hi.
just a quick response for v15.
the pg_restore man page says option --list as "List the table of
contents of the archive".
but
$BIN10/pg_restore --format=directory --list --file=1.sql dir10
also output the contents of "global.dat", we should not output it.
in restoreAllDatabases, we can do th
Hi,
On 2025-01-29 14:12:52 -0500, Melanie Plageman wrote:
> From 71f32189aad510b73d221fb0478ffd916e5e5dde Mon Sep 17 00:00:00 2001
> From: Melanie Plageman
> Date: Mon, 27 Jan 2025 12:23:00 -0500
> Subject: [PATCH v14] Eagerly scan all-visible pages to amortize aggressive
> vacuum
>
> Amortize
> Unless there's some existing way to specify a FREEZE option in the FDW API
> (I assume there isn't), I agree with this.
I am not aware of any way to do this either as postgres_fdw is simply
using libpq.
> > I was also looking at why we block a parent from COPY FREEZE[1], but
> Commit 5c9a551 a
On Mon, Feb 03, 2025 at 03:12:57PM -0500, Tom Lane wrote:
> Greg Sabino Mullane writes:
>> I toyed with that for a bit, but as you say, without generating a ton of
>> combinations to translate, we'd have to fall back on run-time
>> constructions. Neither is ideal. I also realized that I almost nev
I had the opportunity to bring this patch up for discussion at the
developer meeting at FOSDEM PGDay last week [0]. We discussed a subset
of the topics folks have already written about in this thread, and AFAICT
there was general approval among the attendees for proceeding with the
"hard cap" appr
On Thu, Jan 30, 2025 at 04:29:35PM +0100, Alvaro Herrera wrote:
> A bunch of people discussed this patch in today's developer meeting in
> Brussels. There's pretty much a consensus on using the verb REPACK
> CONCURRENTLY for this new command -- where unadorned REPACK would be
> VACUUM FULL, and we
At this point I am planning on withdrawing this patch
from the March commitfest. I don't think fixing the REINDEX
debug1 output makes a whole lot of sense. I still think more logging
for (CREATE|ALTER) (INDEX|TABLE) will be a good to have but there
needs to be more discussion about the best approac
Thank you for updated version! I agree for your version of the code.
On 02.02.2025 21:00, Alexander Korotkov wrote:
On Fri, Jan 31, 2025 at 4:31 PM Alena Rybakina
wrote:
I started reviewing at the patch and saw some output "ERROR" in the output of
the test and is it okay here?
SELECT * FROM
Hi Kirill
On 31.01.25 11:46, Kirill Gavrilov wrote:
> Sorry for the long silence. I fixed the indentation and a trailing
> whitespace. Should look fine now.
The patch applies cleanly, the documentation is clear, and all tests pass.
It is possible to change this new parameter session-wise, whic
On Mon, Feb 03, 2025 at 08:50:15AM +, Bertrand Drouvot wrote:
> === 6
>
> I'll also do some benchmark on my side.
So, I did some tests using:
c=1 && psql -c checkpoint -c 'select pg_switch_wal()' &&
pgbench -n -M prepared -c$c -j$c -f <(echo "SELECT
pg_logical_emit_message(true, 'test', rep
Hi.
1. Those are temp files on the destination node (where the logical
subscription exists and tablesync worker runs), not on the source. On the
source, it’s all clear.
2. No “spill” suffix/substring in the file names. I tried to look at the
content of these temp files, I I saw some text fragment
On Mon, Feb 03, 2025 at 03:11:48PM +0800, Zixuan Fu wrote:
> With this change, the performance improves by approximately **4x** (reducing
> execution time from 4ms to 1ms). The built-in PostgreSQL HMAC implementation
> does not support context reuse, and modifying it would require substantial
> cha
here's the whole version of delta patch
diff --git a/src/bin/pg_dump/pg_restore.c b/src/bin/pg_dump/pg_restore.c
index 42c4fe3ce2..90e6b71a50 100644
--- a/src/bin/pg_dump/pg_restore.c
+++ b/src/bin/pg_dump/pg_restore.c
@@ -84,7 +84,7 @@ static int restoreAllDatabases(PGconn *conn, const char
*dump
I initially intended to restrict the modification to the
scram_SaltedPassword(), but I'm unsure how to determine
whether the current implementation is OpenSSL.
Alternatively, could we modify pg_hmac_init() to allow `key=NULL`
in the native HMAC implementation, achieving semantics similar to
OpenSS
hi.
git clean -fdx && $BIN10/pg_dumpall --format=directory --file=dir10
$BIN10/pg_restore --format=directory --file=1.sql --verbose dir10 >
dir_format 2>&1
there is no "\connect dbname" command.
pipe 1.sql to psql will execute all the database dump into a single
database, which is not good.
we ne
> On 3 Feb 2025, at 02:56, Tom Lane wrote:
>
> I decided to see what would happen if we tried to avoid the code
> duplication in pl_funcs.c by making some "walker" infrastructure
> akin to expression_tree_walker. While that doesn't seem useful
> for the dump_xxx functions, it works very nicel
Xuneng Zhou 于2025年1月8日周三 13:35写道：
> Hi Tender,
>
> I’ve looked through the patch, and I believe there is a potential issue.
> The default size for BufferDescriptors appears to be 16,384. Passing and
> casting a negative buffer ID to a large unsigned integer in
> GetBufferDescriptor, and then usin
On Mon, Feb 3, 2025 at 12:04 PM Amit Kapila wrote:
>
> On Mon, Feb 3, 2025 at 6:16 AM Peter Smith wrote:
> >
> >
> > 2.
> > + appendStringInfo(&err_hint, "You might need to increase \"%s\".",
> > + "max_slot_wal_keep_size");
> > break;
> > 2a.
> > In this case, shouldn't you really be using mac
On Wed, Jan 29, 2025 at 11:12 PM Peter Smith wrote:
>
> On Tue, Jan 28, 2025 at 9:26 PM Masahiko Sawada wrote:
> >
> > On Mon, Jan 27, 2025 at 7:01 PM Peter Smith wrote:
> > >
> ...
>
> > > To be honest, I didn't understand the "CLEAR" part of that name. It
> > > seems more like it should've bee
I wrote:
> Admittedly this is all moot unless some other extension starts
> using EEOP_PARAM_CALLBACK, and I didn't find any evidence of that
> using Debian Code Search. But I don't want to think of
> EEOP_PARAM_CALLBACK as being specifically tied to PL/pgSQL.
However ... given that I failed to f
On Thu, Jan 30, 2025 at 7:07 PM Peter Smith wrote:
>
> On Fri, Jan 31, 2025 at 11:04 AM Masahiko Sawada
> wrote:
> >
> > On Wed, Jan 29, 2025 at 9:32 PM Peter Smith wrote:
> > >
> > > ==
> > > .../replication/logical/reorderbuffer.c
> > >
> > > ReorderBufferCheckAndTruncateAbortedTXN:
> > >
> On 3 Feb 2025, at 08:45, Yura Sokolov wrote:
>
> 03.02.2025 10:11, Zixuan Fu пишет:
>> Hi Hackers,
>>
>> While profiling a program with `perf`, I noticed that `scram_SaltedPassword`
>> consumed more CPU time than expected. After some investigation, I found
>> that the function performs many
On 30.01.25 04:33, Mark Dilger wrote:
The previously committed patch (v19.1) already changed the gist strategy number
mapping to use the (Row)CompareType, as in Mark's proposal.
In this patch set, I'm attaching the existing standalone gist translate
function as the index AM API function for th
During the developer meeting at FOSDEM last Thursday, there was strong
consensus that we should no longer move patches to the next commitfest
in a semi-automatic, mechanical way, has commitfest managers have
traditionally done. Patches should only be moved forward by someone
involved in the pa
Dear Sawada-san,
> I'm concerned that users could be confused if two different names
> refer to substantially the same thing.
>
> Having said that, I guess that we need to drastically change the
> messages. For example, I think that the wal_level worker should say
> something like "successfully m
On Mon, Feb 3, 2025 at 1:20 PM Alvaro Herrera wrote:
>
> On 2025-Feb-03, Ashutosh Bapat wrote:
>
> > VALID, NOT ENFORCED changed to VALID, ENFORCED - data validation
> > required, constraint is enforced
>
> There's no such thing as a VALID NOT ENFORCED constraint. It just
> cannot exist.
The doc
> I've looked at it again and I think the code is correct, but I
> miswrote that the array needs to be sorted. The above query returns:
> x | y | nth_value
> ---+---+---
> 1 | 1 | 2
> 2 | 2 | 1
> 3 | | 2
> 4 | 4 |
> 5 | | 4
> 6 | 6 | 7
> 7
On Mon, Feb 3, 2025 at 12:22 PM Alena Rybakina
wrote:
>
> Thank you for updated version! I agree for your version of the code.
>
> On 02.02.2025 21:00, Alexander Korotkov wrote:
>
> On Fri, Jan 31, 2025 at 4:31 PM Alena Rybakina
> wrote:
>
> I started reviewing at the patch and saw some output "E
Hi Sami,
Thanks for the feedback.
> 1/ Remove this as
> "(50% of the maximum, which is about 20GB),"
>
> [1] tried to avoid explaining this level of detail, and I
> agree with that.
I feel it is critical for users to know what is the hard limit of
multixact members. As PG doesn't (yet) expose ho
Andrey Borodin writes:
> (Well, maybe paramarg2 resonates a bit, just from similarity with varchar2)
I'm not wedded to that name; do you have a better idea?
Another idea could be to make it an array:
-void *paramarg;/* private data for same */
+void *para
Please find attached a patch to enable more intuitive titles when using
psql and doing the following actions:
\dt \di \dv \dm \ds \dE
In other words, everything in listTables()
We still default to "List or relations", but if we know that the user has
requested exactly one specific type of relati
On Mon, Feb 3, 2025 at 5:14 PM jian he wrote:
>
> there is some corner like num_db_restore == 0, num_db_restore >= 100
> in that scarenio, the execute_global_sql_commands already executed,
> which is not ideal, since you have pg_fatal and some sql commands
> already executed.
> maybe we can be if
What's also suspicious is that on the destination node, after copying
finishes,
# explain select 1 from mytable;
Seq Scan on mytable (cost=0.00..6821514.12 rows=250410012 width=4)
# SELECT relname, n_live_tup FROM pg_stat_user_tables WHERE relname =
'mytable';
relname | estimated_rows
-
Hi Peter,
> CF 2025-01 has just ended, so I suggest that everyone try this now. We
> can check in perhaps two weeks whether this results in lots of stuff
> falling through the cracks or still too much stuff with unclear status
> being moved forward, and then see what that might mean going forward
Hi,
> This doesn't work unfortunately.
>
> When I try to move my patches from CF 2025-01 to CF 2025-03 I get an error:
>
> """
> The status of this patch cannot be changed in this commitfest. You
> must modify it in the one where it's open!
> """
Ooops, never mind. The application asked me to log
Pavel Borisov writes:
> Minor notes on the patches:
> If dump_* functions could use the newly added walker, the code would
> look better. I suppose the main complication is that dump_* functions
> contain a lot of per-statement prints/formatting. So maybe a way to
> implement this is to put these
Hi
I did multiple benchmarking, and still looks so the proposed patch doesn't
help and has significant overhead
testcase:
create or replace function fx(int) returns int as $$ select $1 + $1; $$
language sql immutable;
create or replace function fx2(int) returns int as $$ select 2 * $1; $$
langua
> On 3 Feb 2025, at 22:36, Tom Lane wrote:
>
> I'm not wedded to that name; do you have a better idea?
I'd propose something like attached. But feel free to ignore my suggestion: I
do not understand context of these structure members.
Best regards, Andrey Borodin.
rename.diff
Description:
Hi Ian,
On Thu, Dec 12, 2024 at 12:23 PM Ilyasov Ian wrote:
> SIGSEGV was caused by two places in pg_controldata.c where there
> is a work with localtime(&time_tmp));. So I added a check for not NULL.
>
>
>
> Where casting second operand in % (XLogSegmentsPerXLogId(wal_segsz_bytes)) to
> un
On Mon, 3 Feb 2025 at 14:23, Srinath Reddy wrote:
>
> Hi,
> I found a bug ,while using "./pg_restore pdd -f -" actually it has to copy
> everything(global sql commands + remaining dump ) into stdout as per the "-f,
> --file=FILENAME output file name (- for stdout)" but it is copying
> glob
Greg Sabino Mullane writes:
> Please find attached a patch to enable more intuitive titles when using
> psql and doing the following actions:
> \dt \di \dv \dm \ds \dE
> In other words, everything in listTables()
> We still default to "List or relations", but if we know that the user has
> request
Thank you for your comment. Sorry for being late.
SELECT FOR UPDATE SKIP LOCKED might skip a large number of rows,
leading to
a high volume of log messages from log_lock_failure in your current
patch.
Could this be considered unintended behavior? Would it be better to limit
the number of log
Good day,
Investigating some performance issues of a client, our engineers found
msgnumLock to be contended.
Looking closer it is obvious it is not needed at all: it used only as
memory barrier. It is even stated in comment at file start:
* We deal with that by having a spinlock that readers mus
On Mon, Feb 3, 2025 at 2:55 PM Amit Kapila wrote:
>
> On Fri, Jan 31, 2025 at 5:50 PM Nisha Moond wrote:
> >
> > Please find the attached v66 patch set. The base patch(v65-001) is
> > committed now, so I have rebased the patches.
> >
>
> *
>
> The time when the slot became inacti
Andrey Borodin writes:
>> On 3 Feb 2025, at 22:36, Tom Lane wrote:
>> I'm not wedded to that name; do you have a better idea?
> I'd propose something like attached. But feel free to ignore my suggestion: I
> do not understand context of these structure members.
Hmm, you're suggesting naming th
On 03.02.2025 14:32, Alexander Korotkov wrote:
On Mon, Feb 3, 2025 at 12:22 PM Alena Rybakina
wrote:
Thank you for updated version! I agree for your version of the code.
On 02.02.2025 21:00, Alexander Korotkov wrote:
On Fri, Jan 31, 2025 at 4:31 PM Alena Rybakina
wrote:
I started reviewi
On Fri, 31 Jan 2025 at 17:50, Nisha Moond wrote:
>
> On Fri, Jan 31, 2025 at 2:32 PM Amit Kapila wrote:
> >
> > On Fri, Jan 31, 2025 at 10:40 AM Peter Smith wrote:
> > >
> > > ==
> > > src/backend/replication/slot.c
> > >
> > > ReportSlotInvalidation:
> > >
> > > 1.
> > > +
> > > + case RS_I
Hi,
On Mon, 3 Feb 2025 at 11:50, Bertrand Drouvot
wrote:
>
> Hi,
>
> On Mon, Feb 03, 2025 at 01:07:26PM +0900, Michael Paquier wrote:
> > On Fri, Jan 31, 2025 at 11:29:31AM +0300, Nazir Bilal Yavuz wrote:
> > > On Wed, 29 Jan 2025 at 18:16, Bertrand Drouvot
> > > wrote:
> > >> I think that's the
03.02.2025 14:17, Daniel Gustafsson пишет:
>> On 3 Feb 2025, at 08:45, Yura Sokolov wrote:
>>
>> 03.02.2025 10:11, Zixuan Fu пишет:
>>> Hi Hackers,
>>>
>>> While profiling a program with `perf`, I noticed that `scram_SaltedPassword`
>>> consumed more CPU time than expected. After some investigat
Hi Hackers,
(CC people involved in the earlier discussion)
Right now, it is possible for the 'inactive_since' value of an invalid
replication slot to be updated multiple times, which is unexpected
behavior.
As suggested in the ongoing thread [1], this patch introduces a new
dedicated function to u
Hi,
Rebased the patch since it couldn't be applied anymore.
--
Regards,
--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.From 3f580c17214595eb8d6013674f5f054ec352ab7a Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi
Date: Mon, 3 Feb 2025 21:22:40 +0900
Subject: [PAT
Hi,
> >
> > Just idea; as an another option, how about blocking new requests to
> > the target process (e.g., causing them to fail with an error or
> > returning NULL with a warning) if a previous request is still
> pending?
> > Users can simply retry the request if it fails. IMO
Hi,
When a hot standby is restarted in a state where subtransactions have
overflowed, it may become inaccessible:
$ psql: error: connection to server at "localhost" (::1), port 5433
failed: FATAL: the database system is not yet accepting connections
DETAIL: Consistent recovery
On Mon, 3 Feb 2025 at 15:54, Alena Rybakina wrote:
>
>
> On 03.02.2025 14:32, Alexander Korotkov wrote:
>
> On Mon, Feb 3, 2025 at 12:22 PM Alena Rybakina
> wrote:
>
> Thank you for updated version! I agree for your version of the code.
>
> On 02.02.2025 21:00, Alexander Korotkov wrote:
>
> On Fr
1 - 100 of 125 matches
Mail list logo
