Re: pgcrypto support for bcrypt $2b$ hashes

On 02.10.2021 06:48, Daniel Fone wrote: > I don’t get these compiler warnings and I can’t find any settings to use that > might generate them. I’m compiling on macOS 11.6 configured with > `--enable-cassert --enable-depend --enable-debug CFLAGS=-O0` > Hi, Daniel! I don't get them from clang on m

Re: proposal: possibility to read dumped table's name from file

On 10/1/21 6:19 PM, Erik Rijkers wrote: On 10/1/21 3:19 PM, Daniel Gustafsson wrote: As has been discussed upthread, this format strikes a compromise wrt simplicity and doesn't preclude adding a more structured config file in the future should If you try to dump/restore a foreign file fro

Re: Deduplicate code updating ControleFile's DBState.

On Fri, Oct 01, 2021 at 05:47:45PM +, Bossart, Nathan wrote: > I'm inclined to agree that anything that calls update_controlfile() > should update the timestamp. pg_control.h tells that: pg_time_t time; /* time stamp of last pg_control update */ So, yes, that would be more consiste

Re: 2021-09 Commitfest

On Fri, Oct 01, 2021 at 08:29:08PM +0200, Daniel Gustafsson wrote: > Correct, if one looks at the activity log for an old entry the pattern of > moving to needs review, then to the next CF, then WoA is clearly visible. That's the tricky part. It does not really make sense either to keep moving pa

Re: Memory leak in pg_hmac_final

On Fri, Oct 01, 2021 at 10:58:07PM +0200, Daniel Gustafsson wrote: > Nice, I hadn't heard of that before but it seems quite neat. Thanks for the fix, it looks fine. I just saw the thread. Perhaps the commit log should have said that this only impacts non-OpenSSL builds. Worth noting that in ~13

Re: pgcrypto support for bcrypt $2b$ hashes

Hi Andreas, > On 1/10/2021, at 12:17 AM, Andreas Karlsson wrote: > > On 9/28/21 11:58 PM, Daniel Fone wrote: >>> On 29/09/2021, at 2:33 AM, Daniel Gustafsson wrote: >>> I don't see why not, the best first patches are those scratching an itch. >>> If >>> you feel up for it then give it a go, I

Re: Adding CI to our tree

On Sat, Oct 2, 2021 at 1:10 PM Andres Freund wrote: > On 2021-10-02 01:49:39 +0200, 0010203112132233 wrote: > > Furthermore, after looking it through, I think that Cirrus is an > > unfortunate choice as a CI platform of preference, as you cannot use > > it without access to Github (which is proble

Problem with CF app?

When I click the mail archive link (https://www.postgresql.org/message-id/flat/72a0d590d6ba06f242d75c2e64182...@postgrespro.ru) in CF app web page of this entry: https://commitfest.postgresql.org/34/3194/ I got: Error 503 Backend fetch failed Backend fetch failed Guru Meditation: XID: 83477623

Re: Adding CI to our tree

Hi, On 2021-10-02 01:49:39 +0200, 0010203112132233 wrote: > On Sat, 2 Oct 2021 at 00:28, Andres Freund wrote: > > New contributors (and quite a bit of older ones too) IMO expect to be able > > to > > see whether their changes work as-is, without sending a patch to the list. > > Have they checke

Re: Adding CI to our tree

On Fri, Oct 1, 2021 at 3:28 PM Andres Freund wrote: > For several development efforts I found it to be incredibly valuable to push > changes to a personal repository and see a while later whether tests succeed > on a number of different platforms. This is especially useful for platforms > that ar

Re: PATH manipulation in 001_libpq_pipeline.pl fails on windows

On 2021-10-01 17:37:11 -0300, Alvaro Herrera wrote: > On 2021-Oct-01, Andres Freund wrote: > > On 2021-10-01 14:07:42 -0400, Andrew Dunstan wrote: > > > But why are we mangling the PATH at all? Wouldn't it be better just to > > > call command_ok with "$ENV{TESTDIR}/libpg_pipeline" ? > > > > Yea, i

Re: BufferAlloc: don't take two simultaneous locks

On Fri, Oct 1, 2021 at 3:26 PM Yura Sokolov wrote: > Good day. > > I found some opportunity in Buffer Manager code in BufferAlloc > function: > - When valid buffer is evicted, BufferAlloc acquires two partition > lwlocks: for partition for evicted block is in and partition for new > block placeme

Adding CI to our tree

Hi, For several development efforts I found it to be incredibly valuable to push changes to a personal repository and see a while later whether tests succeed on a number of different platforms. This is especially useful for platforms that are quite different from ones own platform, like e.g. wind

BufferAlloc: don't take two simultaneous locks

Good day. I found some opportunity in Buffer Manager code in BufferAlloc function: - When valid buffer is evicted, BufferAlloc acquires two partition lwlocks: for partition for evicted block is in and partition for new block placement. It doesn't matter if there is small number of concurrent repl

Re: Enabling deduplication with system catalog indexes

On 9/30/21, 3:44 PM, "Peter Geoghegan" wrote: > On Wed, Sep 29, 2021 at 3:32 PM Peter Geoghegan wrote: >> I decided to run a simple experiment, to give us some idea of what >> benefits my proposal gives users: I ran "make installcheck" on a newly >> initdb'd database (master branch), and then wit

Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified

On 2021-Aug-13, David Christensen wrote: > Both bugs #16676[1] and #17141[2] illustrate that the combination of > SKIP LOCKED and FETCH FIRST WITH TIES break expectations when it comes > to rows returned to other sessions accessing the same row. Since this > situation is detectable from the synta

Re: parallelizing the archiver

On 10/1/21, 12:08 PM, "Andrey Borodin" wrote: > 30 сент. 2021 г., в 09:47, Bossart, Nathan написал(а): >> I tested the sample archive_command in the docs against the sample >> archive_library implementation in the patch, and I saw about a 50% >> speedup. (The archive_library actually syncs the f

Re: Memory leak in pg_hmac_final

> On 1 Oct 2021, at 14:31, Sergey Shinderuk wrote: > > On 01.10.2021 15:05, Daniel Gustafsson wrote: >>> On 1 Oct 2021, at 12:39, Sergey Shinderuk >>> wrote: >> >>> Here is a patch fixing the subject. >> >> Seems reasonable on a quick glance, the interim h buffer should be freed >> (this >>

Re: PATH manipulation in 001_libpq_pipeline.pl fails on windows

On 2021-Oct-01, Andres Freund wrote: > Hi, > > On 2021-10-01 14:07:42 -0400, Andrew Dunstan wrote: > > But why are we mangling the PATH at all? Wouldn't it be better just to > > call command_ok with "$ENV{TESTDIR}/libpg_pipeline" ? > > Yea, it probably would. Alvaro, I assume you don't mind if I

Re: SQL:2011 application time

On Sat, Sep 18, 2021 at 5:46 PM Corey Huinker wrote: > SYSTEM_TIME seems to allow for DATE values in the start_time and end_time > fields, > though I cannot imagine how that would ever be practical, unless it were > somehow > desirable to reject subsequent updates within a 24 hour timeframe. > I

Re: PATH manipulation in 001_libpq_pipeline.pl fails on windows

Hi, On 2021-10-01 14:07:42 -0400, Andrew Dunstan wrote: > But why are we mangling the PATH at all? Wouldn't it be better just to > call command_ok with "$ENV{TESTDIR}/libpg_pipeline" ? Yea, it probably would. Alvaro, I assume you don't mind if I change that? Greetings, Andres Freund

Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)

v13 (attached) contains several cosmetic updates and the full rename (comments included) of BufferAccessType and BufferType. On Thu, Sep 30, 2021 at 7:15 PM Alvaro Herrera wrote: > > Can you say more about 0001? > The rationale for this patch was that it doesn't save much to avoid initializing b

Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)

Em sex., 1 de out. de 2021 às 16:24, David Zhang escreveu: > On 2021-08-18 1:29 a.m., Kyotaro Horiguchi wrote: > > At Tue, 17 Aug 2021 17:04:44 +0900, Michael Paquier > wrote in > >> On Fri, Jul 02, 2021 at 06:22:56PM -0300, Ranier Vilela wrote: > >>> Em qui., 1 de jul. de 2021 às 17:20, Mahendr

Re: minor gripe about lax reloptions parsing for views

> On Oct 1, 2021, at 6:15 AM, Alvaro Herrera wrote: > > On 2021-Sep-30, Mark Dilger wrote: > >> The solution is simple enough: stop using HEAP_RELOPT_NAMESPACES when >> parsing reloptions for views and instead create a >> VIEW_RELOPT_NAMESPACES array which does not include "toast". > > It se

Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)

On 2021-08-18 1:29 a.m., Kyotaro Horiguchi wrote: At Tue, 17 Aug 2021 17:04:44 +0900, Michael Paquier wrote in On Fri, Jul 02, 2021 at 06:22:56PM -0300, Ranier Vilela wrote: Em qui., 1 de jul. de 2021 às 17:20, Mahendra Singh Thalor < mahi6...@gmail.com> escreveu: Please can we try to hit th

Re: parallelizing the archiver

> 30 сент. 2021 г., в 09:47, Bossart, Nathan написал(а): > > The attached patch is a first try at adding alternatives for > archive_command Looks like an interesting alternative design. > I tested the sample archive_command in the docs against the sample > archive_library implementation in th

Re: 2021-09 Commitfest

> On 1 Oct 2021, at 19:49, Jaime Casanova wrote: > On Fri, Oct 01, 2021 at 01:43:23PM -0400, Andrew Dunstan wrote: >> Isn't the usual procedure to change their status, move them, and then >> change it back again? ISTR something like that when I managed a CF. Correct, if one looks at the activity

Re: 2021-09 Commitfest

Jaime Casanova writes: > On Fri, Oct 01, 2021 at 01:43:23PM -0400, Andrew Dunstan wrote: >> Isn't the usual procedure to change their status, move them, and then >> change it back again? ISTR something like that when I managed a CF. > Really?! That sounds tedious! > I will do that but we should i

Re: PATH manipulation in 001_libpq_pipeline.pl fails on windows

On 9/30/21 5:40 PM, Andres Freund wrote: > Hi, > > For me 001_libpq_pipeline.pl doesn't reliably work on windows, because it > tries to add something to PATH, using unix syntax (vs ; used on windows). > > $ENV{PATH} = "$ENV{TESTDIR}:$ENV{PATH}"; > > If the first two elements in PATH are something

Re: parallelizing the archiver

On 9/29/21, 9:49 PM, "Bossart, Nathan" wrote: > I'm sure there are other ways to approach this, but I thought I'd give > it a try to see what was possible and to get the conversation started. BTW I am also considering the background worker approach that was mentioned upthread. My current thinkin

Re: 2021-09 Commitfest

On Fri, Oct 01, 2021 at 01:43:23PM -0400, Andrew Dunstan wrote: > > On 10/1/21 1:31 PM, Jaime Casanova wrote: > > On Fri, Oct 01, 2021 at 08:53:23AM -0500, Jaime Casanova wrote: > >> Anyway we need to advance to a close, so I need help with: > >> > >> - what should we do with WoA patches? moving t

Re: Deduplicate code updating ControleFile's DBState.

On 9/22/21, 10:03 PM, "Amul Sul" wrote: > On Tue, Sep 21, 2021 at 9:43 PM Bossart, Nathan wrote: >> Shouldn't we update the time in update_controlfile()? > > If you see the callers of update_controlfile() except for > RewriteControlFile() no one else updates the timestamp before calling > it, I a

Re: 2021-09 Commitfest

On 10/1/21 1:31 PM, Jaime Casanova wrote: > On Fri, Oct 01, 2021 at 08:53:23AM -0500, Jaime Casanova wrote: >> Anyway we need to advance to a close, so I need help with: >> >> - what should we do with WoA patches? moving them to the Next CF? > Correcting myself, we cannot move WoA patches. So we

Re: 2021-09 Commitfest

On Fri, Oct 01, 2021 at 01:34:45PM -0400, Tom Lane wrote: > Jaime Casanova writes: > > Correcting myself, we cannot move WoA patches. So we should just close > > them with RwF. > > Uh, really? I don't think that's been common practice in the past. > I thought we generally just pushed everything

Re: 2021-09 Commitfest

Jaime Casanova writes: > Correcting myself, we cannot move WoA patches. So we should just close > them with RwF. Uh, really? I don't think that's been common practice in the past. I thought we generally just pushed everything forward to the next CF with the same status.

Re: 2021-09 Commitfest

On Fri, Oct 01, 2021 at 08:53:23AM -0500, Jaime Casanova wrote: > > Anyway we need to advance to a close, so I need help with: > > - what should we do with WoA patches? moving them to the Next CF? Correcting myself, we cannot move WoA patches. So we should just close them with RwF. Barring obje

Re: [PATCH] ProcessInterrupts_hook

On Tue, Jun 29, 2021 at 01:32:26PM +0800, Craig Ringer wrote: > On Sat, 20 Mar 2021 at 03:46, Tom Lane wrote: > > > Robert Haas writes: > > > On Fri, Mar 19, 2021 at 3:25 PM Tom Lane wrote: > > >> I'm not very comfortable about the idea of having the postmaster set > > >> child processes' latch

Re: proposal: possibility to read dumped table's name from file

On 10/1/21 3:19 PM, Daniel Gustafsson wrote: As has been discussed upthread, this format strikes a compromise wrt simplicity and doesn't preclude adding a more structured config file in the future should we want that. I think this takes care of most comments and opinions made in this thread. -

Re: proposal: possibility to read dumped table's name from file

pá 1. 10. 2021 v 15:19 odesílatel Daniel Gustafsson napsal: > I took another pass over this today and touched up the documentation (docs > and > code) as well as tweaked the code a bit here and there to both make it fit > the > pg_dump style better and to clean up a few small things. I've also a

Re: shared-memory based stats collector

On Thu, Sep 02, 2021 at 10:20:50AM -0500, Jaime Casanova wrote: > On Mon, Jul 26, 2021 at 06:27:54PM -0700, Andres Freund wrote: > > Hi, > > > > On 2021-07-26 17:52:01 +0900, Kyotaro Horiguchi wrote: > > > > > Yeah, thank you very much for checking that. However, this patch is > > > > > now develo

VS2022: Support Visual Studio 2022 on Windows

During testing of the new Visual Studio 2022 Preview Version 4.1 from Microsoft I also tried PG14.0 on it. The x64 version built without error!. Even when this is only a preview version (the real thing is to expected soon) it seems appropriate to include the support to Postgres msvc tools dire

Re: Multi-Column List Partitioning

On Fri, Oct 1, 2021 at 6:56 AM Amit Langote wrote: > Hi, > > On Mon, Sep 13, 2021 at 7:17 PM Rajkumar Raghuwanshi > wrote: > > On PG head + Nitin's v3 patch + Amit's Delta patch. Make check is > failing with below errors. > > Thanks Rajkumar for testing. > > > --inherit.sql is failing with erro

RE: Failed transaction statistics to measure the logical replication progress

On Thursday, September 30, 2021 8:13 PM Amit Kapila wrote: > On Thu, Sep 30, 2021 at 1:02 PM Osumi, Takamichi/大墨 昂道 > wrote: > > > > On Thursday, September 30, 2021 1:15 PM Amit Kapila > wrote: > > > On Thu, Sep 30, 2021 at 8:22 AM Hou, Zhijie/侯 志杰 > > > wrote: > > > > > > > > On Tues, Sep 28,

Re: non-superusers are allowed to drop the replication user, but are not allowed to alter or even create them, is that ok?

> On Sep 30, 2021, at 9:26 PM, Ashutosh Sharma wrote: > > I'll take a look at this thread in detail to see if it addresses the issue > raised here. Although from the first email it seems like the proposal is > about allowing normal users to set some of the GUC params that can only be > set

Re: 002_types.pl fails on some timezones on windows

Andrew Dunstan writes: > On 9/30/21 3:38 PM, Tom Lane wrote: >> But are they running with the prevailing zone set to "Greenwich Standard >> Time"? > drongo's timezone is set to plain "UTC". > It also offers me "UTC+00:00(Dublin, Edinburgh, Lisbon, London)" and > "UTC+00:00(Monrovia, Reykjavik)"

Re: 002_types.pl fails on some timezones on windows

On 9/30/21 3:38 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 9/30/21 2:36 PM, Andres Freund wrote: >>> CI showed me a failure in 002_types.pl on windows. I only just now noticed >>> that because the subscription tests aren't run by any of the vcregress.pl >>> steps :( >> We have windows bu

Re: Numeric x^y for negative x

On Fri, Oct 01, 2021 at 07:56:33AM +0100, Dean Rasheed wrote: > On Thu, 30 Sept 2021 at 18:25, Jaime Casanova > wrote: > > > > Are you planning to commit this soon? > > > > Yes, I'll take a look at it next week. > Hi Dean, Great! I'll move the CF entry to the Next Commitfest so we can move to

Re: Using indexUnchanged with nbtree

On Fri, 1 Oct 2021 at 15:20, Jaime Casanova wrote: > This has been stalled since July, and based on Peter's comment i feel we > should mark this as RwF. Which i'm doing now. > > Please feel free to resubmit for Next Commitfest. Agreed, thank you Jaime. -- Simon Riggshttp://www.

Re: Using indexUnchanged with nbtree

On Thu, Jul 01, 2021 at 09:22:38AM -0700, Peter Geoghegan wrote: > On Thu, Jul 1, 2021 at 8:23 AM Simon Riggs > wrote: > > Definitely some good ideas here. > > I have been meaning to come up with some kind of solution to the > problem of "self-blocking" LP_DEAD bit setting within the > kill_prio

Re: Multi-Column List Partitioning

Hi, On Mon, Sep 13, 2021 at 7:17 PM Rajkumar Raghuwanshi wrote: > On PG head + Nitin's v3 patch + Amit's Delta patch. Make check is failing > with below errors. Thanks Rajkumar for testing. > --inherit.sql is failing with error :"ERROR: negative bitmapset member not > allowed" > update mlpa

Re: 2021-09 Commitfest

On Sat, Sep 11, 2021 at 12:52:10AM -0500, Jaime Casanova wrote: > On Wed, Sep 01, 2021 at 09:26:33AM -0500, Jaime Casanova wrote: > > On Wed, Sep 01, 2021 at 03:10:32PM +0200, Daniel Gustafsson wrote: > > > It is now 2021-09-01 Anywhere On Earth so I’ve set the September > > > commitfest to > > >

Re: pgsql: Document XLOG_INCLUDE_XID a little better

On Fri, Oct 1, 2021 at 8:53 AM Alvaro Herrera wrote: > I think a straight standalone variable (probably a static boolean in > xloginsert.c) might be less confusing. +1. > ... so, reading the xact.c code again, TransactionState->assigned really > means "whether the subXID-to-topXID association ha

Re: proposal: possibility to read dumped table's name from file

ng a more structured config file in the future should we want that. I think this takes care of most comments and opinions made in this thread. -- Daniel Gustafsson https://vmware.com/ pg_dump-filteropt-20211001.patch Description: Binary data

Re: minor gripe about lax reloptions parsing for views

On 2021-Sep-30, Mark Dilger wrote: > The solution is simple enough: stop using HEAP_RELOPT_NAMESPACES when > parsing reloptions for views and instead create a > VIEW_RELOPT_NAMESPACES array which does not include "toast". It seems a reasonable (non-backpatchable) change to me. > I've already fi

Re: 002_types.pl fails on some timezones on windows

Thomas Munro writes: >> Yes, it's been a while but IIRC Windows in the UK uses confusing >> terminology here even in user interfaces, so that in summer it appears >> to be wrong, which is annoying to anyone brought up on Eggert's >> system. The CLDR windowsZones.xml file shows this. BTW, on clos

Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified

On 2021-Oct-01, Michael Paquier wrote: > On Mon, Aug 30, 2021 at 03:55:10PM -0500, David Christensen wrote: > > On Mon, Aug 30, 2021 at 3:51 PM Alvaro Herrera > > wrote: > >> I think we should do this, given that it has show potential to bite > >> people. We should also add a small mentioned to

Re: pgsql: Document XLOG_INCLUDE_XID a little better

On 2021-Oct-01, Amit Kapila wrote: > AFAICS, there are two possibilities w.r.t global variables: (a) use > curinsert_flags which we are doing now, (b) another is to introduce a > new global variable, set it after we make the association, and then > reset it after we mark SubTransaction assigned an

Re: Atomic rename feature for Windows.

On Thu, Sep 30, 2021 at 11:00 PM Victor Spirin wrote: > > IsWindowsVersionOrGreater(10,0,1607) always returns false > > Only IsWindowsVersionOrGreater(10,0,0) is a valid call. (There are no > service packs in Windows 10.) > > I haven't found a way to determine the Windows 10 release ID. > The Rtl

Re: Memory leak in pg_hmac_final

On 01.10.2021 15:05, Daniel Gustafsson wrote: >> On 1 Oct 2021, at 12:39, Sergey Shinderuk wrote: > >> Here is a patch fixing the subject. > > Seems reasonable on a quick glance, the interim h buffer should be freed (this > is present since 14). I'll have another look at this in a bit and will

Re: Memory leak in pg_hmac_final

> On 1 Oct 2021, at 12:39, Sergey Shinderuk wrote: > Here is a patch fixing the subject. Seems reasonable on a quick glance, the interim h buffer should be freed (this is present since 14). I'll have another look at this in a bit and will take care of it. -- Daniel Gustafsson htt

Re: [EXTERNAL] Re: Add ETIMEDOUT to ALL_CONNECTION_FAILURE_ERRNOS

Jelte Fennema writes: > Personally, I would love to see this backpatched. Since together with a > second bug I reported[1] it's causing high query timeouts in Citus even if > tcp_user_timeout is set to a low value. I do understand your worry though. > Would a patch like the one I attached now b

Re: Warn if initdb's --sync-only option is mixed with other options

> On 7 Jul 2021, at 15:25, Daniel Gustafsson wrote: > I doubt it's worth complicating the code for this fringe case though. This thread has stalled, and with the updated docs/help output done for this option I don't think this is worth pursuing (especially given the lack of complaints over behav

Memory leak in pg_hmac_final

Hi, Here is a patch fixing the subject. Regards, -- Sergey Shinderukhttps://postgrespro.com/ diff --git a/src/common/hmac.c b/src/common/hmac.c index 1089db67443..bfe2e7cb5e9 100644 --- a/src/common/hmac.c +++ b/src/common/hmac.c @@ -232,7 +232,10 @@ pg_hmac_final(pg_hmac_ctx *c

Re: [WIP] UNNEST(REFCURSOR): allowing SELECT to consume data from a REFCURSOR

> On 29 Jul 2021, at 16:45, Daniel Verite wrote: > Trying the v7a patch, here are a few comments: This thread has stalled with no update or response to the above, and the patch errors out on make check for the plpgsql suite. I'm marking this Returned with Feedback, please resubmit an updated pa

Re: Improve join selectivity estimation using extended statistics

> On 19 Jul 2021, at 12:52, Ibrar Ahmed wrote: > The patch does not compile, and needs your attention. > > https://cirrus-ci.com/task/6397726985289728 > > > clausesel.c:74:28: error: too few arguments to function > ‘choose_best_statistics’ > Stati

Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

Em sex., 1 de out. de 2021 às 06:55, Artur Zakirov escreveu: > On Wed, Sep 22, 2021 at 1:12 AM Ranier Vilela wrote: > > Anyway, the v1 patch fixes only the expression eval. > > The patch looks good to me. > > It seems that initially the code looked similar to your patch. See the > commit b8d7f05

Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

On Wed, Sep 22, 2021 at 1:12 AM Ranier Vilela wrote: > Anyway, the v1 patch fixes only the expression eval. The patch looks good to me. It seems that initially the code looked similar to your patch. See the commit b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755. Then the variables were moved to foreach

Re: Logical replication keepalive flood

At Thu, 30 Sep 2021 17:07:08 +0530, Amit Kapila wrote in > On Thu, Sep 30, 2021 at 1:26 PM Kyotaro Horiguchi > wrote: > > If the comment describes the objective correctly, the only possible > > impact would be that there may be a case where server responds a bit > > slowly for a shutdown reques

Re: Toast compression method options

On Fri, Oct 1, 2021 at 12:42 PM Michael Paquier wrote: > > On Mon, Sep 13, 2021 at 05:10:22PM +0530, Dilip Kumar wrote: > > I haved rebased the patch. > > Please note that the patch does not apply. FWIW, I still don't think > that this is a good idea to have that. I don't recall seeing much on >

Re: Skipping logical replication transactions on subscriber side

On Fri, Oct 1, 2021 at 2:50 PM Amit Kapila wrote: > > On Fri, Oct 1, 2021 at 6:30 AM Masahiko Sawada wrote: > > > > On Fri, Oct 1, 2021 at 5:05 AM Peter Eisentraut > > wrote: > > > > > > Also, what happens when you forget to reset the xid after it has passed? > > > Will it get skipped again af

Re: Skipping logical replication transactions on subscriber side

On Fri, Oct 1, 2021 at 6:30 AM Masahiko Sawada wrote: > > On Fri, Oct 1, 2021 at 5:05 AM Peter Eisentraut > wrote: > > > > On 30.09.21 07:45, Masahiko Sawada wrote: > > > I've attached updated patches that incorporate all comments I got so > > > far. Please review them. > > > > I'm uneasy about t

Re: Logical replication keepalive flood

On Thu, Sep 30, 2021 at 5:56 PM Kyotaro Horiguchi wrote: > > After the patch applied, that keepalive is sent only when the loop is > actually going to sleep some time. In case the next WAL doesn't come > for KEEPALIVE_TIMEOUT milliseconds, it sends a keepalive. There's a > dubious behavior when s

Re: create table like: ACCESS METHOD

On Thu, Sep 09, 2021 at 02:30:51PM +0200, Peter Eisentraut wrote: > Hmm. The problem is that the LIKE clause is really a macro that expands to > the column definitions of the other table. So there is, so far, no such as > thing as two LIKE clauses contradicting. Whereas the access method is a >

Re: pg_upgrade test for binary compatibility of core data types

On Sat, Sep 11, 2021 at 07:51:16PM -0500, Justin Pryzby wrote: > These are all "translated" from test.sh, so follow its logic. > Maybe it should be improved, but that's separate from this patch - which is > already doing a few unrelated things. I was looking at this CF entry, and what you are doin

Re: Allow escape in application_name

At Fri, 01 Oct 2021 11:23:33 +0900 (JST), Kyotaro Horiguchi wrote in > function but that is apparently too-much complex. (It would be worth > doing if we share the same backbone processing with archive_command, > restore_command, recover_end_command and so on, but that is > necessarily accompan

Re: ResourceOwner refactoring

On Wed, Sep 08, 2021 at 01:19:19PM +0300, Aleksander Alekseev wrote: > Thanks for working on this! The latest patch does not apply anymore, and has been waiting on author for a couple of weeks now, so switched as RwF for now. -- Michael signature.asc Description: PGP signature

Re: Remove redundant initializations

On Sun, Sep 12, 2021 at 06:26:33PM -0700, Noah Misch wrote: > I'm +1 for the $SUBJECT concept, mostly because I take longer to read code > where immaterial zero-initialization lines are diluting the code. A quick > scan of the patch content is promising. If there's a decision to move > forward, I

Re: [EXTERNAL] Re: Add ETIMEDOUT to ALL_CONNECTION_FAILURE_ERRNOS

Oops sorry, I did make that change locally but apparently didn't update my .patch file after committing, so I uploaded an intermediary one... Thanks for fixing that. I saw you added this section to the commit message: > Perhaps this should be back-patched, but I'm hesitant to do so given > the l

Re: Toast compression method options

On Mon, Sep 13, 2021 at 05:10:22PM +0530, Dilip Kumar wrote: > I haved rebased the patch. Please note that the patch does not apply. FWIW, I still don't think that this is a good idea to have that. I don't recall seeing much on this list that users would like to have such a level of tuning for p

Re: postgres_fdw: Handle boolean comparison predicates

> On 1 Sep 2021, at 13:15, Daniel Gustafsson wrote: > >> On 31 May 2021, at 18:51, Emre Hasegeli wrote: >> >>> Please add this patch to the commitfest so that it's not forgotten. It >>> will be considered as a new feature so will be considered for commit >>> after the next commitfest. >> >> I

Re: Reserve prefixes for loaded libraries proposal

Il giorno ven 1 ott 2021 alle ore 00:26 Chapman Flack ha scritto: > > On 09/30/21 17:54, Florin Irion wrote: > > > We could also help users get a warning if they set a parameter with the > > `SET` command. > > This is funny. For years I have been so confident I knew how this worked > that I, obvio

Re: pg_receivewal starting position

On Mon, Sep 06, 2021 at 04:17:28PM +0900, Michael Paquier wrote: > Using READ_REPLICATION_SLOT as the command name is fine, and it could > be extended with more fields if necessary, implemented now with only > what we think is useful. Returning errors on cases that are still not > supported yet is

Re: Speed up transaction completion faster after many relations are accessed in a transaction

On Tue, Jul 20, 2021 at 05:04:19PM +1200, David Rowley wrote: > On Mon, 12 Jul 2021 at 19:23, David Rowley wrote: > > I also adjusted the hash seq scan code so that it performs better when > > faced a non-sparsely populated table. Previously my benchmark for > > that case didn't do well [2]. > >

Re: [PATCH] test/ssl: rework the sslfiles Makefile target

> On 1 Oct 2021, at 08:59, Michael Paquier wrote: > > On Wed, Sep 15, 2021 at 12:31:31AM +0200, Daniel Gustafsson wrote: >> Correct. In my head, "rebuild" is when dealing with individually changed >> files >> and "recreate" means rebuild everything regardless. Thats just my in my head >> thoug

Re: [PATCH] test/ssl: rework the sslfiles Makefile target

On Wed, Sep 15, 2021 at 12:31:31AM +0200, Daniel Gustafsson wrote: > Correct. In my head, "rebuild" is when dealing with individually changed > files > and "recreate" means rebuild everything regardless. Thats just my in my head > though, so clearly the wording should be expanded. Will do. So