On 9/22/21, 10:03 PM, "Amul Sul" <sula...@gmail.com> wrote: > On Tue, Sep 21, 2021 at 9:43 PM Bossart, Nathan <bossa...@amazon.com> wrote: >> Shouldn't we update the time in update_controlfile()? > > If you see the callers of update_controlfile() except for > RewriteControlFile() no one else updates the timestamp before calling > it, I am not sure if that is intentional or not. That was the one > reason that was added in UpdateControlFile(). And another reason is > that if you look at all the deleting lines followed by > UpdateControlFile() & moving that to UpdateControlFile() wouldn't > change anything drastically. > > IMO, anything going to change should update the timestamp as well, > that could be a bug then.
I'm inclined to agree that anything that calls update_controlfile() should update the timestamp. However, I wonder if the additional calls to time() would have a noticeable impact. Nathan
