On Fri, Oct 1, 2021 at 8:53 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > I think a straight standalone variable (probably a static boolean in > xloginsert.c) might be less confusing.
+1. > ... so, reading the xact.c code again, TransactionState->assigned really > means "whether the subXID-to-topXID association has been wal-logged", > which is a completely different meaning from what the term 'assigned' > means in all other comments in xact.c ... and I think the subroutine > name MarkSubTransactionAssigned() is not a great choice either. +1. -- Robert Haas EDB: http://www.enterprisedb.com
