On Sat, Sep 11, 2021 at 07:51:16PM -0500, Justin Pryzby wrote: > These are all "translated" from test.sh, so follow its logic. > Maybe it should be improved, but that's separate from this patch - which is > already doing a few unrelated things.
I was looking at this CF entry, and what you are doing in 0004 to move the tweaks from pg_upgrade's test.sh to a separate SQL script that uses psql's meta-commands like \if to check which version we are on is really interesting. The patch does not apply anymore, so this needs a rebase. The entry has been switched as waiting on author by Tom, but you did not update it after sending the new versions in [1]. I am wondering if we could have something cleaner than just a set booleans as you do here for each check, as that does not help with the readability of the tests. [1]: https://www.postgresql.org/message-id/20210912005116.gf26...@telsasoft.com -- Michael
signature.asc
Description: PGP signature
