On code inspection it is revealed that in jpegloader.c->decompressIndirect() we
are allocating memory for "scanline_ptr", but if we error_exit() from
jpeg_read_scanlines() we are not releasing this memory.
Added release of "scanline_ptr" with NULL check at appropriate places.
As part of this fix
On Fri, 9 Jun 2023 05:18:16 GMT, Jayathirth D V wrote:
> On code inspection it is revealed that in jpegloader.c->decompressIndirect()
> we are allocating memory for "scanline_ptr", but if we error_exit() from
> jpeg_read_scanlines() we are not releasing this memory.
We should not use stack for array memory allocations in JNI.
Updated pango.c to use malloc for arrays and release them at appropriate places.
-
Commit messages:
- 8313856: Replace VLA with malloc in pango
Changes: https://git.openjdk.org/jfx/pull/1202/files
Webrev: https://webrevs.
On Mon, 7 Aug 2023 04:55:23 GMT, Jayathirth D V wrote:
> We should not use stack for array memory allocations in JNI.
> Updated pango.c to use malloc for arrays and release them at appropriate
> places.
This pull request has now been integrated.
Changeset: 1752b623
Author:Jayat
This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u.
We should not use stack memory for large VLA allocations in pango.c
-
Commit messages:
- Backport 1752b62320f9e42f6d0d2c1f8278cf2ab205a8f4
Changes: https://git.openjdk.org/jfx21u/pull/8/files
Webrev: https:
On Wed, 9 Aug 2023 05:13:36 GMT, Jayathirth D V wrote:
> This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u.
>
> We should not use stack memory for large VLA allocations in pango.c
@kevinrushforth and @arapte please review.
-
PR Comme
On Wed, 9 Aug 2023 05:13:36 GMT, Jayathirth D V wrote:
> This is backport of https://bugs.openjdk.org/browse/JDK-8313856 to jfx21u.
>
> We should not use stack memory for large VLA allocations in pango.c
This pull request has now been integrated.
Changeset: 4ff0b7d8
Author:Jayat
On Fri, 11 Aug 2023 06:14:58 GMT, Ambarish Rapte wrote:
> This is a simple change to add a missing default statement.
> @kevinrushforth @jayathirthrao please review.
Marked as reviewed by jdv (Author).
-
PR Review: https://git.openjdk.org/jfx/pull/1206#pullrequestreview-1573221415
On Fri, 11 Aug 2023 07:20:15 GMT, Ambarish Rapte wrote:
> The mime name should be exactly same as the mime type supported by platform.
> Hence the comparison should not match partially similar names.
> Added an invalid unit test.
>
> @kevinrushforth @jayathirthrao please review
Marked as review
On Mon, 14 Aug 2023 09:18:00 GMT, Ambarish Rapte wrote:
>> The mime name should be exactly same as the mime type supported by platform.
>> Hence the comparison should not match partially similar names.
>> Added an invalid unit test.
>>
>> @kevinrushforth @jayathirthrao please review
>
> Ambarish
At multiple places in native glass code we don't have appropriate NULL checks
which might result in null pointer access.
Added appropriate checks and all test run is green.
-
Commit messages:
- 8315074: Possible null pointer access in native glass
Changes: https://git.openjdk.org/
> At multiple places in native glass code we don't have appropriate NULL checks
> which might result in null pointer access.
>
> Added appropriate checks and all test run is green.
Jayathirth D V has updated the pull request incrementally with one additional
commit since
On Tue, 29 Aug 2023 07:03:32 GMT, Marius Hanl wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typo
>
> modules/javafx.graphics/src/main/native-glass/gtk/GlassApplicat
Currently only 18 out of 62 3D tests run properly in jfx-tests repo.
All the shape tests under "test/scenegraph/fx3d/shapes" and
"test/scenegraph/fx3d/subscene/shapes" fail because they are not able to find
image input they need.
Image files currently are at wrong place and they are moved to pro
Out of 62 3D tests, 26 tests fail because of minute color differences in edge
pixels.
These tests are used to verify 3D rendering with different parameters like
translation, rotation.
So adding little color tolerance will not change the test behavior and allows
us to use these tests to automati
On Thu, 7 Sep 2023 09:26:59 GMT, Ajit Ghaisas wrote:
> A few SceneGraphTests and ControlsTests/chart test classes are abstract
> classes and serve as base classes for other tests.
> They are excluded from test execution and hence result in avoiding false
> failure reports.
LGTM.
I think in 3D
Two perspective lod tests fail because of minute differences in expected values.
Failing tests:
test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java:
test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.java:
Exception:
test test.scenegraph.fx3d.lod.LodTests.sphereInitialLightOnTest(): failure
org
On Fri, 8 Sep 2023 10:27:45 GMT, Ajit Ghaisas wrote:
> The changes are fine and they work. One suggestion is to define a common
> constant for 5% of tolerance value rather than using 0.05 in each of the
> changed file. This will allow us to adjust the tolerance percentage more
> easily in futu
On Thu, 7 Sep 2023 07:58:08 GMT, Jayathirth D V wrote:
> Currently only 18 out of 62 3D tests run properly in jfx-tests repo.
> All the shape tests under "test/scenegraph/fx3d/shapes" and
> "test/scenegraph/fx3d/subscene/shapes" fail because they are not able to
On Fri, 8 Sep 2023 12:15:35 GMT, Ajit Ghaisas wrote:
> A static constant can be added to
> `test.scenegraph.fx3d.utils.FX3DAbstractApp` public static final float
> COLOR_TOLERANCE = 0.05f;
>
> This can easily be accessed in test classes without FX3DAbstractApp instance
> as - `Root.ROOT.getEn
uild/test.workdir/test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.jtr)
>
> Also i see that some of the camera tests just draw white images, this also
> needs to be verified.
> With this change 41 out of 62 3D tests will run properly.
Jayathirth D V has updated the pull re
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge
> pixels.
> These tests are used to verify 3D rendering with different parameters like
> translation, rotation.
>
> So adding little color
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote:
> Out of 62 3D tests, 26 tests fail because of minute color differences in edge
> pixels.
> These tests are used to verify 3D rendering with different parameters like
> translation, rotation.
>
> So adding little color
On Fri, 8 Sep 2023 17:05:41 GMT, Alexandre Iline wrote:
>> There was a field in a subclass hiding a field in a superclass.
>
> @jayathirthrao FYI
Thanks @shurymury for fixing this.
I have verified that this change fixes subtests which were failing because of
`java.lang.NullPointerException: Ca
On Mon, 28 Aug 2023 04:58:31 GMT, Jayathirth D V wrote:
> At multiple places in native glass code we don't have appropriate NULL checks
> which might result in null pointer access.
>
> Added appropriate checks and all test run is green.
This pull request has now been integ
This is jfx21u backport of https://bugs.openjdk.org/browse/JDK-8315074.
It adds appropriate null checks in glass code.
-
Commit messages:
- Backport f7b21e5468f1aad18df17443590c0887b2cf0239
Changes: https://git.openjdk.org/jfx21u/pull/15/files
Webrev: https://webrevs.openjdk.org/?r
On Wed, 13 Sep 2023 16:01:34 GMT, Jayathirth D V wrote:
> This is jfx21u backport of https://bugs.openjdk.org/browse/JDK-8315074.
> It adds appropriate null checks in glass code.
This pull request has now been integrated.
Changeset: c80b74a2
Author:Jayathirth D V
Committer:
When we run 3D picking tests under test/scenegraph/fx3d/picking/parallel/
nothing is displayed on the window and subscene parallel camera tests under
test/scenegraph/fx3d/subscene/picking/parallel/ throw
UnsupportedOperationException.
Subscene parallel camera tests are incomplete and even if we
On Fri, 22 Sep 2023 09:40:31 GMT, Jayathirth D V wrote:
> When we run 3D picking tests under test/scenegraph/fx3d/picking/parallel/
> nothing is displayed on the window and subscene parallel camera tests under
> test/scenegraph/fx3d/subscene/picking/parall
While debugging subscene picking tests it was identified that in subscene mouse
events are not captured when we click on area where nothing is drawn or filled.
All the picking tests actually click on these null points and expect a mouse
event. This causes TimeoutExpiredException when subscene is
On Fri, 29 Sep 2023 11:03:56 GMT, Jayathirth D V wrote:
> While debugging subscene picking tests it was identified that in subscene
> mouse events are not captured when we click on area where nothing is drawn or
> filled.
> All the picking tests actually click on these null points
On Fri, 8 Sep 2023 13:13:56 GMT, Kevin Rushforth wrote:
> Two questions:
>
> 1. Have you run this on Windows to ensure that the D3D pipeline also
> passes with this change?
>
> 2. It might be better to compare using a tolerance rather than relying on
> an exact value being computed in
change in product might change lod
> values.
>
> With updated lod values i have verified that both the tests pass in OpenGL
> and Metal pipeline with both retina display(scale = 2) and external
> monitor(scale = 1).
Jayathirth D V has updated the pull request incrementally with
change in product might change lod
> values.
>
> With updated lod values i have verified that both the tests pass in OpenGL
> and Metal pipeline with both retina display(scale = 2) and external
> monitor(scale = 1).
Jayathirth D V has updated the pull request with a new target
In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking for
range when we read data from the source/destination buffers in native code.
We need to add appropriate range checks in native JNI code also apart from
range checks in Java side to make sure that wherever these JNI me
On Mon, 30 Oct 2023 15:16:45 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-decora/SSELinearConvolveShadowPeer.cc
>> line 133:
>>
>>> 131: dstrows > srcrows) { // We should not move out of source
>>> vertical bounds
>>> 132: return;
>>> 133: }
>>
>>
to make sure that wherever these JNI methods are
> used we are not performing out of bounds access.
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Add common util function
-
Changes:
- all: https://git.openjdk.or
to make sure that wherever these JNI methods are
> used we are not performing out of bounds access.
Jayathirth D V has updated the pull request incrementally with two additional
commits since the last revision:
- Update checkRange arguments indentation
- Add checkRange function comment
--
On Tue, 31 Oct 2023 14:54:01 GMT, Kevin Rushforth wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add common util function
>
> modules/javafx.graphics/src/main/native-decora/S
On Mon, 30 Oct 2023 06:55:11 GMT, Jayathirth D V wrote:
> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking
> for range when we read data from the source/destination buffers in native
> code.
>
> We need to add appropriate range checks in native JNI
This is jfx21u backport of https://bugs.openjdk.org/browse/JDK-8319079
It adds appropriate range checks in native code for Box/Gaussian Blur/Shadow
effects in Software pipeline.
-
Commit messages:
- Backport 96e5d10a40dc25b999ff229f1d6601d1058761b2
Changes: https://git.openjdk.org/
On Thu, 2 Nov 2023 13:47:26 GMT, Kevin Rushforth wrote:
> Looks good. Please file a follow-up bug to get the tests running on Windows.
I have created follow-up issue https://bugs.openjdk.org/browse/JDK-8319329 for
Windows.
-
PR Comment: https://git.openjdk.org/jfx-tests/pull/6#iss
On Fri, 8 Sep 2023 07:07:40 GMT, Jayathirth D V wrote:
> Two perspective lod tests fail because of minute differences in expected
> values.
>
> Failing tests:
> test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java:
> test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.jav
On Thu, 2 Nov 2023 16:26:57 GMT, Jayathirth D V wrote:
> This is jfx21u backport of https://bugs.openjdk.org/browse/JDK-8319079
> It adds appropriate range checks in native code for Box/Gaussian Blur/Shadow
> effects in Software pipeline.
This pull request has now been integrated.
IJG has released latest version of libjpeg 9f and we need to update our version
also match 9f changes.
IJG reference : https://www.ijg.org/
With updated changes both headless and headful tests are green on all platforms.
Also while updating to 9f noticed that many files don't have latest copyrig
ed that many files don't have latest copyright
> year and comments from previous version updates like 9e, so updated that part
> also to match 9f version.
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Update
---
ed that many files don't have latest copyright
> year and comments from previous version updates like 9e, so updated that part
> also to match 9f version.
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Update proper numbe
On Thu, 29 Feb 2024 06:21:34 GMT, Ambarish Rapte wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update
>
> modules/javafx.graphics/src/main/native-iio/libjpeg/UPDATING.txt line 12
On Tue, 20 Feb 2024 05:50:19 GMT, Jayathirth D V wrote:
> IJG has released latest version of libjpeg 9f and we need to update our
> version also match 9f changes.
> IJG reference : https://www.ijg.org/
>
> With updated changes both headless and headful tests are green on a
This is 22u backport for updating libjpeg version to 9f.
Original bug : https://bugs.openjdk.org/browse/JDK-8324233
-
Commit messages:
- Backport b99eb45828317e4c195b46eb0c9371d4645f2c6c
Changes: https://git.openjdk.org/jfx22u/pull/15/files
Webrev: https://webrevs.openjdk.org/?repo
On Thu, 29 Feb 2024 16:09:47 GMT, Jayathirth D V wrote:
> This is 22u backport for updating libjpeg version to 9f.
> Original bug : https://bugs.openjdk.org/browse/JDK-8324233
This pull request has now been integrated.
Changeset: e54102ca
Author:Jayathirth D V
Committer: Kevin Rus
Updated test to get screen capture in different platforms to see how we are
picking colors. Found that this test fails because it assumes that red,green &
blue bands in the test image are of equal size and picks color based on that
assumption.
If we take 20 * 20 aligned image, each scanline is
On Wed, 13 Mar 2024 08:56:13 GMT, Jayathirth D V wrote:
> Updated test to get screen capture in different platforms to see how we are
> picking colors. Found that this test fails because it assumes that red,green
> & blue bands in the test image are of equal size and picks c
This test has failed once and we are not seeing its failure after that instance
in our test systems.
This test verifies whether bounds of GridPane gets updated properly on adding
an invisible node.
Initial test has 8 nodes in GridPane and then we update it with another node
with larger bounds w
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renamed constant
> - Updated be
On Mon, 25 Mar 2024 14:26:10 GMT, Kevin Rushforth wrote:
>> This test has failed once and we are not seeing its failure after that
>> instance in our test systems.
>>
>> This test verifies whether bounds of GridPane gets updated properly on
>> adding an invisible node.
>> Initial test has 8 no
On Mon, 25 Mar 2024 16:40:56 GMT, Andy Goryachev wrote:
>> This test has failed once and we are not seeing its failure after that
>> instance in our test systems.
>>
>> This test verifies whether bounds of GridPane gets updated properly on
>> adding an invisible node.
>> Initial test has 8 nod
est is updated to:
> 1) To always show on top, so that we pick proper color.
> 2) Add additional sleep so that we give more time for test to be visible.
> 3) Pick color exactly at mid point in y axis, so that we pick the green color
> properly.
Jayathirth D V has updated the pull reques
On Mon, 25 Mar 2024 12:25:33 GMT, Jayathirth D V wrote:
> This test has failed once and we are not seeing its failure after that
> instance in our test systems.
>
> This test verifies whether bounds of GridPane gets updated properly on adding
> an invisible node.
> Initial t
In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag is
not defined and we don't see any issue) to enable printing of memory statistics
log. But if we enable it, we get crash while disposing IJG stored objects in
jmemmgr->free-pool() function.
#
# A fatal error has bee
On Fri, 24 May 2024 06:48:50 GMT, Jayathirth D V wrote:
> In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag
> is not defined and we don't see any issue) to enable printing of memory
> statistics log. But if we enable it, we get crash while d
This PR is for open-sourcing HelloFXCanvas test app.
JBS : https://bugs.openjdk.org/browse/JDK-8211247
It is an SWT app with SWT button and an FXCanvas with animated rectangle.
This is used on our integration testing.
This test is now moved to apps/toys, please refer to
apps/toys/HelloFXCanvas/R
This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
JBS : https://bugs.openjdk.org/browse/JDK-8211234
1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
application
2)HelloWorld contains 2 test apps :
- HelloJFXPanel - a simple Swing test app with a
On Mon, 28 Oct 2024 17:36:56 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Wed, 30 Oct 2024 18:16:26 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swt
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has update
This PR removes AccessController.doPrivileged() calls in
javafx.graphics/com.sun.glass. It is part of umbrella task
[JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441).
Also wherever classes are implementing PrivilegedAction they are replaced with
java.util.Supplier and get().
I have re
On Fri, 1 Nov 2024 16:59:50 GMT, Kevin Rushforth wrote:
> 2. This patch causes a failure in one of our closed white-box tests,
> which depends on internal API that has changed. It will be easy for us to fix
> it, but it will mean that down the road, when this is ready to go in, we will
> n
On Sat, 9 Nov 2024 07:43:43 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
On Tue, 17 Sep 2024 15:33:06 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
> JBS : https://bugs.openjdk.org/browse/JDK-8211234
>
> 1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
> application
&g
On Tue, 17 Sep 2024 14:29:11 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing HelloFXCanvas test app.
> JBS : https://bugs.openjdk.org/browse/JDK-8211247
> It is an SWT app with SWT button and an FXCanvas with animated rectangle.
> This is used on our integration testin
- HelloJFXPanel - a simple Swing test app with a JButton and a JFXPanel
> containing an animated rectangle
>
> - HelloJFXPanel2 - a simple Swing test app with a JButton and a JFXPanel
> containing a JavaFX Button and ComboBox (with Tooltips)
>
> These new test apps are added un
On Wed, 18 Sep 2024 14:00:24 GMT, Kevin Rushforth wrote:
> Ah, never mind. I see that you already resolved the conflict. I'll re-review
> then.
Yes Kevin, i was pushing the changes one after another because i was also
suspecting merge conflict in apps/toys/build.xml
-
PR Comment:
On Wed, 18 Sep 2024 15:25:47 GMT, Lukasz Kostyra wrote:
>> This PR migrates RenderPerf performance test application from jfx-sandbox
>> metal branch:
>> https://github.com/openjdk/jfx-sandbox/tree/metal/tests/performance/animation/RenderPerfTest/src/renderperf
>>
>> RenderPerf is a performance
On Sat, 2 Nov 2024 05:02:20 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
l.Supplier and get().
>
> I have removed reference to all AccessControl** class except in
> `Accessible.java` assuming that AccessControlContext from this class might be
> needed at some other place and its better if we remove it under
> [JDK-8342993](https://bugs.openjdk.org/br
On Tue, 5 Nov 2024 14:39:03 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Accessible.java line
>> 169:
>>
>>> 167: getAttribute.attribute = attribute;
>>> 168: getAttribute.parameters = parameters;
>>> 169: return getAt
l.Supplier and get().
>
> I have removed reference to all AccessControl** class except in
> `Accessible.java` assuming that AccessControlContext from this class might be
> needed at some other place and its better if we remove it under
> [JDK-8342993](https://bugs.openjdk.org/br
On Wed, 6 Nov 2024 15:37:23 GMT, Kevin Rushforth wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update based on review comments
>
> modules/javafx.graphics/src/main/java/com/sun
On Tue, 5 Nov 2024 06:12:20 GMT, Jayathirth D V wrote:
> This PR removes AccessController.doPrivileged() calls in
> javafx.graphics/com.sun.glass. It is part of umbrella task
> [JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441).
>
> Also wherever classes a
On Tue, 28 Jan 2025 21:23:37 GMT, Kevin Rushforth wrote:
> We currently skip 4 failing lighting tests on macOS 14 / aarch64. Those same
> tests fail on macOS 15 now, so this modifies the check used to skip those
> tests to macOS 14 _or later_ / aarch64.
>
> I'll run a CI test build on macOS 15
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote:
>> Allows MenuBar to be created in a background thread by delaying
>> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
>> scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to
On Tue, 1 Apr 2025 15:51:07 GMT, Jayathirth D V wrote:
> SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04 and wayland when we use
> < JDK 24.
>
> This is happening because of issue identified in
> https://bugs.openjdk.org/browse/JDK-8335468 and it is fixed in JDK 24.
&
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote:
> SwingNodePlatformExitCrashTest hangs while running on wayland, we need to
> skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009
> is fixed.
This pull request has been closed without being i
SwingNodePlatformExitCrashTest hangs while running on wayland, we need to skip
this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009 is fixed.
-
Commit messages:
- 8353163: [XWayland] Disable SwingNodePlatformExitCrashTest on wayland
Changes: https://git.openjdk.or
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote:
>> Allows MenuBar to be created in a background thread by delaying
>> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
>> scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote:
> SwingNodePlatformExitCrashTest hangs while running on wayland, we need to
> skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009
> is fixed.
I ran the test multiple times with wayland and JDK 24 on Ub
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote:
>> Allows MenuBar to be created in a background thread by delaying
>> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
>> scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote:
>> Allows MenuBar to be created in a background thread by delaying
>> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
>> scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to
SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04 and wayland when we use <
JDK 24.
This is happening because of issue identified in
https://bugs.openjdk.org/browse/JDK-8335468 and it is fixed in JDK 24.
So we need to run this test on wayland only when we use JDK 24 or later.
Test is updated
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote:
>> Allows MenuBar to be created in a background thread by delaying
>> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
>> scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to
On Thu, 24 Apr 2025 14:03:58 GMT, Jayathirth D V wrote:
> Backport of https://bugs.openjdk.org/browse/JDK-8318985 to jfx24u.
> Fix is trivial and it resolves specular power issue on OpenGL pipeline for 3D
> primitives.
This pull request has now been integrated.
Changeset: 61b628
On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V wrote:
> When no specular color is set while rendering 3D primitives, 0.0 specular
> power value is used by default in our shaders.
> When same specular power value is used in pow() function in shader it results
> in undefined
When no specular color is set while rendering 3D primitives, 0.0 specular power
value is used by default in our shaders.
When same specular power value is used in pow() function in shader it results
in undefined behaviour as mentioned at :
https://registry.khronos.org/OpenGL-Refpages/es3.0/html/
On Wed, 23 Apr 2025 13:59:43 GMT, Ambarish Rapte wrote:
>> When no specular color is set while rendering 3D primitives, 0.0 specular
>> power value is used by default in our shaders.
>> When same specular power value is used in pow() function in shader it
>> results in undefined behaviour as me
On Wed, 23 Apr 2025 12:31:49 GMT, Ambarish Rapte wrote:
>> When no specular color is set while rendering 3D primitives, 0.0 specular
>> power value is used by default in our shaders.
>> When same specular power value is used in pow() function in shader it
>> results in undefined behaviour as me
As part of https://bugs.openjdk.org/browse/JDK-8353557,
InitializeJavaFXLaunchTests were disabled as they were failing in Ubuntu24.04
VM and product issue https://bugs.openjdk.org/browse/JDK-8353644 was created.
But after verifying this test on actual Ubuntu 24.04 hardware it is identified
that
On Wed, 23 Apr 2025 15:27:23 GMT, Jayathirth D V wrote:
> As part of https://bugs.openjdk.org/browse/JDK-8353557,
> InitializeJavaFXLaunchTests were disabled as they were failing in Ubuntu24.04
> VM and product issue https://bugs.openjdk.org/browse/JDK-8353644 was created.
>
Backport of https://bugs.openjdk.org/browse/JDK-8318985 to jfx24u.
Fix is trivial and it resolves specular power issue on OpenGL pipeline for 3D
primitives.
-
Commit messages:
- Backport 2617ff5c891ba182581d323d8b424e4b8a6a6b63
Changes: https://git.openjdk.org/jfx24u/pull/25/files
On Mon, 31 Mar 2025 23:11:42 GMT, Andy Goryachev wrote:
> Further additions to the MonkeyTester application:
>
> - platform preferences monitor
> - improved pages: hbox, vbox
> - improved css playground
> - mouse listener option in some context menus
> - additional choices: background
> - additi
On Fri, 4 Apr 2025 11:55:34 GMT, Kevin Rushforth wrote:
> The changes look good. I'll do a quick test as well and then approve. Please
> make sure you've done a full automated test run before integrating.
I have run full automated test run and all updated tests behave as expected on
all test p
1 - 100 of 110 matches
Mail list logo
