On Fri, 8 Sep 2023 10:27:45 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
> The changes are fine and they work. One suggestion is to define a common > constant for 5% of tolerance value rather than using 0.05 in each of the > changed file. This will allow us to adjust the tolerance percentage more > easily in future. One possible place to define this constant is - > `test.scenegraph.fx3d.utils.FX3DAbstractApp` as this class is imported in all > the test cases. I added tolerance variable in `test.scenegraph.fx3d.utils.FX3DAbstractApp` but i can access the member variable only after we get its instance at the end of setUp() functions of each test. We do other things before call getInstance() and the suggestion to set tolerance was at the start of these setUp() functions. Right now i am not sure whether we can add tolerance at the end of setUp() functions and how it might change test behaviour. Its better to add the common tolerance variable in a separate fix with additional verification. ------------- PR Comment: https://git.openjdk.org/jfx-tests/pull/5#issuecomment-1711522136
