> Out of 62 3D tests, 26 tests fail because of minute color differences in edge > pixels. > These tests are used to verify 3D rendering with different parameters like > translation, rotation. > > So adding little color tolerance will not change the test behavior and allows > us to use these tests to automatically verify any regression introduced in 3D > rendering. > > Added 5% color tolerance and with this change 23 of these tests pass. > > Some sub-tests under below 3 tests continue to fail because of other reasons: > [test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/fixedeye/PerspectiveCameraFixedEyeIsolateTest.jtr) > [test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/parallel/ParallelCameraIsolateTest.jtr) > [test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.java](file:///Users/jdv/dev/workspace/jfx/jfx-tests/functional/3DTests/build/test.workdir/test/scenegraph/fx3d/camera/perspective/PerspectiveCameraIsolateTest.jtr) > > Also i see that some of the camera tests just draw white images, this also > needs to be verified. > With this change 41 out of 62 3D tests will run properly.
Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Use common tolerance variable ------------- Changes: - all: https://git.openjdk.org/jfx-tests/pull/5/files - new: https://git.openjdk.org/jfx-tests/pull/5/files/70f97e8c..b3d3aa25 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx-tests&pr=5&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx-tests&pr=5&range=00-01 Stats: 53 lines in 27 files changed: 27 ins; 0 del; 26 mod Patch: https://git.openjdk.org/jfx-tests/pull/5.diff Fetch: git fetch https://git.openjdk.org/jfx-tests.git pull/5/head:pull/5 PR: https://git.openjdk.org/jfx-tests/pull/5
