On Mon, 30 Oct 2023 15:16:45 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-decora/SSELinearConvolveShadowPeer.cc
>> line 133:
>>
>>> 131: dstrows > srcrows) { // We should not move out of source
>>> vertical bounds
>>> 132: return;
>>> 133: }
>>
>> Instead of copy-pasting the same checks in all the missing places, isn't it
>> better to create a check method (say in `SSEUtils`) and call if from all the
>> places? Like in the style of `java.util.Objects::checkRange`.
>
> If the checks are identical, that could be a useful change.
Thanks for the inputs.
Apart from single check all others are identical, so i have added common
utility function.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1272#discussion_r1377084907
