On Mon, 25 Mar 2024 14:26:10 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This test has failed once and we are not seeing its failure after that >> instance in our test systems. >> >> This test verifies whether bounds of GridPane gets updated properly on >> adding an invisible node. >> Initial test has 8 nodes in GridPane and then we update it with another node >> with larger bounds without making it visible. After adding additional node >> we make the scenegraph visible and check for colors of the newly added node. >> >> We are making this test robust to make sure we don't see any of these single >> instance failures. >> Test is updated to: >> 1) To always show on top, so that we pick proper color. >> 2) Add additional sleep so that we give more time for test to be visible. >> 3) Pick color exactly at mid point in y axis, so that we pick the green >> color properly. > > tests/system/src/test/java/test/robot/scenegraph/JDK8130122Test.java line 87: > >> 85: testScene.setFill(Color.WHITE); >> 86: testStage.setScene(testScene); >> 87: testStage.setAlwaysOnTop(true); > > This is redundant. `getStage()` already sets `alwaysOnTop`. If the window > currently isn't always on top then we have a bigger problem. I see that thanks, i didn't notice it. I will remove the change. I took https://github.com/openjdk/jfx/commit/56f2e17f#diff-43fd8d27727f352ddb3526031bd32e5d30aefa2bad722d1f3d21c4a0ca8a5a1f as an example and made this change. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1433#discussion_r1538643028
