On Sun, 15 Jun 2025 13:56:05 GMT, Marius Hanl wrote:
> Currently, the VirtualFlowTestUtils used ONLY for tests has many utility
> methods to get and do something with the VirtualFlow of Virtualized Controls.
>
> It has one flaw: It may creates a temporary Stage with the Stage
On Fri, 11 Jul 2025 15:11:27 GMT, Kevin Rushforth wrote:
>> This PR adds an introductory section to the JavaFX API docs similar to that
>> of the JDK docs.
>>
>> Compare the [JavaFX 24 API
>> docs](https://download.java.net/java/GA/javafx24/docs/api/index.html) with
>> the [JDK 24 API
>> doc
On Thu, 10 Jul 2025 19:43:15 GMT, Andy Goryachev wrote:
>> I thought about this as well. No strong opinion from my side.
>
> there should be no noise: it's more of a question of instructing the
> developer why their test failed. if there is no message, the NPE will happen
> in the context of t
).firePulse();` was needed.
> Previously, creating a new Stage for every call to the util methods did that
> implicitly.
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
Exception message
-
Changes:
- all: https:/
On Thu, 26 Jun 2025 21:02:26 GMT, Andy Goryachev wrote:
>> This is a good question, and I believe it is part of a broader discussion.
>> There are a number of places (e.g. here) where I use hardcoded, default
>> values which should be fine for most usecases I'm aware of. However, I
>> believe
On Mon, 23 Jun 2025 08:26:30 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
+1, good idea.Moving from JDK 22 to JDK 23 seems pretty unproblematic, so I think most people out there should not have a problem with that either.Also +1 for the idea of setting the minimum version to JDK N-2 in the future.- MariusAm 17.06.25, 17:49 schrieb Kevin Rushforth oracle.com>:
All,
Even
On Sat, 14 Jun 2025 11:37:30 GMT, Marius Hanl wrote:
> As written in the ticket, we might want to clarify that we use `JUnit5` for
> testing in the `CONTRIBUTING` guidelines.
>
> This is a first idea of how we could document this and also link to the JUnit
> page in case contr
On Mon, 16 Jun 2025 16:10:44 GMT, Marius Hanl wrote:
> Should we mention about JUnit5 under **Test your changes**
> ([here](https://github.com/openjdk/jfx/blob/fd30c94893156644c0d803b3e7fd8c9731d65fe6/CONTRIBUTING.md?plain=1#L66)),
> where we mention that a fix should have associa
(or `JUnit5` in
> particular).
>
> Feedback welcome!
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
Move JUnit5 reference to 'Test your changes'
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1828/files
On Mon, 16 Jun 2025 17:44:48 GMT, Andy Goryachev wrote:
>> Currently, the VirtualFlowTestUtils used ONLY for tests has many utility
>> methods to get and do something with the VirtualFlow of Virtualized Controls.
>>
>> It has one flaw: It may creates a temporary Stage with the StageLoader, when
On Tue, 17 Jun 2025 07:31:45 GMT, Johan Vos wrote:
> Hence, while I like the idea here (avoiding unneeded heavy-cost operations in
> VirtualFlow), I would like to avoid a number of follow-up issues once this is
> merged -- driven by a change in "expected" behavior.
I completely agree. We need
On Wed, 18 Jun 2025 09:04:32 GMT, Ambarish Rapte wrote:
> A simple change to remove `@Test` annotation from two graphics unit tests.
>
> The two tests have 2 test annotations `@Test` and `@RepeatedTest`, It results
> in warning message.
>
>
> WARNING: Possible configuration error: method [pub
On Mon, 16 Jun 2025 15:38:56 GMT, Andy Goryachev wrote:
>> (if possible) ?
>
> minor: maybe move L232 before L231?
> Should we mention about JUnit5 under **Test your changes**
> ([here](https://github.com/openjdk/jfx/blob/fd30c94893156644c0d803b3e7fd8c9731d65fe6/CONTRIBUTING.md?plain=1#L66)),
>
Currently, the VirtualFlowTestUtils used ONLY for tests has many utility
methods to get and do something with the VirtualFlow of Virtualized Controls.
It has one flaw: It may creates a temporary Stage with the StageLoader, when
the Control was never inside a Scene (and Stage) yet. This is done t
When calling `refresh()` on virtualized Controls (`ListView`, `TreeView`,
`TableView`, `TreeTableView`), all cells will be recreated completely, instead
of just refreshing them.
This is because `recreateCells()` of the `VirtualFlow` is called when
`refresh()` was called. This is not needed, sin
On Wed, 16 Apr 2025 08:51:36 GMT, John Hendrikx wrote:
> The "show details" hyperlink button in an alert dialog that has an expandable
> detail area wipes out its base style class by overwriting all styles. This
> means styling in modena.css that targets `.hyperlink` is no longer applied,
> li
As written in the ticket, we might want to clarify that we use `JUnit5` for
testing in the `CONTRIBUTING` guidelines.
This is a first idea of how we could document this and also link to the JUnit
page in case contributors are not familiar with the framework (or `JUnit5` in
particular).
Feedba
On Fri, 13 Jun 2025 14:26:04 GMT, Kevin Rushforth wrote:
> As noted in JBS, our GitHub Actions workflow uses
> `gradle/actions/wrapper-validation@v3`. We should update to the latest
> version, which is v4.
>
> In addition to it being a good idea to use the latest, we've seen a lot of
> interm
On Fri, 6 Jun 2025 14:37:40 GMT, Kevin Rushforth wrote:
>> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin
>> rasterizer with FFM.
>>
>> I broke this up into the following commits. The bulk of the work is in the
>> first two:
>>
>> 1. Encapsulate all off-heap acce
Vote: YES- Marius
Gesendet: Mittwoch, 28. Mai 2025 um 21:51
Von: "Kevin Rushforth"
An: openjfx-dev , "Alexander Zuev"
Betreff: CFV: New OpenJFX Committer: Alexander Zuev
I hereby nominate Alexander Zuev [1] to OpenJFX Committer.Alexander is a member of the JavaFX team at Oracle who has contrib
On Sat, 17 May 2025 12:24:46 GMT, Michael Strauß wrote:
>> When an exception is thrown from `AnimationTimer::handle`, the JavaFX
>> application freezes. The reason is that the user exception will bubble up
>> into framework code, preventing the normal operation of JavaFX.
>>
>> The following p
On Wed, 16 Apr 2025 18:48:09 GMT, Marius Hanl wrote:
> This PR enables `javafx.swt` tests for:
> - Windows
>
> Disabled on:
> - Linux, since some distros seems to have problems ->
> https://bugs.openjdk.org/browse/JDK-8356688
> - MacOS: The following warning is printe
On Sat, 10 May 2025 23:41:44 GMT, Marius Hanl wrote:
> This PR bumps the JUnit version to 5.12.2.
> Also removed 2 now unused variables since I phased out the JUnit Vintage
> Engine + Hamcrest.
>
> Changelog:
> https://junit.org/junit5/docs/current/release-notes/index.
This PR bumps the JUnit version to 5.12.2.
Also removed 2 now unused variables since I phased out the JUnit Vintage Engine
+ Hamcrest.
Changelog:
https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.12.2
The mentioned deprecations do not affect us.
Interesting new feat
restrictions. Use vmarg -XstartOnFirstThread`
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
link JDK tickets
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1783/files
- new: https://git.openjdk.org/jfx/pull/1783/files/a0f
restrictions. Use vmarg -XstartOnFirstThread`
Marius Hanl has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains five additional commits since
the last revision:
-
On Mon, 28 Apr 2025 09:38:06 GMT, Marius Hanl wrote:
>> This PR enables `javafx.swt` tests for:
>> - Windows
>>
>> Disabled on:
>> - Linux, since some distros seems to have problems
>> - MacOS: The following warning is printed right before the error:
>&g
On Thu, 1 May 2025 22:08:46 GMT, Ziad El Midaoui wrote:
> The issue was happening because `-fx-highlight-text-fill` was set to white ,
> so when the background color is bright (>60% brightness ) the text is not
> visible , the solution is to change the value to be dynamically set depending
> o
On Thu, 24 Apr 2025 16:55:58 GMT, Kevin Rushforth wrote:
> I confirm that this runs fine on my Windows 11 system.
>
> @Maran23 what platforms did you test this on? Windows?
>
> I fired off a CI headful test run, and I see the following failure on Ubuntu
> 22.04:
I setup an Ubuntu 24.04.2 LTS
I also like the idea.This is indeed something I also saw when debugging JavaFX.
And something I saw when looking into the VirtualFlow, which is the only class (beside Region) that uses setNeedsLayout(..) to improve the performance (and I was wondering why it only used there).I really wonder if thi
On Wed, 16 Apr 2025 19:00:53 GMT, Marius Hanl wrote:
>> With this change, you can now run the `swt` tests as easy as: `:swt:test
>> -PSWT_TEST=true`.
>> 
>>
>> Note: At one po
s. I don't see any reason for it, and one flag seems to be enough to me.
> But open for opinions on this one.
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
SWT_TEST default is false on MacOS
-
Changes:
- all: h
On Thu, 17 Apr 2025 18:09:57 GMT, Andy Goryachev wrote:
> both tickets are a duplicate of https://bugs.openjdk.org/browse/JDK-8264061
> fixed in jfx17, closed both. thanks!
I don't want to close them when I was just testing them! So thank you for
validating both tickets! :)
-
PR
s. I don't see any reason for it, and one flag seems to be enough to me.
> But open for opinions on this one.
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
8169285: SWT tests should run with IS_FULL_TEST
On Wed, 16 Apr 2025 18:23:01 GMT, Marius Hanl wrote:
> As discussed in #1778, those test does not need to be parameterized, we
> therefore can replace `@ParameterizedTest` and `@MethodSource` with `@Test`.
This pull request has now been integrated.
Changeset: a25935d1
Author:Mariu
On Wed, 16 Apr 2025 20:26:17 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8169285: SWT tests should run with IS_FULL_TEST
>
> build.gradle line 3085:
>
>
With this change, you can now run the `swt` tests as easy as: `:swt:test
-PSWT_TEST=true`.
Note: At one point `IS_FULL_TEST` was used as well for the enablement of the
tests. I don't see any reason for it,
On Wed, 16 Apr 2025 18:48:09 GMT, Marius Hanl wrote:
> With this change, you can now run the `swt` tests as easy as: `:swt:test
> -PSWT_TEST=true`.
> 
>
> Note: At one point `IS_FULL_TEST` w
On Wed, 16 Apr 2025 16:45:32 GMT, Andy Goryachev wrote:
>> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The
>> property getter returns the wrapper itself, but what it should be doing is
>> return the read-only getter instead.
>>
>> A single reviewer should be sufficient
As discussed in #1778, those test does not need to be parameterized, we
therefore can replace `@ParameterizedTest` and `@MethodSource` with `@Test`.
-
Commit messages:
- 8354794: [TestBug] LocalDateTimeStringConverterTest: Not all Tests needs to
be parameterized
Changes: https://g
On Tue, 15 Apr 2025 20:16:04 GMT, Marius Hanl wrote:
> [JDK-8297316](https://bugs.openjdk.org/browse/JDK-8297316) added a Workaround
> for the Japanese Date Converter, which is different on JDK20 and newer. Since
> our Boot JDK is Java 22 as of April 2025, we can remove the workaround
On Fri, 11 Apr 2025 20:36:48 GMT, Marius Hanl wrote:
> These are the remaining bits and pieces in order to completely remove the
> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
> After that, we should either document, that JUnit5 is used (just as
> information) or c
On Tue, 15 Apr 2025 22:19:24 GMT, Kevin Rushforth wrote:
> Yes, I would prefer a new JBS ticket. It would be OK to combine that as part
> of this PR, since both are test fixes touching the same file. It would also
> be OK to leave it for another day. Either is fine.
I created [JDK-8354794](htt
On Tue, 15 Apr 2025 22:32:38 GMT, Kevin Rushforth wrote:
> One option for [JDK-8169285](https://bugs.openjdk.org/browse/JDK-8169285)
> would be to enable it -- optionally on the `SWT_TEST` flag -- as part of
> _this_ PR. If you choose to do that, add that issue to this PR with`/issue
> add`.
for just
> one test.
>
> ~Note: I could not get the `:swt` tests to compile/test, in order to run the
> tests.
> I need some guidance here how to instruct `Gradle` to compile this module
> (and if I need anything else? like swt?).~
>
> ~Also, this probably needs an
On Tue, 15 Apr 2025 22:14:11 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix SWT Tests
>
> modules/javafx.swt/src/test/java/test/javafx/embed/swt/SWTTest
[JDK-8297316](https://bugs.openjdk.org/browse/JDK-8297316) added a Workaround
for the Japanese Date Converter, which is different on JDK20 and newer. Since
our Boot JDK is Java 22 as of April 2025, we can remove the workaround.
We should also consider testing and closing:
[JDK-8265727](https://
On Mon, 14 Apr 2025 20:29:32 GMT, Andy Goryachev wrote:
> SWT tests are disabled on MAC, because Gradle test runner does not handle
> -XstartOnFirstThread properly (https://issues.gradle.org/browse/GRADLE-3290).
Yeah I saw this as well and looked it up, may worth to do as follow-up, as
Kevin a
On Fri, 11 Apr 2025 21:34:37 GMT, Marius Hanl wrote:
>> modules/javafx.swt/src/test/java/test/javafx/embed/swt/SWTCursorsTest.java
>> line 44:
>>
>>> 42:
>>> 43: @Rule
>>> 44: public SwtRule ctx = new SwtRule();
>>
>> thi
for just
> one test.
>
> Note: I could not get the `:swt` tests to compile/test, in order to run the
> tests.
> I need some guidance here how to instruct `Gradle` to compile this module
> (and if I need anything else? like swt?).
>
> Also, this probably needs an extra t
On Fri, 11 Apr 2025 21:11:57 GMT, Andy Goryachev wrote:
>> These are the remaining bits and pieces in order to completely remove the
>> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX.
>> After that, we should either document, that JUnit5 is used (just as
>> information) or close
>> [J
On Fri, 11 Apr 2025 21:01:13 GMT, Kevin Rushforth wrote:
> @Maran23 We don't integrate code using the JBS ID of an umbrella tasks. If
> there is a need for a follow-on, we would file a new Bug or Enhancement issue
> in JBS and link it to the umbrella.
I thought so, will do!
If needed, we can a
These are the remaining bits and pieces in order to completely remove the JUnit
Vintage Engine, and therefore JUnit 4 from JavaFX.
After that, we should either document, that JUnit5 is used (just as
information) or close
[JDK-8296284](https://bugs.openjdk.org/browse/JDK-8296284) (Since you can n
if we really need API to disable it (as of now).
-- Marius
Gesendet: Freitag, 11. April 2025 um 21:27
Von: "Andy Goryachev"
An: "Marius Hanl" , "credm...@certak.com"
CC: "openjfx-dev@openjdk.org"
Betreff: Re: Re: [External] : Re: TabPane overflow menu sh
I wonder if we want to implement something similar in the TabPaneSkin as we did for the TableColumnHeader Column Menu.
See also: https://bugs.openjdk.org/browse/JDK-8091153 and the PR: https://github.com/openjdk/jfx/pull/1135
In a former PR, I made the creation of the menu lazily, so if the showCol
On Fri, 22 Nov 2024 20:31:08 GMT, Marius Hanl wrote:
> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
> for the `fixedCellSize` instead of adding listener just to update
> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be
&g
On Tue, 25 Mar 2025 21:55:54 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Thu, 6 Mar 2025 16:21:52 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (b
On Wed, 5 Mar 2025 15:54:49 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (b
On Tue, 22 Oct 2024 22:02:29 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>>
org/browse/JDK-8246745).
> Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887)
> (https://github.com/openjdk/jfx/pull/1644), but as written above, not
> required as there is no (visible) effect.
Marius Hanl has updated the pull request incrementally with one additi
On Thu, 6 Feb 2025 13:18:35 GMT, Marius Hanl wrote:
>> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
>> for the `fixedCellSize` instead of adding listener just to update
>> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwis
org/browse/JDK-8246745).
> Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887)
> (https://github.com/openjdk/jfx/pull/1644), but as written above, not
> required as there is no (visible) effect.
Marius Hanl has updated the pull request incrementally with one add
On Tue, 11 Feb 2025 21:16:32 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> An event handler was installed on the root property without removing it when
> the root changes.
>
> ## Solution
>
> Replaced the weak parts with a change listener to the root property to ensure
> correct handling of
org/browse/JDK-8246745).
> Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887)
> (https://github.com/openjdk/jfx/pull/1644), but as written above, not
> required as there is no (visible) effect.
Marius Hanl has updated the pull request with a new target base du
On Sat, 1 Feb 2025 12:57:34 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Tue, 4 Feb 2025 16:01:03 GMT, Ziad El Midaoui wrote:
>> When binding the promptTextProperty of a TextInputControl (TextField or
>> TextArea) to a text that contains linebreaks/newlines ("\n") the "bind" call
>> causes a RuntimeException to be thrown, the solution to it is to unbind
>> befor
On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Fri, 22 Nov 2024 16:32:49 GMT, Marius Hanl wrote:
> This PR fixes the horizontal virtualization performed in the
> `TableRowSkinBase`, which significantly improves performance with many
> columns (and thus many cells). Scrolling up and down as well as scrolling
> left and righ
On Thu, 16 Jan 2025 22:46:39 GMT, Andy Goryachev wrote:
>> Good to know, we should document your solution in more detail (and with the
>> concrete fix -> code snippet from the RTA) together with the HSB bug as a
>> new ticket probably? Then we may already have a potential solution with
>> code
On Thu, 16 Jan 2025 15:47:04 GMT, Andy Goryachev wrote:
>> That is right, but the `pulse` call will call `layout`, which will call
>> `layoutChildren` (when needed). I could also just call `layout` directly,
>> but want to keep it the same way as the actual Application would behave.
>
> Relying
On Thu, 16 Jan 2025 19:51:29 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 221:
>>
>>> 219: /** {@inheritDoc} */
>>> 220: @Override protected void layoutChildren(double x, double y, double
>>> w, double h) {
On Thu, 16 Jan 2025 20:50:47 GMT, Andy Goryachev wrote:
> The not-so-good news is that there is a configuration when the HSB remains,
> but once you click on it it disappears (might be hard to reproduce). In both
> this PR and with the master branch, the HSB remains even though it's not
> need
On Thu, 16 Jan 2025 12:26:19 GMT, Marius Hanl wrote:
>> This is more likely an 'accidential' fix. I changed this code because the
>> code in the super class changed (e.g. `updateCells` and `updateChildren`).
>> So while I see your point, if possible I would not tr
irtualFlow` sheet (as
> children). This will cause them to actually do the layout when requested, and
> especially when the height of the `TableView` changed drastically (e.g. from
> 50 visible cells to just 10), we have 40 cells laying around, receiving the
> layout request I added t
On Thu, 16 Jan 2025 12:18:03 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 221:
>>
>>> 219: /** {@inheritDoc} */
>>> 220: @Override protected void layoutChildren(double
irtualFlow` sheet (as
> children). This will cause them to actually do the layout when requested, and
> especially when the height of the `TableView` changed drastically (e.g. from
> 50 visible cells to just 10), we have 40 cells laying around, receiving the
> layout request I added
On Wed, 15 Jan 2025 19:22:50 GMT, Jose Pereda wrote:
>> Marius Hanl has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
On Thu, 16 Jan 2025 11:12:25 GMT, Jose Pereda wrote:
>> Unfortunately I don't think there is any other way. The `VirtualFlow` needs
>> two pulses (in real life applications) as the first time, the layout is not
>> yet correct for some cases (e.g. for `No ScrollBar` -> `ScrollBar`). I even
>> u
On Wed, 15 Jan 2025 18:50:58 GMT, Jose Pereda wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge branch 'master' of https://github.com/openjdk/j
On Thu, 16 Jan 2025 07:18:07 GMT, Johan Vos wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge branch 'master' of https://github.com/openjdk/j
irtualFlow` sheet (as
> children). This will cause them to actually do the layout when requested, and
> especially when the height of the `TableView` changed drastically (e.g. from
> 50 visible cells to just 10), we have 40 cells laying around, receiving the
> layout request I added t
On Tue, 10 Dec 2024 23:28:05 GMT, Andy Goryachev wrote:
>> It will be much better after https://github.com/openjdk/jfx/pull/1644 :)
>
> can you apply the same treatment as in #1644? there at least it makes sense.
I would say, lets merge https://github.com/openjdk/jfx/pull/1644 first and then
i
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculat
On Tue, 10 Dec 2024 18:07:44 GMT, Marius Hanl wrote:
> The JUnit Platform got some updates over the last years, so it is a good idea
> to update it to the newest version.
>
> That is from `5.8.1` to `5.11.3`.
> Affected dependencies:
> - `junit.jupiter`
> - `junit.plat
On Fri, 13 Dec 2024 19:46:54 GMT, Kevin Rushforth wrote:
> This PR fixes a latent test bug in test bug in
> `SwingNodePlatformExitCrashTest` by setting a flag to skip shutdown rather
> than relying on a quirk of JUnit 5.8.1.
>
> I discovered this while testing PR #1662 which updates JUnit to 5
On Thu, 12 Dec 2024 19:52:53 GMT, Andy Goryachev wrote:
> please address the merge conflict.
?
-
PR Comment: https://git.openjdk.org/jfx/pull/1462#issuecomment-2540033618
On Tue, 10 Dec 2024 22:03:04 GMT, Andy Goryachev wrote:
>> Yes, IntelliJ actually gave me the hint.
>> `isVisible` can only be `false`, when a `fixedCellSize` is set. So the else
>> branch can only ever be executed when `fixedCellSize > 0`
>
> it's hard to tell (for me): there are just too many
On Tue, 10 Dec 2024 21:10:54 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
The JUnit Platform got some updates over the last years, so it is a good idea
to update it to the newest version.
That is from `5.8.1` to `5.11.3`.
Affected dependencies:
- `junit.jupiter`
- `junit.platform`
- `opentest4j`
Release notes: https://junit.org/junit5/docs/5.11.3/release-notes/
Note:
org/browse/JDK-8246745).
> Helps a bit with [JDK-8185887](https://bugs.openjdk.org/browse/JDK-8185887)
> (https://github.com/openjdk/jfx/pull/1644), but as written above, not
> required as there is no (visible) effect.
Marius Hanl has updated the pull request with a new target base due
gt; When a Rectangle is used as clip without any effect or opacity modification,
> the rendering goes another (probably faster) route with rendering the clip.
> That's why setting the `opacity` to `0.99` fixes the issue - another route
> will be used for the rendering.
> This happ
On Thu, 5 Dec 2024 15:32:33 GMT, Andy Goryachev wrote:
> By the way, a Tree/TableView with 500 columns is barely usable - locks up the
> UI giving me a macOS spinning beach ball quite often. Not that it's a
> reasonable use case. 200 is ok. May be the 500 case can be used for profiling?
With f
irtualFlow` sheet (as
> children). This will cause them to actually do the layout when requested, and
> especially when the height of the `TableView` changed drastically (e.g. from
> 50 visible cells to just 10), we have 40 cells laying around, receiving the
> layout request I added t
On Thu, 5 Dec 2024 09:24:13 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 228:
>>
>>> 226: if (disclosureNodeDirty) {
>>> 227: updat
On Wed, 4 Dec 2024 09:18:41 GMT, Ambarish Rapte wrote:
> I tested the PR changes with a few a11y scenarios, and did not observe any
> issues.
Thank you for testing!
Out of interesting, is it 'enough' to test with the `Narrator` application on
Windows 11?
-
PR Comment: https://git
On Wed, 4 Dec 2024 12:27:54 GMT, Ambarish Rapte wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jfx
On Wed, 4 Dec 2024 20:13:31 GMT, Andy Goryachev wrote:
> It feels like the horizontal scrolling has improved a bit, the vertical
> exhibits the same slight hiccups as with the master branch.
Yes, especially if you try with many columns (> 100), scrolling up and down is
much faster (especially
1 - 100 of 659 matches
Mail list logo
