On Wed, 15 Jan 2025 18:50:58 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8185887-virtualization >> >> # Conflicts: >> # >> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8185887-virtualization >> >> # Conflicts: >> # >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java >> # >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java >> # >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> - 8185887: Reset disclosureNodeDirty in updateDisclosureNodeAndGraphic() >> - 8185887: TableRowSkinBase fails to correctly virtualize cells in >> horizontal direction > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkin.java > line 108: > >> 106: }); >> 107: } else { >> 108: DoubleProperty fixedCellSizeProperty = >> tableView.fixedCellSizeProperty(); > > Minor: Since you are modifying this part of the code, the method > `setupTreeTableViewListeners` should be renamed to `setupTableViewListeners` > (I see this is already done in your other PR #1645, but it wouldn't hurt > doing it here too) Sure, will change. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1918347783
