On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much >> simplified glyph layout (via stubbed fonts). The new layout assumes all the >> glyphs are squares of font size, while the bold type face produces wider >> glyphs (by 1 pixel). The default font size has changed from 10 to 12 to >> make it closer to win/linux. >> >> This brings the test environment closer to the product configuration and >> expands the capabilities of our headless testing pipeline, which will be >> useful for upcoming behavior tests. >> >> Existing tests have been adjusted/reworked mainly due to default font size >> change. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 19 additional > commits since the last revision: > > - atomic boolean > - Merge branch 'master' into 8342565.stub.text.layout > - cleanup > - better test > - cleanup > - more magic > - magic numbers > - more > - add exports > - stub fonts > - ... and 9 more: https://git.openjdk.org/jfx/compare/adaadda0...5010278f I think this is a good change, completely utilizing that the text layout code is abstracted away for good. Changes look good to me so far. Some tests are hard to understand the changes, but that is a preexisting problem (especially if the name of the test is just `rt_xxxx`). Not sure about the code style of using `S`, `M` or `L` as variable names (minor), so I will see what other reviewers say about this. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1667#issuecomment-2633256559
